mirror of
https://github.com/opentofu/opentofu.git
synced 2025-01-08 15:13:56 -06:00
3472cab7d6
Fixes #10042 Fixes #9989 Another panic was found with this resource. IT essentially was causing a panic when no certificates were found. This was due to the casting of status to []string There are times when there are no statuses passed in. Made the error message a lot more generic now rather than having something like this ``` No certificate with statuses [] for domain mytestdomain.com found in this region. ``` This now becomes: ``` No certificate for domain mytestdomain.com found in this region. ``` Also, added a test to show that the panic is gone ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAwsAcmCertificateDataSource_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/11/11 15:11:33 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAwsAcmCertificateDataSource_ -timeout 120m === RUN TestAccAwsAcmCertificateDataSource_noMatchReturnsError --- PASS: TestAccAwsAcmCertificateDataSource_noMatchReturnsError (6.07s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws6.094s ```
74 lines
1.7 KiB
Go
74 lines
1.7 KiB
Go
package aws
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/service/acm"
|
|
"github.com/hashicorp/errwrap"
|
|
"github.com/hashicorp/terraform/helper/schema"
|
|
)
|
|
|
|
func dataSourceAwsAcmCertificate() *schema.Resource {
|
|
return &schema.Resource{
|
|
Read: dataSourceAwsAcmCertificateRead,
|
|
Schema: map[string]*schema.Schema{
|
|
"domain": {
|
|
Type: schema.TypeString,
|
|
Required: true,
|
|
},
|
|
"arn": {
|
|
Type: schema.TypeString,
|
|
Computed: true,
|
|
},
|
|
"statuses": {
|
|
Type: schema.TypeList,
|
|
Optional: true,
|
|
Elem: &schema.Schema{Type: schema.TypeString},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func dataSourceAwsAcmCertificateRead(d *schema.ResourceData, meta interface{}) error {
|
|
conn := meta.(*AWSClient).acmconn
|
|
params := &acm.ListCertificatesInput{}
|
|
|
|
target := d.Get("domain")
|
|
|
|
statuses, ok := d.GetOk("statuses")
|
|
if ok {
|
|
statusStrings := statuses.([]interface{})
|
|
params.CertificateStatuses = expandStringList(statusStrings)
|
|
} else {
|
|
params.CertificateStatuses = []*string{aws.String("ISSUED")}
|
|
}
|
|
|
|
var arns []string
|
|
err := conn.ListCertificatesPages(params, func(page *acm.ListCertificatesOutput, lastPage bool) bool {
|
|
for _, cert := range page.CertificateSummaryList {
|
|
if *cert.DomainName == target {
|
|
arns = append(arns, *cert.CertificateArn)
|
|
}
|
|
}
|
|
|
|
return true
|
|
})
|
|
if err != nil {
|
|
return errwrap.Wrapf("Error describing certificates: {{err}}", err)
|
|
}
|
|
|
|
if len(arns) == 0 {
|
|
return fmt.Errorf("No certificate for domain %q found in this region.", target)
|
|
}
|
|
if len(arns) > 1 {
|
|
return fmt.Errorf("Multiple certificates for domain %q found in this region.", target)
|
|
}
|
|
|
|
d.SetId(time.Now().UTC().String())
|
|
d.Set("arn", arns[0])
|
|
|
|
return nil
|
|
}
|