opentofu/command/state_replace_provider_test.go
Alisdair McDiarmid 2d1976bbda clistate: Update clistate.Locker for command views
The clistate package includes a Locker interface which provides a simple
way for the local backend to lock and unlock state, while providing
feedback to the user if there is a delay while waiting for the lock.
Prior to this commit, the backend was responsible for initializing the
Locker, passing through direct access to the cli.Ui instance.

This structure prevented commands from implementing different
implementations of the state locker UI. In this commit, we:

- Move the responsibility of creating the appropriate Locker to the
  source of the Operation;
- Add the ability to set the context for a Locker via a WithContext
  method;
- Replace the Locker's cli.Ui and Colorize members with a StateLocker
  view;
- Implement views.StateLocker for human-readable UI;
- Update the Locker interface to return detailed diagnostics instead of
  errors, reducing its direct interactions with UI;
- Add a Timeout() method on Locker to allow the remote backend to
  continue to misuse the -lock-timeout flag to cancel pending runs.

When an Operation is created, the StateLocker field must now be
populated with an implementation of Locker. For situations where locking
is disabled, this can be a no-op locker.

This change has no significant effect on the operation of Terraform,
with the exception of slightly different formatting of errors when state
locking or unlocking fails.
2021-02-16 07:19:22 -05:00

330 lines
7.7 KiB
Go

package command
import (
"bytes"
"path/filepath"
"strings"
"testing"
"github.com/mitchellh/cli"
"github.com/hashicorp/terraform/addrs"
"github.com/hashicorp/terraform/states"
)
func TestStateReplaceProvider(t *testing.T) {
state := states.BuildState(func(s *states.SyncState) {
s.SetResourceInstanceCurrent(
addrs.Resource{
Mode: addrs.ManagedResourceMode,
Type: "aws_instance",
Name: "alpha",
}.Instance(addrs.NoKey).Absolute(addrs.RootModuleInstance),
&states.ResourceInstanceObjectSrc{
AttrsJSON: []byte(`{"id":"alpha","foo":"value","bar":"value"}`),
Status: states.ObjectReady,
},
addrs.AbsProviderConfig{
Provider: addrs.NewDefaultProvider("aws"),
Module: addrs.RootModule,
},
)
s.SetResourceInstanceCurrent(
addrs.Resource{
Mode: addrs.ManagedResourceMode,
Type: "aws_instance",
Name: "beta",
}.Instance(addrs.NoKey).Absolute(addrs.RootModuleInstance),
&states.ResourceInstanceObjectSrc{
AttrsJSON: []byte(`{"id":"beta","foo":"value","bar":"value"}`),
Status: states.ObjectReady,
},
addrs.AbsProviderConfig{
Provider: addrs.NewDefaultProvider("aws"),
Module: addrs.RootModule,
},
)
s.SetResourceInstanceCurrent(
addrs.Resource{
Mode: addrs.ManagedResourceMode,
Type: "azurerm_virtual_machine",
Name: "gamma",
}.Instance(addrs.NoKey).Absolute(addrs.RootModuleInstance),
&states.ResourceInstanceObjectSrc{
AttrsJSON: []byte(`{"id":"gamma","baz":"value"}`),
Status: states.ObjectReady,
},
addrs.AbsProviderConfig{
Provider: addrs.NewLegacyProvider("azurerm"),
Module: addrs.RootModule,
},
)
})
t.Run("happy path", func(t *testing.T) {
statePath := testStateFile(t, state)
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
inputBuf := &bytes.Buffer{}
ui.InputReader = inputBuf
inputBuf.WriteString("yes\n")
args := []string{
"-state", statePath,
"hashicorp/aws",
"acmecorp/aws",
}
if code := c.Run(args); code != 0 {
t.Fatalf("return code: %d\n\n%s", code, ui.ErrorWriter.String())
}
testStateOutput(t, statePath, testStateReplaceProviderOutput)
backups := testStateBackups(t, filepath.Dir(statePath))
if len(backups) != 1 {
t.Fatalf("unexpected backups: %#v", backups)
}
testStateOutput(t, backups[0], testStateReplaceProviderOutputOriginal)
})
t.Run("auto approve", func(t *testing.T) {
statePath := testStateFile(t, state)
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
inputBuf := &bytes.Buffer{}
ui.InputReader = inputBuf
args := []string{
"-state", statePath,
"-auto-approve",
"hashicorp/aws",
"acmecorp/aws",
}
if code := c.Run(args); code != 0 {
t.Fatalf("return code: %d\n\n%s", code, ui.ErrorWriter.String())
}
testStateOutput(t, statePath, testStateReplaceProviderOutput)
backups := testStateBackups(t, filepath.Dir(statePath))
if len(backups) != 1 {
t.Fatalf("unexpected backups: %#v", backups)
}
testStateOutput(t, backups[0], testStateReplaceProviderOutputOriginal)
})
t.Run("cancel at approval step", func(t *testing.T) {
statePath := testStateFile(t, state)
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
inputBuf := &bytes.Buffer{}
ui.InputReader = inputBuf
inputBuf.WriteString("no\n")
args := []string{
"-state", statePath,
"hashicorp/aws",
"acmecorp/aws",
}
if code := c.Run(args); code != 0 {
t.Fatalf("return code: %d\n\n%s", code, ui.ErrorWriter.String())
}
testStateOutput(t, statePath, testStateReplaceProviderOutputOriginal)
backups := testStateBackups(t, filepath.Dir(statePath))
if len(backups) != 0 {
t.Fatalf("unexpected backups: %#v", backups)
}
})
t.Run("no matching provider found", func(t *testing.T) {
statePath := testStateFile(t, state)
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
args := []string{
"-state", statePath,
"hashicorp/google",
"acmecorp/google",
}
if code := c.Run(args); code != 0 {
t.Fatalf("return code: %d\n\n%s", code, ui.ErrorWriter.String())
}
testStateOutput(t, statePath, testStateReplaceProviderOutputOriginal)
backups := testStateBackups(t, filepath.Dir(statePath))
if len(backups) != 0 {
t.Fatalf("unexpected backups: %#v", backups)
}
})
t.Run("invalid flags", func(t *testing.T) {
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
args := []string{
"-invalid",
"hashicorp/google",
"acmecorp/google",
}
if code := c.Run(args); code == 0 {
t.Fatalf("successful exit; want error")
}
if got, want := ui.ErrorWriter.String(), "Error parsing command-line flags"; !strings.Contains(got, want) {
t.Fatalf("missing expected error message\nwant: %s\nfull output:\n%s", want, got)
}
})
t.Run("wrong number of arguments", func(t *testing.T) {
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
args := []string{"a", "b", "c", "d"}
if code := c.Run(args); code == 0 {
t.Fatalf("successful exit; want error")
}
if got, want := ui.ErrorWriter.String(), "Exactly two arguments expected"; !strings.Contains(got, want) {
t.Fatalf("missing expected error message\nwant: %s\nfull output:\n%s", want, got)
}
})
t.Run("invalid provider strings", func(t *testing.T) {
ui := new(cli.MockUi)
view, _ := testView(t)
c := &StateReplaceProviderCommand{
StateMeta{
Meta: Meta{
Ui: ui,
View: view,
},
},
}
args := []string{
"hashicorp/google_cloud",
"-/-/google",
}
if code := c.Run(args); code == 0 {
t.Fatalf("successful exit; want error")
}
got := ui.ErrorWriter.String()
msgs := []string{
`Invalid "from" provider "hashicorp/google_cloud"`,
"Invalid provider type",
`Invalid "to" provider "-/-/google"`,
"Invalid provider source hostname",
}
for _, msg := range msgs {
if !strings.Contains(got, msg) {
t.Errorf("missing expected error message\nwant: %s\nfull output:\n%s", msg, got)
}
}
})
}
func TestStateReplaceProvider_docs(t *testing.T) {
c := &StateReplaceProviderCommand{}
if got, want := c.Help(), "Usage: terraform state replace-provider"; !strings.Contains(got, want) {
t.Fatalf("unexpected help text\nwant: %s\nfull output:\n%s", want, got)
}
if got, want := c.Synopsis(), "Replace provider in the state"; got != want {
t.Fatalf("unexpected synopsis\nwant: %s\nfull output:\n%s", want, got)
}
}
const testStateReplaceProviderOutputOriginal = `
aws_instance.alpha:
ID = alpha
provider = provider["registry.terraform.io/hashicorp/aws"]
bar = value
foo = value
aws_instance.beta:
ID = beta
provider = provider["registry.terraform.io/hashicorp/aws"]
bar = value
foo = value
azurerm_virtual_machine.gamma:
ID = gamma
provider = provider["registry.terraform.io/-/azurerm"]
baz = value
`
const testStateReplaceProviderOutput = `
aws_instance.alpha:
ID = alpha
provider = provider["registry.terraform.io/acmecorp/aws"]
bar = value
foo = value
aws_instance.beta:
ID = beta
provider = provider["registry.terraform.io/acmecorp/aws"]
bar = value
foo = value
azurerm_virtual_machine.gamma:
ID = gamma
provider = provider["registry.terraform.io/-/azurerm"]
baz = value
`