mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-26 17:01:04 -06:00
89b05050ec
Previously terraform.Context was built in an unfortunate way where all of the data was provided up front in terraform.NewContext and then mutated directly by subsequent operations. That made the data flow hard to follow, commonly leading to bugs, and also meant that we were forced to take various actions too early in terraform.NewContext, rather than waiting until a more appropriate time during an operation. This (enormous) commit changes terraform.Context so that its fields are broadly just unchanging data about the execution context (current workspace name, available plugins, etc) whereas the main data Terraform works with arrives via individual method arguments and is returned in return values. Specifically, this means that terraform.Context no longer "has-a" config, state, and "planned changes", instead holding on to those only temporarily during an operation. The caller is responsible for propagating the outcome of one step into the next step so that the data flow between operations is actually visible. However, since that's a change to the main entry points in the "terraform" package, this commit also touches every file in the codebase which interacted with those APIs. Most of the noise here is in updating tests to take the same actions using the new API style, but this also affects the main-code callers in the backends and in the command package. My goal here was to refactor without changing observable behavior, but in practice there are a couple externally-visible behavior variations here that seemed okay in service of the broader goal: - The "terraform graph" command is no longer hooked directly into the core graph builders, because that's no longer part of the public API. However, I did include a couple new Context functions whose contract is to produce a UI-oriented graph, and _for now_ those continue to return the physical graph we use for those operations. There's no exported API for generating the "validate" and "eval" graphs, because neither is particularly interesting in its own right, and so "terraform graph" no longer supports those graph types. - terraform.NewContext no longer has the responsibility for collecting all of the provider schemas up front. Instead, we wait until we need them. However, that means that some of our error messages now have a slightly different shape due to unwinding through a differently-shaped call stack. As of this commit we also end up reloading the schemas multiple times in some cases, which is functionally acceptable but likely represents a performance regression. I intend to rework this to use caching, but I'm saving that for a later commit because this one is big enough already. The proximal reason for this change is to resolve the chicken/egg problem whereby there was previously no single point where we could apply "moved" statements to the previous run state before creating a plan. With this change in place, we can now do that as part of Context.Plan, prior to forking the input state into the three separate state artifacts we use during planning. However, this is at least the third project in a row where the previous API design led to piling more functionality into terraform.NewContext and then working around the incorrect order of operations that produces, so I intend that by paying the cost/risk of this large diff now we can in turn reduce the cost/risk of future projects that relate to our main workflow actions.
285 lines
9.9 KiB
Go
285 lines
9.9 KiB
Go
package remote
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"log"
|
|
"strings"
|
|
|
|
tfe "github.com/hashicorp/go-tfe"
|
|
"github.com/hashicorp/hcl/v2"
|
|
"github.com/hashicorp/hcl/v2/hclsyntax"
|
|
"github.com/hashicorp/terraform/internal/backend"
|
|
"github.com/hashicorp/terraform/internal/configs"
|
|
"github.com/hashicorp/terraform/internal/states/statemgr"
|
|
"github.com/hashicorp/terraform/internal/terraform"
|
|
"github.com/hashicorp/terraform/internal/tfdiags"
|
|
"github.com/zclconf/go-cty/cty"
|
|
)
|
|
|
|
// Context implements backend.Local.
|
|
func (b *Remote) LocalRun(op *backend.Operation) (*backend.LocalRun, statemgr.Full, tfdiags.Diagnostics) {
|
|
var diags tfdiags.Diagnostics
|
|
ret := &backend.LocalRun{
|
|
PlanOpts: &terraform.PlanOpts{
|
|
Mode: op.PlanMode,
|
|
Targets: op.Targets,
|
|
},
|
|
}
|
|
|
|
op.StateLocker = op.StateLocker.WithContext(context.Background())
|
|
|
|
// Get the remote workspace name.
|
|
remoteWorkspaceName := b.getRemoteWorkspaceName(op.Workspace)
|
|
|
|
// Get the latest state.
|
|
log.Printf("[TRACE] backend/remote: requesting state manager for workspace %q", remoteWorkspaceName)
|
|
stateMgr, err := b.StateMgr(op.Workspace)
|
|
if err != nil {
|
|
diags = diags.Append(fmt.Errorf("error loading state: %w", err))
|
|
return nil, nil, diags
|
|
}
|
|
|
|
log.Printf("[TRACE] backend/remote: requesting state lock for workspace %q", remoteWorkspaceName)
|
|
if diags := op.StateLocker.Lock(stateMgr, op.Type.String()); diags.HasErrors() {
|
|
return nil, nil, diags
|
|
}
|
|
|
|
defer func() {
|
|
// If we're returning with errors, and thus not producing a valid
|
|
// context, we'll want to avoid leaving the remote workspace locked.
|
|
if diags.HasErrors() {
|
|
diags = diags.Append(op.StateLocker.Unlock())
|
|
}
|
|
}()
|
|
|
|
log.Printf("[TRACE] backend/remote: reading remote state for workspace %q", remoteWorkspaceName)
|
|
if err := stateMgr.RefreshState(); err != nil {
|
|
diags = diags.Append(fmt.Errorf("error loading state: %w", err))
|
|
return nil, nil, diags
|
|
}
|
|
|
|
// Initialize our context options
|
|
var opts terraform.ContextOpts
|
|
if v := b.ContextOpts; v != nil {
|
|
opts = *v
|
|
}
|
|
|
|
// Copy set options from the operation
|
|
opts.UIInput = op.UIIn
|
|
|
|
// Load the latest state. If we enter contextFromPlanFile below then the
|
|
// state snapshot in the plan file must match this, or else it'll return
|
|
// error diagnostics.
|
|
log.Printf("[TRACE] backend/remote: retrieving remote state snapshot for workspace %q", remoteWorkspaceName)
|
|
ret.InputState = stateMgr.State()
|
|
|
|
log.Printf("[TRACE] backend/remote: loading configuration for the current working directory")
|
|
config, configDiags := op.ConfigLoader.LoadConfig(op.ConfigDir)
|
|
diags = diags.Append(configDiags)
|
|
if configDiags.HasErrors() {
|
|
return nil, nil, diags
|
|
}
|
|
ret.Config = config
|
|
|
|
// The underlying API expects us to use the opaque workspace id to request
|
|
// variables, so we'll need to look that up using our organization name
|
|
// and workspace name.
|
|
remoteWorkspaceID, err := b.getRemoteWorkspaceID(context.Background(), op.Workspace)
|
|
if err != nil {
|
|
diags = diags.Append(fmt.Errorf("error finding remote workspace: %w", err))
|
|
return nil, nil, diags
|
|
}
|
|
|
|
log.Printf("[TRACE] backend/remote: retrieving variables from workspace %s/%s (%s)", remoteWorkspaceName, b.organization, remoteWorkspaceID)
|
|
tfeVariables, err := b.client.Variables.List(context.Background(), remoteWorkspaceID, tfe.VariableListOptions{})
|
|
if err != nil && err != tfe.ErrResourceNotFound {
|
|
diags = diags.Append(fmt.Errorf("error loading variables: %w", err))
|
|
return nil, nil, diags
|
|
}
|
|
|
|
if op.AllowUnsetVariables {
|
|
// If we're not going to use the variables in an operation we'll be
|
|
// more lax about them, stubbing out any unset ones as unknown.
|
|
// This gives us enough information to produce a consistent context,
|
|
// but not enough information to run a real operation (plan, apply, etc)
|
|
ret.PlanOpts.SetVariables = stubAllVariables(op.Variables, config.Module.Variables)
|
|
} else {
|
|
if tfeVariables != nil {
|
|
if op.Variables == nil {
|
|
op.Variables = make(map[string]backend.UnparsedVariableValue)
|
|
}
|
|
for _, v := range tfeVariables.Items {
|
|
if v.Category == tfe.CategoryTerraform {
|
|
op.Variables[v.Key] = &remoteStoredVariableValue{
|
|
definition: v,
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if op.Variables != nil {
|
|
variables, varDiags := backend.ParseVariableValues(op.Variables, config.Module.Variables)
|
|
diags = diags.Append(varDiags)
|
|
if diags.HasErrors() {
|
|
return nil, nil, diags
|
|
}
|
|
ret.PlanOpts.SetVariables = variables
|
|
}
|
|
}
|
|
|
|
tfCtx, ctxDiags := terraform.NewContext(&opts)
|
|
diags = diags.Append(ctxDiags)
|
|
ret.Core = tfCtx
|
|
|
|
log.Printf("[TRACE] backend/remote: finished building terraform.Context")
|
|
|
|
return ret, stateMgr, diags
|
|
}
|
|
|
|
func (b *Remote) getRemoteWorkspaceName(localWorkspaceName string) string {
|
|
switch {
|
|
case localWorkspaceName == backend.DefaultStateName:
|
|
// The default workspace name is a special case, for when the backend
|
|
// is configured to with to an exact remote workspace rather than with
|
|
// a remote workspace _prefix_.
|
|
return b.workspace
|
|
case b.prefix != "" && !strings.HasPrefix(localWorkspaceName, b.prefix):
|
|
return b.prefix + localWorkspaceName
|
|
default:
|
|
return localWorkspaceName
|
|
}
|
|
}
|
|
|
|
func (b *Remote) getRemoteWorkspace(ctx context.Context, localWorkspaceName string) (*tfe.Workspace, error) {
|
|
remoteWorkspaceName := b.getRemoteWorkspaceName(localWorkspaceName)
|
|
|
|
log.Printf("[TRACE] backend/remote: looking up workspace for %s/%s", b.organization, remoteWorkspaceName)
|
|
remoteWorkspace, err := b.client.Workspaces.Read(ctx, b.organization, remoteWorkspaceName)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return remoteWorkspace, nil
|
|
}
|
|
|
|
func (b *Remote) getRemoteWorkspaceID(ctx context.Context, localWorkspaceName string) (string, error) {
|
|
remoteWorkspace, err := b.getRemoteWorkspace(ctx, localWorkspaceName)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return remoteWorkspace.ID, nil
|
|
}
|
|
|
|
func stubAllVariables(vv map[string]backend.UnparsedVariableValue, decls map[string]*configs.Variable) terraform.InputValues {
|
|
ret := make(terraform.InputValues, len(decls))
|
|
|
|
for name, cfg := range decls {
|
|
raw, exists := vv[name]
|
|
if !exists {
|
|
ret[name] = &terraform.InputValue{
|
|
Value: cty.UnknownVal(cfg.Type),
|
|
SourceType: terraform.ValueFromConfig,
|
|
}
|
|
continue
|
|
}
|
|
|
|
val, diags := raw.ParseVariableValue(cfg.ParsingMode)
|
|
if diags.HasErrors() {
|
|
ret[name] = &terraform.InputValue{
|
|
Value: cty.UnknownVal(cfg.Type),
|
|
SourceType: terraform.ValueFromConfig,
|
|
}
|
|
continue
|
|
}
|
|
ret[name] = val
|
|
}
|
|
|
|
return ret
|
|
}
|
|
|
|
// remoteStoredVariableValue is a backend.UnparsedVariableValue implementation
|
|
// that translates from the go-tfe representation of stored variables into
|
|
// the Terraform Core backend representation of variables.
|
|
type remoteStoredVariableValue struct {
|
|
definition *tfe.Variable
|
|
}
|
|
|
|
var _ backend.UnparsedVariableValue = (*remoteStoredVariableValue)(nil)
|
|
|
|
func (v *remoteStoredVariableValue) ParseVariableValue(mode configs.VariableParsingMode) (*terraform.InputValue, tfdiags.Diagnostics) {
|
|
var diags tfdiags.Diagnostics
|
|
var val cty.Value
|
|
|
|
switch {
|
|
case v.definition.Sensitive:
|
|
// If it's marked as sensitive then it's not available for use in
|
|
// local operations. We'll use an unknown value as a placeholder for
|
|
// it so that operations that don't need it might still work, but
|
|
// we'll also produce a warning about it to add context for any
|
|
// errors that might result here.
|
|
val = cty.DynamicVal
|
|
if !v.definition.HCL {
|
|
// If it's not marked as HCL then we at least know that the
|
|
// value must be a string, so we'll set that in case it allows
|
|
// us to do some more precise type checking.
|
|
val = cty.UnknownVal(cty.String)
|
|
}
|
|
|
|
diags = diags.Append(tfdiags.Sourceless(
|
|
tfdiags.Warning,
|
|
fmt.Sprintf("Value for var.%s unavailable", v.definition.Key),
|
|
fmt.Sprintf("The value of variable %q is marked as sensitive in the remote workspace. This operation always runs locally, so the value for that variable is not available.", v.definition.Key),
|
|
))
|
|
|
|
case v.definition.HCL:
|
|
// If the variable value is marked as being in HCL syntax, we need to
|
|
// parse it the same way as it would be interpreted in a .tfvars
|
|
// file because that is how it would get passed to Terraform CLI for
|
|
// a remote operation and we want to mimic that result as closely as
|
|
// possible.
|
|
var exprDiags hcl.Diagnostics
|
|
expr, exprDiags := hclsyntax.ParseExpression([]byte(v.definition.Value), "<remote workspace>", hcl.Pos{Line: 1, Column: 1})
|
|
if expr != nil {
|
|
var moreDiags hcl.Diagnostics
|
|
val, moreDiags = expr.Value(nil)
|
|
exprDiags = append(exprDiags, moreDiags...)
|
|
} else {
|
|
// We'll have already put some errors in exprDiags above, so we'll
|
|
// just stub out the value here.
|
|
val = cty.DynamicVal
|
|
}
|
|
|
|
// We don't have sufficient context to return decent error messages
|
|
// for syntax errors in the remote values, so we'll just return a
|
|
// generic message instead for now.
|
|
// (More complete error messages will still result from true remote
|
|
// operations, because they'll run on the remote system where we've
|
|
// materialized the values into a tfvars file we can report from.)
|
|
if exprDiags.HasErrors() {
|
|
diags = diags.Append(tfdiags.Sourceless(
|
|
tfdiags.Error,
|
|
fmt.Sprintf("Invalid expression for var.%s", v.definition.Key),
|
|
fmt.Sprintf("The value of variable %q is marked in the remote workspace as being specified in HCL syntax, but the given value is not valid HCL. Stored variable values must be valid literal expressions and may not contain references to other variables or calls to functions.", v.definition.Key),
|
|
))
|
|
}
|
|
|
|
default:
|
|
// A variable value _not_ marked as HCL is always be a string, given
|
|
// literally.
|
|
val = cty.StringVal(v.definition.Value)
|
|
}
|
|
|
|
return &terraform.InputValue{
|
|
Value: val,
|
|
|
|
// We mark these as "from input" with the rationale that entering
|
|
// variable values into the Terraform Cloud or Enterprise UI is,
|
|
// roughly speaking, a similar idea to entering variable values at
|
|
// the interactive CLI prompts. It's not a perfect correspondance,
|
|
// but it's closer than the other options.
|
|
SourceType: terraform.ValueFromInput,
|
|
}, diags
|
|
}
|