mirror of
https://github.com/opentofu/opentofu.git
synced 2025-02-20 11:48:24 -06:00
also removed the notion of tags from the redshift security group and parameter group documentation until that has been implemented Redshift Cluster CRUD and acceptance tests Removing the Acceptance test for the Cluster Updates. You cannot delete a cluster immediately after performing an operation on it. We would need to add a lot of retry logic to the system to get this test to work Adding some schema validation for RedShift cluster Adding the last of the pieces of a first draft of the Redshift work - this is the documentation
206 lines
5.4 KiB
Go
206 lines
5.4 KiB
Go
package aws
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/aws/awserr"
|
|
"github.com/aws/aws-sdk-go/service/redshift"
|
|
"github.com/hashicorp/terraform/helper/resource"
|
|
"github.com/hashicorp/terraform/terraform"
|
|
)
|
|
|
|
func TestAccAWSRedshiftSecurityGroup_ingressCidr(t *testing.T) {
|
|
var v redshift.ClusterSecurityGroup
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckAWSRedshiftSecurityGroupDestroy,
|
|
Steps: []resource.TestStep{
|
|
resource.TestStep{
|
|
Config: testAccAWSRedshiftSecurityGroupConfig_ingressCidr,
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckAWSRedshiftSecurityGroupExists("aws_redshift_security_group.bar", &v),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "name", "redshift-sg-terraform"),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "description", "this is a description"),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "ingress.2735652665.cidr", "10.0.0.1/24"),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "ingress.#", "1"),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup(t *testing.T) {
|
|
var v redshift.ClusterSecurityGroup
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckAWSRedshiftSecurityGroupDestroy,
|
|
Steps: []resource.TestStep{
|
|
resource.TestStep{
|
|
Config: testAccAWSRedshiftSecurityGroupConfig_ingressSgId,
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckAWSRedshiftSecurityGroupExists("aws_redshift_security_group.bar", &v),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "name", "redshift-sg-terraform"),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "description", "this is a description"),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "ingress.#", "1"),
|
|
resource.TestCheckResourceAttr(
|
|
"aws_redshift_security_group.bar", "ingress.220863.security_group_name", "terraform_redshift_acceptance_test"),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func testAccCheckAWSRedshiftSecurityGroupExists(n string, v *redshift.ClusterSecurityGroup) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
rs, ok := s.RootModule().Resources[n]
|
|
if !ok {
|
|
return fmt.Errorf("Not found: %s", n)
|
|
}
|
|
|
|
if rs.Primary.ID == "" {
|
|
return fmt.Errorf("No Redshift Security Group ID is set")
|
|
}
|
|
|
|
conn := testAccProvider.Meta().(*AWSClient).redshiftconn
|
|
|
|
opts := redshift.DescribeClusterSecurityGroupsInput{
|
|
ClusterSecurityGroupName: aws.String(rs.Primary.ID),
|
|
}
|
|
|
|
resp, err := conn.DescribeClusterSecurityGroups(&opts)
|
|
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if len(resp.ClusterSecurityGroups) != 1 ||
|
|
*resp.ClusterSecurityGroups[0].ClusterSecurityGroupName != rs.Primary.ID {
|
|
return fmt.Errorf("Redshift Security Group not found")
|
|
}
|
|
|
|
*v = *resp.ClusterSecurityGroups[0]
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccCheckAWSRedshiftSecurityGroupDestroy(s *terraform.State) error {
|
|
conn := testAccProvider.Meta().(*AWSClient).redshiftconn
|
|
|
|
for _, rs := range s.RootModule().Resources {
|
|
if rs.Type != "aws_redshift_security_group" {
|
|
continue
|
|
}
|
|
|
|
// Try to find the Group
|
|
resp, err := conn.DescribeClusterSecurityGroups(
|
|
&redshift.DescribeClusterSecurityGroupsInput{
|
|
ClusterSecurityGroupName: aws.String(rs.Primary.ID),
|
|
})
|
|
|
|
if err == nil {
|
|
if len(resp.ClusterSecurityGroups) != 0 &&
|
|
*resp.ClusterSecurityGroups[0].ClusterSecurityGroupName == rs.Primary.ID {
|
|
return fmt.Errorf("Redshift Security Group still exists")
|
|
}
|
|
}
|
|
|
|
// Verify the error
|
|
newerr, ok := err.(awserr.Error)
|
|
if !ok {
|
|
return err
|
|
}
|
|
if newerr.Code() != "InvalidRedshiftSecurityGroup.NotFound" {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func TestResourceAWSRedshiftSecurityGroupNameValidation(t *testing.T) {
|
|
cases := []struct {
|
|
Value string
|
|
ErrCount int
|
|
}{
|
|
{
|
|
Value: "default",
|
|
ErrCount: 1,
|
|
},
|
|
{
|
|
Value: "testing123%%",
|
|
ErrCount: 1,
|
|
},
|
|
{
|
|
Value: "TestingSG",
|
|
ErrCount: 1,
|
|
},
|
|
{
|
|
Value: randomString(256),
|
|
ErrCount: 1,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
_, errors := validateRedshiftSecurityGroupName(tc.Value, "aws_redshift_security_group_name")
|
|
|
|
if len(errors) != tc.ErrCount {
|
|
t.Fatalf("Expected the Redshift Security Group Name to trigger a validation error")
|
|
}
|
|
}
|
|
}
|
|
|
|
const testAccAWSRedshiftSecurityGroupConfig_ingressCidr = `
|
|
provider "aws" {
|
|
region = "us-east-1"
|
|
}
|
|
|
|
resource "aws_redshift_security_group" "bar" {
|
|
name = "redshift-sg-terraform"
|
|
description = "this is a description"
|
|
|
|
ingress {
|
|
cidr = "10.0.0.1/24"
|
|
}
|
|
}`
|
|
|
|
const testAccAWSRedshiftSecurityGroupConfig_ingressSgId = `
|
|
provider "aws" {
|
|
region = "us-east-1"
|
|
}
|
|
|
|
resource "aws_security_group" "redshift" {
|
|
name = "terraform_redshift_acceptance_test"
|
|
description = "Used in the redshift acceptance tests"
|
|
|
|
ingress {
|
|
protocol = "tcp"
|
|
from_port = 22
|
|
to_port = 22
|
|
cidr_blocks = ["10.0.0.0/8"]
|
|
}
|
|
}
|
|
|
|
resource "aws_redshift_security_group" "bar" {
|
|
name = "redshift-sg-terraform"
|
|
description = "this is a description"
|
|
|
|
ingress {
|
|
security_group_name = "${aws_security_group.redshift.name}"
|
|
security_group_owner_id = "${aws_security_group.redshift.owner_id}"
|
|
}
|
|
}`
|