mirror of
https://github.com/opentofu/opentofu.git
synced 2025-02-20 11:48:24 -06:00
* provider/aws: Deprecate roles in favour of role in iam_instance_profile You can only specify a single role to an IAM Instance Profile. So having a slice of roles in the provider makes no sense. Therefore, we are going to deprecate this infavour of `role` ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIAMInstanceProfile_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/28 21:24:20 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSIAMInstanceProfile_ -timeout 120m === RUN TestAccAWSIAMInstanceProfile_importBasic --- PASS: TestAccAWSIAMInstanceProfile_importBasic (25.08s) === RUN TestAccAWSIAMInstanceProfile_basic --- PASS: TestAccAWSIAMInstanceProfile_basic (22.40s) === RUN TestAccAWSIAMInstanceProfile_withRoleNotRoles --- PASS: TestAccAWSIAMInstanceProfile_withRoleNotRoles (22.63s) === RUN TestAccAWSIAMInstanceProfile_missingRoleThrowsError --- PASS: TestAccAWSIAMInstanceProfile_missingRoleThrowsError (4.02s) === RUN TestAccAWSIAMInstanceProfile_namePrefix --- PASS: TestAccAWSIAMInstanceProfile_namePrefix (22.18s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 96.349s ``` * Update iam_instance_profile.html.markdown
230 lines
6.2 KiB
Go
230 lines
6.2 KiB
Go
package aws
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/aws/awserr"
|
|
"github.com/aws/aws-sdk-go/service/iam"
|
|
"github.com/hashicorp/terraform/helper/acctest"
|
|
"github.com/hashicorp/terraform/helper/resource"
|
|
"github.com/hashicorp/terraform/terraform"
|
|
)
|
|
|
|
func TestAccAWSIAMInstanceProfile_importBasic(t *testing.T) {
|
|
resourceName := "aws_iam_instance_profile.test"
|
|
rName := acctest.RandString(5)
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckAWSInstanceProfileDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccAWSInstanceProfilePrefixNameConfig(rName),
|
|
},
|
|
|
|
{
|
|
ResourceName: resourceName,
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
ImportStateVerifyIgnore: []string{"name_prefix"},
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccAWSIAMInstanceProfile_basic(t *testing.T) {
|
|
var conf iam.GetInstanceProfileOutput
|
|
|
|
rName := acctest.RandString(5)
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccAwsIamInstanceProfileConfig(rName),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckAWSInstanceProfileExists("aws_iam_instance_profile.test", &conf),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccAWSIAMInstanceProfile_withRoleNotRoles(t *testing.T) {
|
|
var conf iam.GetInstanceProfileOutput
|
|
|
|
rName := acctest.RandString(5)
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccAWSInstanceProfileWithRoleSpecified(rName),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckAWSInstanceProfileExists("aws_iam_instance_profile.test", &conf),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccAWSIAMInstanceProfile_missingRoleThrowsError(t *testing.T) {
|
|
rName := acctest.RandString(5)
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccAwsIamInstanceProfileConfigMissingRole(rName),
|
|
ExpectError: regexp.MustCompile("Either `roles` or `role` must be specified when creating an IAM Instance Profile"),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAccAWSIAMInstanceProfile_namePrefix(t *testing.T) {
|
|
var conf iam.GetInstanceProfileOutput
|
|
rName := acctest.RandString(5)
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
IDRefreshName: "aws_iam_instance_profile.test",
|
|
IDRefreshIgnore: []string{"name_prefix"},
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckAWSInstanceProfileDestroy,
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccAWSInstanceProfilePrefixNameConfig(rName),
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckAWSInstanceProfileExists("aws_iam_instance_profile.test", &conf),
|
|
testAccCheckAWSInstanceProfileGeneratedNamePrefix(
|
|
"aws_iam_instance_profile.test", "test-"),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func testAccCheckAWSInstanceProfileGeneratedNamePrefix(resource, prefix string) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
r, ok := s.RootModule().Resources[resource]
|
|
if !ok {
|
|
return fmt.Errorf("Resource not found")
|
|
}
|
|
name, ok := r.Primary.Attributes["name"]
|
|
if !ok {
|
|
return fmt.Errorf("Name attr not found: %#v", r.Primary.Attributes)
|
|
}
|
|
if !strings.HasPrefix(name, prefix) {
|
|
return fmt.Errorf("Name: %q, does not have prefix: %q", name, prefix)
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccCheckAWSInstanceProfileDestroy(s *terraform.State) error {
|
|
iamconn := testAccProvider.Meta().(*AWSClient).iamconn
|
|
|
|
for _, rs := range s.RootModule().Resources {
|
|
if rs.Type != "aws_iam_instance_profile" {
|
|
continue
|
|
}
|
|
|
|
// Try to get role
|
|
_, err := iamconn.GetInstanceProfile(&iam.GetInstanceProfileInput{
|
|
InstanceProfileName: aws.String(rs.Primary.ID),
|
|
})
|
|
if err == nil {
|
|
return fmt.Errorf("still exist.")
|
|
}
|
|
|
|
// Verify the error is what we want
|
|
ec2err, ok := err.(awserr.Error)
|
|
if !ok {
|
|
return err
|
|
}
|
|
if ec2err.Code() != "NoSuchEntity" {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func testAccCheckAWSInstanceProfileExists(n string, res *iam.GetInstanceProfileOutput) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
rs, ok := s.RootModule().Resources[n]
|
|
if !ok {
|
|
return fmt.Errorf("Not found: %s", n)
|
|
}
|
|
|
|
if rs.Primary.ID == "" {
|
|
return fmt.Errorf("No Instance Profile name is set")
|
|
}
|
|
|
|
iamconn := testAccProvider.Meta().(*AWSClient).iamconn
|
|
|
|
resp, err := iamconn.GetInstanceProfile(&iam.GetInstanceProfileInput{
|
|
InstanceProfileName: aws.String(rs.Primary.ID),
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
*res = *resp
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func testAccAwsIamInstanceProfileConfig(rName string) string {
|
|
return fmt.Sprintf(`
|
|
resource "aws_iam_role" "test" {
|
|
name = "test-%s"
|
|
assume_role_policy = "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Allow\",\"Principal\":{\"Service\":[\"ec2.amazonaws.com\"]},\"Action\":[\"sts:AssumeRole\"]}]}"
|
|
}
|
|
|
|
resource "aws_iam_instance_profile" "test" {
|
|
name = "test"
|
|
roles = ["${aws_iam_role.test.name}"]
|
|
}`, rName)
|
|
}
|
|
|
|
func testAccAwsIamInstanceProfileConfigMissingRole(rName string) string {
|
|
return fmt.Sprintf(`
|
|
resource "aws_iam_instance_profile" "test" {
|
|
name = "test-%s"
|
|
}`, rName)
|
|
}
|
|
|
|
func testAccAWSInstanceProfilePrefixNameConfig(rName string) string {
|
|
return fmt.Sprintf(`
|
|
resource "aws_iam_role" "test" {
|
|
name = "test-%s"
|
|
assume_role_policy = "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Allow\",\"Principal\":{\"Service\":[\"ec2.amazonaws.com\"]},\"Action\":[\"sts:AssumeRole\"]}]}"
|
|
}
|
|
|
|
resource "aws_iam_instance_profile" "test" {
|
|
name_prefix = "test-"
|
|
roles = ["${aws_iam_role.test.name}"]
|
|
}`, rName)
|
|
}
|
|
|
|
func testAccAWSInstanceProfileWithRoleSpecified(rName string) string {
|
|
return fmt.Sprintf(`
|
|
resource "aws_iam_role" "test" {
|
|
name = "test-%s"
|
|
assume_role_policy = "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Allow\",\"Principal\":{\"Service\":[\"ec2.amazonaws.com\"]},\"Action\":[\"sts:AssumeRole\"]}]}"
|
|
}
|
|
|
|
resource "aws_iam_instance_profile" "test" {
|
|
name_prefix = "test-"
|
|
role = "${aws_iam_role.test.name}"
|
|
}`, rName)
|
|
}
|