opentofu/command
Martin Atkins c39905e1a8 command: Fix various issues in the "terraform state ..." subcommands
In earlier refactoring we updated these commands to support the new
address and state types, but attempted to partially retain the old-style
"StateFilter" abstraction that originally lived in the Terraform package,
even though that was no longer being used for any other functionality.

Unfortunately the adaptation of the existing filtering to the new types
wasn't exact and so these commands ended up having a few bugs that were
not covered by the existing tests.

Since the old StateFilter behavior was the source of various misbehavior
anyway, here it's removed altogether and replaced with some simpler
functions in the state_meta.go file that are tailored to the use-cases of
these sub-commands.

As well as just generally behaving more consistently with the other
parts of Terraform that use the new resource address types, this commit
fixes the following bugs:

- A resource address of aws_instance.foo would previously match an
  resource of that type and name in any module, which disagreed with the
  expected interpretation elsewhere of meaning a single resource in the
  root module.

- The "terraform state mv" command was not supporting moves from a single
  resource address to an indexed address and vice-versa, because the old
  logic didn't need to make that distinction while they are two separate
  address types in the new logic. Now we allow resources that do not have
  count/for_each to be treated as if they are instances for the purposes
  of this command, which is a better match for likely user intent and for
  the old behavior.

Finally, we also clean up a little some of the usage output from these
commands, which hasn't been updated for some time and so had both some
stale information and some inaccurate terminology.
2019-03-18 09:19:55 -07:00
..
clistate terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
e2etest command/e2etest: Temporarily disable tests that access network 2018-11-19 09:02:35 -08:00
format don't try to treat "null" as json in diff output 2019-03-14 17:20:42 -04:00
jsonconfig command/show: fixing bugs in modulecalls (#20513) 2019-03-01 13:59:12 -08:00
jsonplan command/show: add provider name to resource changes (#20711) 2019-03-15 13:20:43 -07:00
jsonprovider terraform show and terraform providers schema -json should return valid json (#20697) 2019-03-14 14:52:07 -07:00
jsonstate terraform show and terraform providers schema -json should return valid json (#20697) 2019-03-14 14:52:07 -07:00
test-fixtures command/show: add provider name to resource changes (#20711) 2019-03-15 13:20:43 -07:00
testdata Have backend operations properly unlock state 2017-02-15 14:41:55 -05:00
012_config_upgrade.go configs/configupgrade: detect possible relative module sources (#20646) 2019-03-13 11:17:14 -07:00
apply_destroy_test.go command/state: lock when pushing state 2018-11-20 11:15:16 +01:00
apply_test.go command: Apply tests with realistic mock providers 2019-02-11 17:46:55 -08:00
apply.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
autocomplete_test.go command: use newer version of "complete" library 2017-12-05 10:24:04 -08:00
autocomplete.go terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
cli_ui_test.go command/*: colors on error messages (red) 2014-07-12 20:59:16 -07:00
cli_ui.go adding new AskSecret to ColorizeUi 2015-04-29 13:07:13 -05:00
command_test.go command: "terraform init" can partially initialize for 0.12upgrade 2019-01-14 11:33:21 -08:00
command.go Implement the Enterprise enhanced remote backend 2018-08-03 22:22:55 +02:00
console_interactive_solaris.go command: split out and tag code so compilation works on Solaris 2016-11-14 00:32:01 -08:00
console_interactive.go command: update "terraform console" for HCL2 2018-10-16 18:46:46 -07:00
console_test.go Push plugin discovery down into command package 2017-06-09 14:03:59 -07:00
console.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
debug_command.go Add debug command with json2dot 2016-11-21 11:59:20 -05:00
debug_json2dot_test.go cleanup temp files from command tests 2018-03-28 13:08:38 -04:00
debug_json2dot.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
flag_kv_test.go command: use helper/variables for flags and parsing 2016-12-10 14:30:40 -05:00
flag_kv.go terraform: ugly huge change to weave in new HCL2-oriented types 2018-10-16 18:46:46 -07:00
fmt_test.go command: Restore single-file support in "terraform fmt" 2019-01-17 14:21:18 -08:00
fmt.go command: Restore single-file support in "terraform fmt" 2019-01-17 14:21:18 -08:00
get_test.go command: Update "terraform get" to use the new module installer 2019-01-17 16:52:34 -08:00
get.go command: Update "terraform get" to use the new module installer 2019-01-17 16:52:34 -08:00
graph_test.go command: Fix TestGraph_plan 2018-10-16 19:14:11 -07:00
graph.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
hook_module_install.go Move module install functionality over to internal/initwd 2019-01-14 11:33:21 -08:00
hook_ui_test.go command: Fix TestUiHookPostApply_emptyState 2019-01-31 12:25:57 +00:00
hook_ui.go command: go fmt 2018-10-16 19:14:11 -07:00
import_test.go Bump installer protocol version to 5 and separate client and server protocol references 2019-01-16 15:07:57 -06:00
import.go command: Consistency implement and document parallelism default of 10 2019-03-06 09:25:36 -05:00
init_test.go command/test: Clarify failure (add full path) 2019-01-29 22:16:41 +00:00
init.go Change backend.ValidateConfig to PrepareConfig 2019-02-25 18:37:20 -05:00
internal_plugin_list.go v0.11.2 2018-01-09 23:13:33 +00:00
internal_plugin_test.go create a new InternalProviders test 2018-01-05 10:59:30 -05:00
internal_plugin.go create a new InternalProviders test 2018-01-05 10:59:30 -05:00
meta_backend_migrate.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
meta_backend_test.go missing commits from 19688 2018-12-18 16:54:09 -08:00
meta_backend.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
meta_config.go check for errors when loading a backend config 2019-03-12 17:57:26 -04:00
meta_new.go terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
meta_test.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
meta_vars.go command: Specialized error message for var decls in tfvars 2019-02-22 18:04:01 -08:00
meta.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
output_test.go command: Restore the "terraform output" functionality 2018-10-16 19:14:11 -07:00
output.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
plan_test.go command: Specialized error message for var decls in tfvars 2019-02-22 18:04:01 -08:00
plan.go Mildwonkey/012 docs updated (#20542) 2019-03-01 12:30:51 -08:00
plugins_lock_test.go cleanup temp files from command tests 2018-03-28 13:08:38 -04:00
plugins_lock.go Standardize on log level "WARN" rather than "WARNING" 2018-01-16 18:05:26 -08:00
plugins_test.go command: Update plugins_test.go for new provider types 2018-10-16 19:14:11 -07:00
plugins.go update provisioners for multiple processes 2018-10-16 19:14:11 -07:00
providers_schema_test.go terraform show and terraform providers schema -json should return valid json (#20697) 2019-03-14 14:52:07 -07:00
providers_schema.go remove indentation from json output of show and providers schema (#20623) 2019-03-11 07:29:36 -07:00
providers_test.go command: Fix tests for "terraform providers" 2018-10-16 19:14:11 -07:00
providers.go command: allow -no-color option on "providers" command 2018-12-17 10:55:16 -08:00
push.go command: remove "terraform push" 2018-10-16 18:24:47 -07:00
refresh_test.go command/state: lock when pushing state 2018-11-20 11:15:16 +01:00
refresh.go command: Consistency implement and document parallelism default of 10 2019-03-06 09:25:36 -05:00
show_test.go terraform show and terraform providers schema -json should return valid json (#20697) 2019-03-14 14:52:07 -07:00
show.go terraform show and terraform providers schema -json should return valid json (#20697) 2019-03-14 14:52:07 -07:00
state_command.go Thread the environment through all commands 2017-02-28 16:35:46 -05:00
state_list_test.go command/state: update and fix the state list command 2018-10-19 16:31:12 +02:00
state_list.go command: Fix various issues in the "terraform state ..." subcommands 2019-03-18 09:19:55 -07:00
state_meta.go command: Fix various issues in the "terraform state ..." subcommands 2019-03-18 09:19:55 -07:00
state_mv_test.go command: Fix various issues in the "terraform state ..." subcommands 2019-03-18 09:19:55 -07:00
state_mv.go command: Fix various issues in the "terraform state ..." subcommands 2019-03-18 09:19:55 -07:00
state_pull_test.go command: Use statemgr.Import and statemgr.Export for state push and pull 2018-11-19 09:02:35 -08:00
state_pull.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
state_push_test.go command/state: lock when pushing state 2018-11-20 11:15:16 +01:00
state_push.go command/state: add proper locking 2019-01-08 14:57:52 +01:00
state_rm_test.go command: Fix various issues in the "terraform state ..." subcommands 2019-03-18 09:19:55 -07:00
state_rm.go command: Fix various issues in the "terraform state ..." subcommands 2019-03-18 09:19:55 -07:00
state_show_test.go command/format: include nested blocks in terraform show output (#20149) 2019-01-30 10:08:59 -08:00
state_show.go command/show and state show: honor user-specified plugin-dir (#20557) 2019-03-05 08:32:11 -08:00
state_test.go command: Allow tests to run to completion without panics or hangs 2018-10-16 19:14:11 -07:00
taint_test.go command/state: lock when pushing state 2018-11-20 11:15:16 +01:00
taint.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
ui_input_test.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
ui_input.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
unlock_test.go check for errors when loading a backend config 2019-03-12 17:57:26 -04:00
unlock.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
untaint_test.go command/state: lock when pushing state 2018-11-20 11:15:16 +01:00
untaint.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
validate_test.go Fix tests after upgrading hcl 2018-11-26 23:38:37 +00:00
validate.go command: Remove promise of plan -validate-only from validate docs 2019-02-25 14:27:59 -08:00
version_test.go Implement CLI, version command 2014-05-24 12:04:43 -07:00
version.go command: Include provider versions in "terraform version" 2017-10-25 17:36:24 -07:00
workspace_command_test.go command: Fix TestWorkspace_createWithState 2018-11-08 08:57:11 -08:00
workspace_command.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
workspace_delete.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
workspace_list.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
workspace_new.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
workspace_select.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00
workspace_show.go commands: make sure the correct flagset is used 2018-11-23 16:13:34 +01:00