mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-26 00:41:27 -06:00
c4d46e7c6b
Earlier versions of this code allowed "ref" to take any value that would be accepted by "git checkout" as a valid target of a symbolic ref. We inadvertently accepted a breaking change to upstream go-getter that broke that as part of introducing a shallow clone optimization, because shallow clone requires selecting a single branch. To restore the previous capabilities while retaining the "depth" argument, here we accept a compromise where "ref" has the stronger requirement of being a valid named ref in the remote repository if and only if "depth" is set to a value greater than zero. If depth isn't set or is less than one, we will do the old behavior of just cloning all of the refs in the remote repository in full and then switching to refer to the selected branch, tag, or naked commit ID as a separate step. This includes a heuristic to generate an additional error message hint if we get an error from "git clone" and it looks like the user might've been trying to use "depth" and "ref=COMMIT" together. We can't recognize that error accurately because it's only reported as human-oriented git command output, but this heuristic should hopefully minimize situations where we show it inappropriately. For now this is a change in the Terraform repository directly, so that we can expedite the fix to an already-reported regression. After this is released I tend to also submit a similar set of changes to upstream go-getter, at which point we can revert Terraform to using the upstream getter.GitGetter instead of our own local fork.
417 lines
12 KiB
Go
417 lines
12 KiB
Go
package getmodules
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/base64"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/url"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
"syscall"
|
|
|
|
getter "github.com/hashicorp/go-getter"
|
|
urlhelper "github.com/hashicorp/go-getter/helper/url"
|
|
safetemp "github.com/hashicorp/go-safetemp"
|
|
version "github.com/hashicorp/go-version"
|
|
)
|
|
|
|
// getter is our base getter; it regroups
|
|
// fields all getters have in common.
|
|
type getterCommon struct {
|
|
client *getter.Client
|
|
}
|
|
|
|
func (g *getterCommon) SetClient(c *getter.Client) { g.client = c }
|
|
|
|
// Context tries to returns the Contex from the getter's
|
|
// client. otherwise context.Background() is returned.
|
|
func (g *getterCommon) Context() context.Context {
|
|
if g == nil || g.client == nil {
|
|
return context.Background()
|
|
}
|
|
return g.client.Ctx
|
|
}
|
|
|
|
// gitGetter is a temporary fork of getter.GitGetter to allow us to tactically
|
|
// fix https://github.com/hashicorp/terraform/issues/30119 only within
|
|
// Terraform.
|
|
//
|
|
// This should be only a brief workaround to help us decouple work on the
|
|
// Terraform CLI v1.1.1 release so that we can get it done without having to
|
|
// coordinate with every other go-getter caller first. However, this fork
|
|
// should be healed promptly after v1.1.1 by upstreaming something like this
|
|
// fix into upstream go-getter, so that other go-getter callers can also
|
|
// benefit from it.
|
|
type gitGetter struct {
|
|
getterCommon
|
|
}
|
|
|
|
var defaultBranchRegexp = regexp.MustCompile(`\s->\sorigin/(.*)`)
|
|
var lsRemoteSymRefRegexp = regexp.MustCompile(`ref: refs/heads/([^\s]+).*`)
|
|
|
|
func (g *gitGetter) ClientMode(_ *url.URL) (getter.ClientMode, error) {
|
|
return getter.ClientModeDir, nil
|
|
}
|
|
|
|
func (g *gitGetter) Get(dst string, u *url.URL) error {
|
|
ctx := g.Context()
|
|
if _, err := exec.LookPath("git"); err != nil {
|
|
return fmt.Errorf("git must be available and on the PATH")
|
|
}
|
|
|
|
// The port number must be parseable as an integer. If not, the user
|
|
// was probably trying to use a scp-style address, in which case the
|
|
// ssh:// prefix must be removed to indicate that.
|
|
//
|
|
// This is not necessary in versions of Go which have patched
|
|
// CVE-2019-14809 (e.g. Go 1.12.8+)
|
|
if portStr := u.Port(); portStr != "" {
|
|
if _, err := strconv.ParseUint(portStr, 10, 16); err != nil {
|
|
return fmt.Errorf("invalid port number %q; if using the \"scp-like\" git address scheme where a colon introduces the path instead, remove the ssh:// portion and use just the git:: prefix", portStr)
|
|
}
|
|
}
|
|
|
|
// Extract some query parameters we use
|
|
var ref, sshKey string
|
|
depth := 0 // 0 means "not set"
|
|
q := u.Query()
|
|
if len(q) > 0 {
|
|
ref = q.Get("ref")
|
|
q.Del("ref")
|
|
|
|
sshKey = q.Get("sshkey")
|
|
q.Del("sshkey")
|
|
|
|
if n, err := strconv.Atoi(q.Get("depth")); err == nil {
|
|
depth = n
|
|
}
|
|
q.Del("depth")
|
|
|
|
// Copy the URL
|
|
var newU url.URL = *u
|
|
u = &newU
|
|
u.RawQuery = q.Encode()
|
|
}
|
|
|
|
var sshKeyFile string
|
|
if sshKey != "" {
|
|
// Check that the git version is sufficiently new.
|
|
if err := checkGitVersion("2.3"); err != nil {
|
|
return fmt.Errorf("Error using ssh key: %v", err)
|
|
}
|
|
|
|
// We have an SSH key - decode it.
|
|
raw, err := base64.StdEncoding.DecodeString(sshKey)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Create a temp file for the key and ensure it is removed.
|
|
fh, err := ioutil.TempFile("", "go-getter")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
sshKeyFile = fh.Name()
|
|
defer os.Remove(sshKeyFile)
|
|
|
|
// Set the permissions prior to writing the key material.
|
|
if err := os.Chmod(sshKeyFile, 0600); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Write the raw key into the temp file.
|
|
_, err = fh.Write(raw)
|
|
fh.Close()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// Clone or update the repository
|
|
_, err := os.Stat(dst)
|
|
if err != nil && !os.IsNotExist(err) {
|
|
return err
|
|
}
|
|
if err == nil {
|
|
err = g.update(ctx, dst, sshKeyFile, ref, depth)
|
|
} else {
|
|
err = g.clone(ctx, dst, sshKeyFile, u, ref, depth)
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Next: check out the proper tag/branch if it is specified, and checkout
|
|
if ref != "" {
|
|
if err := g.checkout(dst, ref); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// Lastly, download any/all submodules.
|
|
return g.fetchSubmodules(ctx, dst, sshKeyFile, depth)
|
|
}
|
|
|
|
// GetFile for Git doesn't support updating at this time. It will download
|
|
// the file every time.
|
|
func (g *gitGetter) GetFile(dst string, u *url.URL) error {
|
|
td, tdcloser, err := safetemp.Dir("", "getter")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer tdcloser.Close()
|
|
|
|
// Get the filename, and strip the filename from the URL so we can
|
|
// just get the repository directly.
|
|
filename := filepath.Base(u.Path)
|
|
u.Path = filepath.Dir(u.Path)
|
|
|
|
// Get the full repository
|
|
if err := g.Get(td, u); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Copy the single file
|
|
u, err = urlhelper.Parse(fmtFileURL(filepath.Join(td, filename)))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
fg := &getter.FileGetter{Copy: true}
|
|
return fg.GetFile(dst, u)
|
|
}
|
|
|
|
func (g *gitGetter) checkout(dst string, ref string) error {
|
|
cmd := exec.Command("git", "checkout", ref)
|
|
cmd.Dir = dst
|
|
return getRunCommand(cmd)
|
|
}
|
|
|
|
// gitCommitIDRegex is a pattern intended to match strings that seem
|
|
// "likely to be" git commit IDs, rather than named refs. This cannot be
|
|
// an exact decision because it's valid to name a branch or tag after a series
|
|
// of hexadecimal digits too.
|
|
//
|
|
// We require at least 7 digits here because that's the smallest size git
|
|
// itself will typically generate, and so it'll reduce the risk of false
|
|
// positives on short branch names that happen to also be "hex words".
|
|
var gitCommitIDRegex = regexp.MustCompile("^[0-9a-fA-F]{7,40}$")
|
|
|
|
func (g *gitGetter) clone(ctx context.Context, dst, sshKeyFile string, u *url.URL, ref string, depth int) error {
|
|
args := []string{"clone"}
|
|
|
|
autoBranch := false
|
|
if ref == "" {
|
|
ref = findRemoteDefaultBranch(u)
|
|
autoBranch = true
|
|
}
|
|
if depth > 0 {
|
|
args = append(args, "--depth", strconv.Itoa(depth))
|
|
args = append(args, "--branch", ref)
|
|
}
|
|
args = append(args, u.String(), dst)
|
|
|
|
cmd := exec.CommandContext(ctx, "git", args...)
|
|
setupGitEnv(cmd, sshKeyFile)
|
|
err := getRunCommand(cmd)
|
|
if err != nil {
|
|
if depth > 0 && !autoBranch {
|
|
// If we're creating a shallow clone then the given ref must be
|
|
// a named ref (branch or tag) rather than a commit directly.
|
|
// We can't accurately recognize the resulting error here without
|
|
// hard-coding assumptions about git's human-readable output, but
|
|
// we can at least try a heuristic.
|
|
if gitCommitIDRegex.MatchString(ref) {
|
|
return fmt.Errorf("%w (note that setting 'depth' requires 'ref' to be a branch or tag name)", err)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
if depth < 1 && !autoBranch {
|
|
// If we didn't add --depth and --branch above then we will now be
|
|
// on the remote repository's default branch, rather than the selected
|
|
// ref, so we'll need to fix that before we return.
|
|
return g.checkout(dst, ref)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (g *gitGetter) update(ctx context.Context, dst, sshKeyFile, ref string, depth int) error {
|
|
// Determine if we're a branch. If we're NOT a branch, then we just
|
|
// switch to master prior to checking out
|
|
cmd := exec.CommandContext(ctx, "git", "show-ref", "-q", "--verify", "refs/heads/"+ref)
|
|
cmd.Dir = dst
|
|
|
|
if getRunCommand(cmd) != nil {
|
|
// Not a branch, switch to default branch. This will also catch
|
|
// non-existent branches, in which case we want to switch to default
|
|
// and then checkout the proper branch later.
|
|
ref = findDefaultBranch(dst)
|
|
}
|
|
|
|
// We have to be on a branch to pull
|
|
if err := g.checkout(dst, ref); err != nil {
|
|
return err
|
|
}
|
|
|
|
if depth > 0 {
|
|
cmd = exec.Command("git", "pull", "--depth", strconv.Itoa(depth), "--ff-only")
|
|
} else {
|
|
cmd = exec.Command("git", "pull", "--ff-only")
|
|
}
|
|
|
|
cmd.Dir = dst
|
|
setupGitEnv(cmd, sshKeyFile)
|
|
return getRunCommand(cmd)
|
|
}
|
|
|
|
// fetchSubmodules downloads any configured submodules recursively.
|
|
func (g *gitGetter) fetchSubmodules(ctx context.Context, dst, sshKeyFile string, depth int) error {
|
|
args := []string{"submodule", "update", "--init", "--recursive"}
|
|
if depth > 0 {
|
|
args = append(args, "--depth", strconv.Itoa(depth))
|
|
}
|
|
cmd := exec.CommandContext(ctx, "git", args...)
|
|
cmd.Dir = dst
|
|
setupGitEnv(cmd, sshKeyFile)
|
|
return getRunCommand(cmd)
|
|
}
|
|
|
|
// findDefaultBranch checks the repo's origin remote for its default branch
|
|
// (generally "master"). "master" is returned if an origin default branch
|
|
// can't be determined.
|
|
func findDefaultBranch(dst string) string {
|
|
var stdoutbuf bytes.Buffer
|
|
cmd := exec.Command("git", "branch", "-r", "--points-at", "refs/remotes/origin/HEAD")
|
|
cmd.Dir = dst
|
|
cmd.Stdout = &stdoutbuf
|
|
err := cmd.Run()
|
|
matches := defaultBranchRegexp.FindStringSubmatch(stdoutbuf.String())
|
|
if err != nil || matches == nil {
|
|
return "master"
|
|
}
|
|
return matches[len(matches)-1]
|
|
}
|
|
|
|
// findRemoteDefaultBranch checks the remote repo's HEAD symref to return the remote repo's
|
|
// default branch. "master" is returned if no HEAD symref exists.
|
|
func findRemoteDefaultBranch(u *url.URL) string {
|
|
var stdoutbuf bytes.Buffer
|
|
cmd := exec.Command("git", "ls-remote", "--symref", u.String(), "HEAD")
|
|
cmd.Stdout = &stdoutbuf
|
|
err := cmd.Run()
|
|
matches := lsRemoteSymRefRegexp.FindStringSubmatch(stdoutbuf.String())
|
|
if err != nil || matches == nil {
|
|
return "master"
|
|
}
|
|
return matches[len(matches)-1]
|
|
}
|
|
|
|
// setupGitEnv sets up the environment for the given command. This is used to
|
|
// pass configuration data to git and ssh and enables advanced cloning methods.
|
|
func setupGitEnv(cmd *exec.Cmd, sshKeyFile string) {
|
|
const gitSSHCommand = "GIT_SSH_COMMAND="
|
|
var sshCmd []string
|
|
|
|
// If we have an existing GIT_SSH_COMMAND, we need to append our options.
|
|
// We will also remove our old entry to make sure the behavior is the same
|
|
// with versions of Go < 1.9.
|
|
env := os.Environ()
|
|
for i, v := range env {
|
|
if strings.HasPrefix(v, gitSSHCommand) && len(v) > len(gitSSHCommand) {
|
|
sshCmd = []string{v}
|
|
|
|
env[i], env[len(env)-1] = env[len(env)-1], env[i]
|
|
env = env[:len(env)-1]
|
|
break
|
|
}
|
|
}
|
|
|
|
if len(sshCmd) == 0 {
|
|
sshCmd = []string{gitSSHCommand + "ssh"}
|
|
}
|
|
|
|
if sshKeyFile != "" {
|
|
// We have an SSH key temp file configured, tell ssh about this.
|
|
if runtime.GOOS == "windows" {
|
|
sshKeyFile = strings.Replace(sshKeyFile, `\`, `/`, -1)
|
|
}
|
|
sshCmd = append(sshCmd, "-i", sshKeyFile)
|
|
}
|
|
|
|
env = append(env, strings.Join(sshCmd, " "))
|
|
cmd.Env = env
|
|
}
|
|
|
|
// checkGitVersion is used to check the version of git installed on the system
|
|
// against a known minimum version. Returns an error if the installed version
|
|
// is older than the given minimum.
|
|
func checkGitVersion(min string) error {
|
|
want, err := version.NewVersion(min)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
out, err := exec.Command("git", "version").Output()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
fields := strings.Fields(string(out))
|
|
if len(fields) < 3 {
|
|
return fmt.Errorf("Unexpected 'git version' output: %q", string(out))
|
|
}
|
|
v := fields[2]
|
|
if runtime.GOOS == "windows" && strings.Contains(v, ".windows.") {
|
|
// on windows, git version will return for example:
|
|
// git version 2.20.1.windows.1
|
|
// Which does not follow the semantic versionning specs
|
|
// https://semver.org. We remove that part in order for
|
|
// go-version to not error.
|
|
v = v[:strings.Index(v, ".windows.")]
|
|
}
|
|
|
|
have, err := version.NewVersion(v)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if have.LessThan(want) {
|
|
return fmt.Errorf("Required git version = %s, have %s", want, have)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// getRunCommand is a helper that will run a command and capture the output
|
|
// in the case an error happens.
|
|
func getRunCommand(cmd *exec.Cmd) error {
|
|
var buf bytes.Buffer
|
|
cmd.Stdout = &buf
|
|
cmd.Stderr = &buf
|
|
err := cmd.Run()
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
if exiterr, ok := err.(*exec.ExitError); ok {
|
|
// The program has exited with an exit code != 0
|
|
if status, ok := exiterr.Sys().(syscall.WaitStatus); ok {
|
|
return fmt.Errorf(
|
|
"%s exited with %d: %s",
|
|
cmd.Path,
|
|
status.ExitStatus(),
|
|
buf.String())
|
|
}
|
|
}
|
|
|
|
return fmt.Errorf("error running %s: %s", cmd.Path, buf.String())
|
|
}
|