opentofu/terraform
James Bardin c99157c35b new targets transformer
This simplifies the initial targeting logic, and removes the complex
algorithm for finding descendants that result in output changes, which
hid bugs that failed with modules.

The targeting is handled in 2 phases. First we find all individual
resource nodes that are targeted, then add all their dependencies to the
set of targets. This in essence is all we need for targeting, and is
straightforward to understand.

The next phase is to add any root module outputs that can be solely
derived from the set of targeted resources. There is currently no way to
target outputs themselves, so this is how we can allow these to be
updated as part of a target.

Rather than attempting to backtrack through the graph to find candidate
outputs, requiring each node on the chain to properly advertise if it
could be traversed, then backtracking again to determine if the
candidate is valid (which often got "off course"), we can start directly
from the outputs themselves. The algorithm here is simpler: if all the
root output's resource dependencies are targeted, add that output and
its dependencies to the targeted set.
2020-06-24 10:27:52 -04:00
..
testdata ensure modules are expanded during import 2020-06-10 17:02:41 -04:00
context_apply_test.go improve depends_on test to check ordering 2020-06-04 18:03:03 -04:00
context_components_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
context_components.go terraform: Remove some addrs.Provider.LegacyString uses 2020-04-06 09:24:23 -07:00
context_fixtures_test.go Mildwonkey/terraform tests (targeting integration branch) (#24513) 2020-04-06 09:24:23 -07:00
context_graph_type.go Version tools per Go convention under tools.go 2019-10-17 22:23:39 +02:00
context_import_test.go ensure modules are expanded during import 2020-06-10 17:02:41 -04:00
context_import.go Mildwonkey/ps import (#24412) 2020-03-20 08:15:29 -04:00
context_input_test.go Mildwonkey/terraform tests (targeting integration branch) (#24513) 2020-04-06 09:24:23 -07:00
context_input.go convert /terraform to use new provider config 2020-03-11 11:21:45 -04:00
context_plan_test.go hide empty plans for misbehaving data resource 2020-06-18 19:21:19 -04:00
context_refresh_test.go cleanup refresh test 2020-05-13 13:58:11 -04:00
context_test.go check for data source changed during plan 2020-05-13 13:58:11 -04:00
context_validate_test.go module and output depends_on validation tests 2020-06-16 13:17:21 -04:00
context.go terraform: return initialization required error when provider schemas not found (#24715) 2020-04-21 16:29:27 -04:00
diff_test.go re-count the flatmapped containers 2018-11-16 15:26:16 -05:00
diff.go prevent panics when encountering nil diffs 2019-09-04 16:51:42 -04:00
eval_apply.go plans: Update error message for apply validation (#21312) 2020-06-05 15:08:10 -04:00
eval_check_prevent_destroy.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_context_builtin_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
eval_context_builtin.go lock was missing in the call to GetVariableValue 2020-04-08 09:59:27 -04:00
eval_context_mock.go Mildwonkey/terraform tests (targeting integration branch) (#24513) 2020-04-06 09:24:23 -07:00
eval_context.go add EvalContext.WithPath 2020-03-25 17:03:06 -04:00
eval_count_boundary.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
eval_count.go fixup mangled comments 2020-04-09 10:13:03 -04:00
eval_diff_test.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_diff.go rename and cleanup use of count/for_each eval func 2020-04-08 17:21:23 -04:00
eval_error.go core: [refactor] store Deposed resource instances as a list 2015-03-04 12:25:59 -06:00
eval_filter_operation.go terraform: clean up EvalNodes 2015-02-19 12:08:32 -08:00
eval_filter.go terraform: more eval stuff 2015-02-19 12:07:54 -08:00
eval_for_each_test.go rename and cleanup use of count/for_each eval func 2020-04-08 17:21:23 -04:00
eval_for_each.go Update terraform/eval_for_each.go 2020-04-09 11:47:16 -04:00
eval_if.go core: [refactor] pull Deposed out of Tainted list 2015-03-04 12:25:47 -06:00
eval_import_state.go terraform: More wiring in of new provider types 2018-10-16 19:12:54 -07:00
eval_lang.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_local_test.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_local.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_noop.go terraform: clean up EvalNodes 2015-02-19 12:08:32 -08:00
eval_output_test.go validate depends_on for outputs 2020-06-16 12:40:48 -04:00
eval_output.go validate depends_on for outputs 2020-06-16 12:40:48 -04:00
eval_provider_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
eval_provider.go terraform: remove no-longer-necessary type strings 2020-02-14 15:41:31 -08:00
eval_provisioner_test.go replace provider and provisioner types in tests 2018-10-16 19:11:09 -07:00
eval_provisioner.go ResourceProvisioner to provisioners.Interface 2018-10-16 19:11:09 -07:00
eval_read_data_apply.go Don't use plans.Update for data sources 2020-05-13 13:58:11 -04:00
eval_read_data_plan.go hide empty plans for misbehaving data resource 2020-06-18 19:21:19 -04:00
eval_read_data.go add a way to force depends_on behavior of data 2020-06-04 18:03:32 -04:00
eval_refresh.go Make sure CBD is correct during apply, and saved 2020-05-14 15:46:08 -04:00
eval_sequence_test.go terraform: Refresh, Read/Write state 2015-02-19 12:08:00 -08:00
eval_sequence.go core: EvalSequence to handle EvalEarlyExitError 2018-10-16 18:49:20 -07:00
eval_state_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
eval_state_upgrade.go terraform: large refactor to use Provider from configs.Resource (#24396) 2020-03-18 08:58:20 -04:00
eval_state.go Make sure CBD is correct during apply, and saved 2020-05-14 15:46:08 -04:00
eval_test.go terraform: clean up EvalNodes 2015-02-19 12:08:32 -08:00
eval_validate_selfref_test.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_validate_selfref.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_validate_test.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
eval_validate.go split depends_on validation into its own function 2020-06-16 12:38:05 -04:00
eval_variable.go eval variables with unknown expansion data 2020-04-08 15:37:38 -04:00
eval.go don't log path in EvalRaw 2020-03-25 17:03:06 -04:00
evaltree_provider.go terraform: remove no-longer-necessary type strings 2020-02-14 15:41:31 -08:00
evaluate_test.go core: path.module, path.root, path.cwd use fwd slashes on all platforms 2018-12-19 13:47:42 -08:00
evaluate_valid_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
evaluate_valid.go Mildwonkey/terraform tests (targeting integration branch) (#24513) 2020-04-06 09:24:23 -07:00
evaluate.go 2 more tests that weren't correct 2020-04-30 09:22:14 -04:00
features.go output warning flag 2017-11-28 14:18:54 -05:00
graph_builder_apply_test.go update test strings 2020-05-12 11:07:00 -04:00
graph_builder_apply.go add CountBoundaryTransformer after targeting 2020-06-23 17:22:44 -04:00
graph_builder_destroy_plan.go make the root node a nodeCloseModule for root 2020-04-02 16:00:36 -04:00
graph_builder_eval.go Add expansion transformer to eval graph 2020-04-27 13:09:08 -04:00
graph_builder_import.go ensure modules are expanded during import 2020-06-10 17:02:41 -04:00
graph_builder_plan_test.go update test strings 2020-05-12 11:07:00 -04:00
graph_builder_plan.go add CountBoundaryTransformer after targeting 2020-06-23 17:22:44 -04:00
graph_builder_refresh_test.go update test strings 2020-05-12 11:07:00 -04:00
graph_builder_refresh.go add dependsOn to evalDataRead 2020-06-04 18:03:03 -04:00
graph_builder_test.go core: Get tests compiling again 2018-10-16 18:46:46 -07:00
graph_builder_validate.go add module expansion to validation 2020-04-05 12:13:48 -04:00
graph_builder.go update terraform to work with new dag changes 2020-02-19 14:53:19 -05:00
graph_dot_test.go terraform: remove ConnectDependents and related interfaces 2017-02-03 14:25:54 +01:00
graph_dot.go Remove dot package 2016-11-14 08:50:34 -05:00
graph_interface_subgraph.go rename GraphNodeSubPath -> GraphNodeModuleInstance 2020-03-10 17:25:11 -04:00
graph_test.go update some graph builder tests 2018-10-16 19:14:11 -07:00
graph_walk_context.go add EvalContext.WithPath 2020-03-25 17:03:06 -04:00
graph_walk_operation.go Version tools per Go convention under tools.go 2019-10-17 22:23:39 +02:00
graph_walk_test.go terraform: trying this graphwalker thing 2015-02-19 12:07:56 -08:00
graph_walk.go add EvalContext.WithPath 2020-03-25 17:03:06 -04:00
graph.go add EvalContext.WithPath 2020-03-25 17:03:06 -04:00
graphtype_string.go stringer: Regenerate files with latest version 2019-05-13 15:34:27 +01:00
hook_mock.go terraform: More wiring in of new provider types 2018-10-16 19:12:54 -07:00
hook_stop_test.go terraform: stopHook and tests 2014-07-02 16:16:38 -07:00
hook_stop.go command: Fix TestPlan_shutdown 2018-11-08 08:57:11 -08:00
hook_test.go add locks to testHook 2020-04-08 10:02:43 -04:00
hook.go terraform: More wiring in of new provider types 2018-10-16 19:12:54 -07:00
instance_expanders.go remove requiresInstanceExpansion 2020-05-28 21:30:44 -04:00
instancetype_string.go stringer: Regenerate files with latest version 2019-05-13 15:34:27 +01:00
instancetype.go Version tools per Go convention under tools.go 2019-10-17 22:23:39 +02:00
node_count_boundary.go core: Update EvalCountFixZeroOneBoundaryGlobal for new state types 2018-10-16 19:14:11 -07:00
node_data_destroy.go rename NodeDestroyableDataResourceInstance 2018-12-18 13:22:21 -05:00
node_data_refresh_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
node_data_refresh.go Targets was being dropped in data source nodes 2020-06-10 15:36:44 -04:00
node_local.go remove extra whitespace 2020-05-29 10:31:10 -04:00
node_module_expand.go validate depends_on in module calls 2020-06-16 12:39:50 -04:00
node_module_variable_test.go rename module variables and remove extra methods 2020-04-08 14:41:52 -04:00
node_module_variable.go module variables can't be referenced as a module 2020-06-15 20:46:03 -04:00
node_output.go make outptut destroy nodes a temporaryValue 2020-06-24 10:22:10 -04:00
node_provider_abstract.go minor cleanup 2020-03-12 14:54:47 -04:00
node_provider_disabled.go minor cleanup 2020-03-12 14:54:47 -04:00
node_provider_eval.go terraform: remove no-longer-necessary type strings 2020-02-14 15:41:31 -08:00
node_provider.go WIP reference providers by full name 2017-11-02 15:00:06 -04:00
node_provisioner.go rename GraphNodeSubPath -> GraphNodeModuleInstance 2020-03-10 17:25:11 -04:00
node_resource_abstract.go add a way to force depends_on behavior of data 2020-06-04 18:03:32 -04:00
node_resource_apply_instance.go remove requiresInstanceExpansion 2020-05-28 21:30:44 -04:00
node_resource_apply.go ignore module indices in pre-expansion targeting 2020-06-10 15:39:29 -04:00
node_resource_destroy_deposed.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
node_resource_destroy.go add evalWriteEmptyState for data source removal 2020-05-13 13:58:11 -04:00
node_resource_plan_destroy.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
node_resource_plan_instance.go add dependsOn to evalDataRead 2020-06-04 18:03:03 -04:00
node_resource_plan_orphan.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
node_resource_plan.go ignore module indices in pre-expansion targeting 2020-06-10 15:39:29 -04:00
node_resource_refresh_test.go cleanup some expanders 2020-03-25 17:03:06 -04:00
node_resource_refresh.go remove "prepare state" from expanders 2020-05-12 10:28:33 -04:00
node_resource_validate.go Add Path to more nodes that require it. 2020-03-25 17:03:06 -04:00
node_root_variable.go eval variables with unknown expansion data 2020-04-08 15:37:38 -04:00
node_value.go prune unused values based on behavior 2020-04-02 16:00:36 -04:00
plan.go terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
provider_mock.go Add support for provider metadata to modules. (#22583) 2020-03-05 16:53:24 -08:00
provisioner_mock.go check resource-level connections block for refs 2019-12-12 12:57:23 -05:00
resource_address_test.go prune references to config/module 2019-08-07 17:50:59 -04:00
resource_address.go prune references to config/module 2019-08-07 17:50:59 -04:00
resource_mode_string.go prune references to config/module 2019-08-07 17:50:59 -04:00
resource_mode.go Version tools per Go convention under tools.go 2019-10-17 22:23:39 +02:00
resource_provider_mock_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
resource_provider_mock.go minor race issue in mockResourceProvider 2017-12-20 09:18:38 -05:00
resource_provider.go terraform: return initialization required error when provider schemas not found (#24715) 2020-04-21 16:29:27 -04:00
resource_provisioner_mock_test.go replace provider and provisioner types in tests 2018-10-16 19:11:09 -07:00
resource_provisioner_mock.go move "configschema" from "config" to "configs" 2018-10-16 18:50:29 -07:00
resource_provisioner.go provisioners: Add Factory type and FactoryFixed helper 2018-10-16 19:14:11 -07:00
resource_test.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
resource.go move hcl2shim package to configs 2019-08-06 19:58:58 -04:00
schemas_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
schemas.go terraform: Remove some addrs.Provider.LegacyString uses 2020-04-06 09:24:23 -07:00
state_filter.go restore (via copypaste) terraform.State.Remove 2019-01-03 22:06:30 -05:00
state_test.go prune references to config/module 2019-08-07 17:50:59 -04:00
state_upgrade_v1_to_v2.go terraform: convert empty path to root path in V1 state 2017-03-21 11:37:12 -07:00
state_upgrade_v2_to_v3.go terraform: V1 to V2 upgrade should treat nil path as root path 2017-03-21 11:12:44 -07:00
state_v1.go core: Introduce state v3 and upgrade process 2016-06-09 10:49:49 +01:00
state.go Add support for provider metadata to modules. (#22583) 2020-03-05 16:53:24 -08:00
terraform_test.go fix apply tests 2020-05-28 21:30:44 -04:00
testing.go terraform: support backends in the state 2017-01-26 14:33:49 -08:00
transform_attach_config_provider_meta.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
transform_attach_config_provider.go minor cleanup 2020-03-12 14:54:47 -04:00
transform_attach_config_resource.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
transform_attach_schema.go terraform: large refactor to use Provider from configs.Resource (#24396) 2020-03-18 08:58:20 -04:00
transform_attach_state.go attach a deep copy of ResourceState 2018-12-17 18:08:53 -05:00
transform_config_test.go NewNodeAbstractResource accepts a ResourceConfig 2020-03-25 17:03:06 -04:00
transform_config.go NewNodeAbstractResource accepts a ResourceConfig 2020-03-25 17:03:06 -04:00
transform_count_boundary.go core: Update EvalCountFixZeroOneBoundaryGlobal for new state types 2018-10-16 19:14:11 -07:00
transform_destroy_cbd_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_destroy_cbd.go update terraform to work with new dag changes 2020-02-19 14:53:19 -05:00
transform_destroy_edge_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_destroy_edge.go remove unused closer field 2020-05-29 10:29:27 -04:00
transform_diff_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_diff.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
transform_expand.go GraphNodeExpand is not used 2020-03-10 17:25:11 -04:00
transform_import_provider.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
transform_import_state.go Mildwonkey/ps import (#24412) 2020-03-20 08:15:29 -04:00
transform_local.go rename plannable local 2020-05-12 11:07:00 -04:00
transform_module_expansion.go incorrect early return during module transformer 2020-06-06 21:45:05 -04:00
transform_module_variable_test.go update test strings 2020-05-12 11:07:00 -04:00
transform_module_variable.go eval variables with unknown expansion data 2020-04-08 15:37:38 -04:00
transform_orphan_count_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_orphan_count.go expansion resource and instance orphans 2020-04-02 16:00:35 -04:00
transform_orphan_output.go get rid of the NodeOutputOrphan 2020-05-28 21:30:44 -04:00
transform_orphan_resource_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_orphan_resource.go make the root node a nodeCloseModule for root 2020-04-02 16:00:36 -04:00
transform_output.go do not look for all descendants from root outputs 2020-06-11 09:53:09 -04:00
transform_provider_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_provider.go remove abstract resource node from destroy node 2020-04-02 16:00:35 -04:00
transform_provisioner_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_provisioner.go only create one provisioner instance per type 2019-08-21 19:41:56 -04:00
transform_reference_test.go implement GraphNodeModulePath 2020-03-10 17:25:11 -04:00
transform_reference.go reduce module instances refs to the module call 2020-06-15 20:46:53 -04:00
transform_removed_modules.go pruneUnusedNodesTransformer 2020-05-28 21:30:42 -04:00
transform_resource_count.go s/GraphNodeResource/GraphNodeConfigResource/ 2020-03-16 11:16:23 -04:00
transform_root_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_root.go make the root node a nodeCloseModule for root 2020-04-02 16:00:36 -04:00
transform_state.go cleanup from resource state mods 2020-03-16 11:16:23 -04:00
transform_targets_test.go TransformTargets cannot depends on knowing Destroy 2020-06-10 15:38:35 -04:00
transform_targets.go new targets transformer 2020-06-24 10:27:52 -04:00
transform_transitive_reduction_test.go Mildwonkey/tests (#24522) 2020-04-06 09:24:23 -07:00
transform_transitive_reduction.go terraform: add TransitiveReductionTransformer 2015-02-27 19:18:04 -08:00
transform_variable.go terraform: ugly huge change to weave in new HCL2-oriented types 2018-10-16 18:46:46 -07:00
transform_vertex_test.go terraform: GraphVertexTransformers 2015-02-19 12:07:57 -08:00
transform_vertex.go terraform: GraphVertexTransformers 2015-02-19 12:07:57 -08:00
transform.go helper/logging: Bring the LevelFilter into our own codebase 2019-12-05 15:22:03 -08:00
ui_input_mock.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
ui_input_prefix_test.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
ui_input_prefix.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
ui_input.go core: add a context to the UIInput interface 2019-03-08 10:24:40 +01:00
ui_output_callback_test.go terraform: provisioners 2015-02-19 12:08:06 -08:00
ui_output_callback.go terraform: provisioners 2015-02-19 12:08:06 -08:00
ui_output_mock_test.go terraform: UIOutput interface 2014-10-04 09:00:07 -07:00
ui_output_mock.go minor race fix in tests 2017-10-02 16:19:01 -04:00
ui_output_provisioner_test.go terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
ui_output_provisioner.go terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
ui_output.go terraform: UIOutput interface 2014-10-04 09:00:07 -07:00
upgrade_state_v1_test.go Fix swallowed tests in terraform package tests 2017-07-20 02:23:43 -07:00
upgrade_state_v2_test.go core: Add test for V2->V3 state upgrade 2016-06-09 11:16:34 +01:00
user_agent.go httpclient: Introduce composable UserAgent() 2019-08-05 11:07:21 +01:00
util_test.go Resolve resource provider types in config package 2017-06-09 14:03:59 -07:00
util.go Fix negative parallelism and negative semaphore (#23902) 2020-02-12 10:10:52 -05:00
valuesourcetype_string.go stringer: Regenerate files with latest version 2019-05-13 15:34:27 +01:00
variables_test.go vendor: upgrade go-cty dependency to 1.4.1 (#24983) 2020-05-18 14:10:19 -04:00
variables.go Version tools per Go convention under tools.go 2019-10-17 22:23:39 +02:00
version_required.go vendor: switch to HCL 2.0 in the HCL repository 2019-10-02 15:10:21 -07:00
version.go httpclient: Introduce composable UserAgent() 2019-08-05 11:07:21 +01:00
walkoperation_string.go stringer: Regenerate files with latest version 2019-05-13 15:34:27 +01:00