mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-25 16:31:10 -06:00
fedd315275
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
73 lines
2.3 KiB
Go
73 lines
2.3 KiB
Go
package e2etest
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/terraform/internal/e2e"
|
|
)
|
|
|
|
// TestProvisionerPlugin is a test that terraform can execute a 3rd party
|
|
// provisioner plugin.
|
|
func TestProvisionerPlugin(t *testing.T) {
|
|
if !canRunGoBuild {
|
|
// We're running in a separate-build-then-run context, so we can't
|
|
// currently execute this test which depends on being able to build
|
|
// new executable at runtime.
|
|
//
|
|
// (See the comment on canRunGoBuild's declaration for more information.)
|
|
t.Skip("can't run without building a new provisioner executable")
|
|
}
|
|
t.Parallel()
|
|
|
|
// This test reaches out to releases.hashicorp.com to download the
|
|
// template and null providers, so it can only run if network access is
|
|
// allowed.
|
|
skipIfCannotAccessNetwork(t)
|
|
|
|
tf := e2e.NewBinary(t, terraformBin, "testdata/provisioner-plugin")
|
|
|
|
// In order to do a decent end-to-end test for this case we will need a
|
|
// real enough provisioner plugin to try to run and make sure we are able
|
|
// to actually run it. Here will build the local-exec provisioner into a
|
|
// binary called test-provisioner
|
|
provisionerExePrefix := filepath.Join(tf.WorkDir(), "terraform-provisioner-test_")
|
|
provisionerExe := e2e.GoBuild("github.com/hashicorp/terraform/internal/provisioner-local-exec/main", provisionerExePrefix)
|
|
|
|
// provisioners must use the old binary name format, so rename this binary
|
|
newExe := filepath.Join(tf.WorkDir(), "terraform-provisioner-test")
|
|
if _, err := os.Stat(newExe); !os.IsNotExist(err) {
|
|
t.Fatalf("%q already exists", newExe)
|
|
}
|
|
if err := os.Rename(provisionerExe, newExe); err != nil {
|
|
t.Fatalf("error renaming provisioner binary: %v", err)
|
|
}
|
|
provisionerExe = newExe
|
|
|
|
t.Logf("temporary provisioner executable is %s", provisionerExe)
|
|
|
|
//// INIT
|
|
_, stderr, err := tf.Run("init")
|
|
if err != nil {
|
|
t.Fatalf("unexpected init error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
//// PLAN
|
|
_, stderr, err = tf.Run("plan", "-out=tfplan")
|
|
if err != nil {
|
|
t.Fatalf("unexpected plan error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
//// APPLY
|
|
stdout, stderr, err := tf.Run("apply", "tfplan")
|
|
if err != nil {
|
|
t.Fatalf("unexpected apply error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
if !strings.Contains(stdout, "HelloProvisioner") {
|
|
t.Fatalf("missing provisioner output:\n%s", stdout)
|
|
}
|
|
}
|