mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-30 10:47:14 -06:00
86c02d5c35
There are a few constructs from 0.11 and prior that cause 0.12 parsing to fail altogether, which previously created a chicken/egg problem because we need to install the providers in order to run "terraform 0.12upgrade" and thus fix the problem. This changes "terraform init" to use the new "early configuration" loader for module and provider installation. This is built on the more permissive parser in the terraform-config-inspect package, and so it allows us to read out the top-level blocks from the configuration while accepting legacy HCL syntax. In the long run this will let us do version compatibility detection before attempting a "real" config load, giving us better error messages for any future syntax additions, but in the short term the key thing is that it allows us to install the dependencies even if the configuration isn't fully valid. Because backend init still requires full configuration, this introduces a new mode of terraform init where it detects heuristically if it seems like we need to do a configuration upgrade and does a partial init if so, before finally directing the user to run "terraform 0.12upgrade" before running any other commands. The heuristic here is based on two assumptions: - If the "early" loader finds no errors but the normal loader does, the configuration is likely to be valid for Terraform 0.11 but not 0.12. - If there's already a version constraint in the configuration that excludes Terraform versions prior to v0.12 then the configuration is probably _already_ upgraded and so it's just a normal syntax error, even if the early loader didn't detect it. Once the upgrade process is removed in 0.13.0 (users will be required to go stepwise 0.11 -> 0.12 -> 0.13 to upgrade after that), some of this can be simplified to remove that special mode, but the idea of doing the dependency version checks against the liberal parser will remain valuable to increase our chances of reporting version-based incompatibilities rather than syntax errors as we add new features in future.
151 lines
5.0 KiB
Go
151 lines
5.0 KiB
Go
package configload
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
|
|
"github.com/hashicorp/terraform/configs"
|
|
"github.com/hashicorp/terraform/registry"
|
|
"github.com/hashicorp/terraform/svchost/disco"
|
|
"github.com/spf13/afero"
|
|
)
|
|
|
|
// A Loader instance is the main entry-point for loading configurations via
|
|
// this package.
|
|
//
|
|
// It extends the general config-loading functionality in the parent package
|
|
// "configs" to support installation of modules from remote sources and
|
|
// loading full configurations using modules that were previously installed.
|
|
type Loader struct {
|
|
// parser is used to read configuration
|
|
parser *configs.Parser
|
|
|
|
// modules is used to install and locate descendent modules that are
|
|
// referenced (directly or indirectly) from the root module.
|
|
modules moduleMgr
|
|
}
|
|
|
|
// Config is used with NewLoader to specify configuration arguments for the
|
|
// loader.
|
|
type Config struct {
|
|
// ModulesDir is a path to a directory where descendent modules are
|
|
// (or should be) installed. (This is usually the
|
|
// .terraform/modules directory, in the common case where this package
|
|
// is being loaded from the main Terraform CLI package.)
|
|
ModulesDir string
|
|
|
|
// Services is the service discovery client to use when locating remote
|
|
// module registry endpoints. If this is nil then registry sources are
|
|
// not supported, which should be true only in specialized circumstances
|
|
// such as in tests.
|
|
Services *disco.Disco
|
|
}
|
|
|
|
// NewLoader creates and returns a loader that reads configuration from the
|
|
// real OS filesystem.
|
|
//
|
|
// The loader has some internal state about the modules that are currently
|
|
// installed, which is read from disk as part of this function. If that
|
|
// manifest cannot be read then an error will be returned.
|
|
func NewLoader(config *Config) (*Loader, error) {
|
|
fs := afero.NewOsFs()
|
|
parser := configs.NewParser(fs)
|
|
reg := registry.NewClient(config.Services, nil)
|
|
|
|
ret := &Loader{
|
|
parser: parser,
|
|
modules: moduleMgr{
|
|
FS: afero.Afero{Fs: fs},
|
|
CanInstall: true,
|
|
Dir: config.ModulesDir,
|
|
Services: config.Services,
|
|
Registry: reg,
|
|
},
|
|
}
|
|
|
|
err := ret.modules.readModuleManifestSnapshot()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to read module manifest: %s", err)
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
// ModulesDir returns the path to the directory where the loader will look for
|
|
// the local cache of remote module packages.
|
|
func (l *Loader) ModulesDir() string {
|
|
return l.modules.Dir
|
|
}
|
|
|
|
// RefreshModules updates the in-memory cache of the module manifest from the
|
|
// module manifest file on disk. This is not necessary in normal use because
|
|
// module installation and configuration loading are separate steps, but it
|
|
// can be useful in tests where module installation is done as a part of
|
|
// configuration loading by a helper function.
|
|
//
|
|
// Call this function after any module installation where an existing loader
|
|
// is already alive and may be used again later.
|
|
//
|
|
// An error is returned if the manifest file cannot be read.
|
|
func (l *Loader) RefreshModules() error {
|
|
if l == nil {
|
|
// Nothing to do, then.
|
|
return nil
|
|
}
|
|
return l.modules.readModuleManifestSnapshot()
|
|
}
|
|
|
|
// Parser returns the underlying parser for this loader.
|
|
//
|
|
// This is useful for loading other sorts of files than the module directories
|
|
// that a loader deals with, since then they will share the source code cache
|
|
// for this loader and can thus be shown as snippets in diagnostic messages.
|
|
func (l *Loader) Parser() *configs.Parser {
|
|
return l.parser
|
|
}
|
|
|
|
// Sources returns the source code cache for the underlying parser of this
|
|
// loader. This is a shorthand for l.Parser().Sources().
|
|
func (l *Loader) Sources() map[string][]byte {
|
|
return l.parser.Sources()
|
|
}
|
|
|
|
// IsConfigDir returns true if and only if the given directory contains at
|
|
// least one Terraform configuration file. This is a wrapper around calling
|
|
// the same method name on the loader's parser.
|
|
func (l *Loader) IsConfigDir(path string) bool {
|
|
return l.parser.IsConfigDir(path)
|
|
}
|
|
|
|
// ImportSources writes into the receiver's source code the given source
|
|
// code buffers.
|
|
//
|
|
// This is useful in the situation where an ancillary loader is created for
|
|
// some reason (e.g. loading config from a plan file) but the cached source
|
|
// code from that loader must be imported into the "main" loader in order
|
|
// to return source code snapshots in diagnostic messages.
|
|
//
|
|
// loader.ImportSources(otherLoader.Sources())
|
|
func (l *Loader) ImportSources(sources map[string][]byte) {
|
|
p := l.Parser()
|
|
for name, src := range sources {
|
|
p.ForceFileSource(name, src)
|
|
}
|
|
}
|
|
|
|
// ImportSourcesFromSnapshot writes into the receiver's source code the
|
|
// source files from the given snapshot.
|
|
//
|
|
// This is similar to ImportSources but knows how to unpack and flatten a
|
|
// snapshot data structure to get the corresponding flat source file map.
|
|
func (l *Loader) ImportSourcesFromSnapshot(snap *Snapshot) {
|
|
p := l.Parser()
|
|
for _, m := range snap.Modules {
|
|
baseDir := m.Dir
|
|
for fn, src := range m.Files {
|
|
fullPath := filepath.Join(baseDir, fn)
|
|
p.ForceFileSource(fullPath, src)
|
|
}
|
|
}
|
|
}
|