mirror of
https://github.com/opentofu/opentofu.git
synced 2025-02-14 01:13:59 -06:00
6ebac8403d
* provider/aws: Fix hashing on CloudFront certificate parameters
Adding necessary type assertion to values on the viewer_certificate hash
function to ensure that certain fields are indeed not zero string
values, versus simply zero interface{} values (aka nil, as is such for a
map[string]interface{}).
* provider/aws: CloudFront complex structure error handling
Handle errors better on calls to d.Set() in the
aws_cloudfront_distribution, namely in flattenDistributionConfig(). Also
caught a bug in the setting of the origin attribute, was incorrectly
attempting to set origins.
* provider/aws: Pass pointers to set CloudFront primitives
Change a few d.Set() for primitives in aws_cloudfront_distribution and
aws_cloudfront_origin_access_identity to use the pointer versus a
dereference.
* docs: Fix CloudFront examples formatting
Ran each example thru terraform fmt to fix indentation.
* provider/aws: Remove delete retention on CloudFront tests
To play better with Travis and not bloat the test account with disabled
distributions.
Disable-only functionality has been retained - one can enable it with
the TF_TEST_CLOUDFRONT_RETAIN environment variable.
* provider/aws: CloudFront delete waiter error handling
The call to resourceAwsCloudFrontDistributionWaitUntilDeployed() on
deletion of CloudFront distributions was not trapping error messages,
causing issues with waiter failure.
422 lines
11 KiB
Go
422 lines
11 KiB
Go
package aws
|
|
|
|
import (
|
|
"fmt"
|
|
"math/rand"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/service/cloudfront"
|
|
"github.com/hashicorp/terraform/helper/resource"
|
|
"github.com/hashicorp/terraform/terraform"
|
|
)
|
|
|
|
// TestAccAWSCloudFrontDistribution_S3Origin runs an
|
|
// aws_cloudfront_distribution acceptance test with a single S3 origin.
|
|
//
|
|
// If you are testing manually and can't wait for deletion, set the
|
|
// TF_TEST_CLOUDFRONT_RETAIN environment variable.
|
|
func TestAccAWSCloudFrontDistribution_S3Origin(t *testing.T) {
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckCloudFrontDistributionDestroy,
|
|
Steps: []resource.TestStep{
|
|
resource.TestStep{
|
|
Config: testAccAWSCloudFrontDistributionS3Config,
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckCloudFrontDistributionExistence(
|
|
"aws_cloudfront_distribution.s3_distribution",
|
|
),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
// TestAccAWSCloudFrontDistribution_customOriginruns an
|
|
// aws_cloudfront_distribution acceptance test with a single custom origin.
|
|
//
|
|
// If you are testing manually and can't wait for deletion, set the
|
|
// TF_TEST_CLOUDFRONT_RETAIN environment variable.
|
|
func TestAccAWSCloudFrontDistribution_customOrigin(t *testing.T) {
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckCloudFrontDistributionDestroy,
|
|
Steps: []resource.TestStep{
|
|
resource.TestStep{
|
|
Config: testAccAWSCloudFrontDistributionCustomConfig,
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckCloudFrontDistributionExistence(
|
|
"aws_cloudfront_distribution.custom_distribution",
|
|
),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
// TestAccAWSCloudFrontDistribution_multiOrigin runs an
|
|
// aws_cloudfront_distribution acceptance test with multiple origins.
|
|
//
|
|
// If you are testing manually and can't wait for deletion, set the
|
|
// TF_TEST_CLOUDFRONT_RETAIN environment variable.
|
|
func TestAccAWSCloudFrontDistribution_multiOrigin(t *testing.T) {
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckCloudFrontDistributionDestroy,
|
|
Steps: []resource.TestStep{
|
|
resource.TestStep{
|
|
Config: testAccAWSCloudFrontDistributionMultiOriginConfig,
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckCloudFrontDistributionExistence(
|
|
"aws_cloudfront_distribution.multi_origin_distribution",
|
|
),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
// TestAccAWSCloudFrontDistribution_noOptionalItemsConfig runs an
|
|
// aws_cloudfront_distribution acceptance test with no optional items set.
|
|
//
|
|
// If you are testing manually and can't wait for deletion, set the
|
|
// TF_TEST_CLOUDFRONT_RETAIN environment variable.
|
|
func TestAccAWSCloudFrontDistribution_noOptionalItemsConfig(t *testing.T) {
|
|
resource.Test(t, resource.TestCase{
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
Providers: testAccProviders,
|
|
CheckDestroy: testAccCheckCloudFrontDistributionDestroy,
|
|
Steps: []resource.TestStep{
|
|
resource.TestStep{
|
|
Config: testAccAWSCloudFrontDistributionNoOptionalItemsConfig,
|
|
Check: resource.ComposeTestCheckFunc(
|
|
testAccCheckCloudFrontDistributionExistence(
|
|
"aws_cloudfront_distribution.no_optional_items",
|
|
),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func testAccCheckCloudFrontDistributionDestroy(s *terraform.State) error {
|
|
for k, rs := range s.RootModule().Resources {
|
|
if rs.Type != "aws_cloudfront_distribution" {
|
|
continue
|
|
}
|
|
dist, err := testAccAuxCloudFrontGetDistributionConfig(s, k)
|
|
if err == nil {
|
|
if _, ok := os.LookupEnv("TF_TEST_CLOUDFRONT_RETAIN"); ok {
|
|
if *dist.DistributionConfig.Enabled != false {
|
|
return fmt.Errorf("CloudFront distribution should be disabled")
|
|
}
|
|
return nil
|
|
}
|
|
return fmt.Errorf("CloudFront distribution did not destroy")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func testAccCheckCloudFrontDistributionExistence(cloudFrontResource string) resource.TestCheckFunc {
|
|
return func(s *terraform.State) error {
|
|
_, err := testAccAuxCloudFrontGetDistributionConfig(s, cloudFrontResource)
|
|
|
|
return err
|
|
}
|
|
}
|
|
|
|
func testAccAuxCloudFrontGetDistributionConfig(s *terraform.State, cloudFrontResource string) (*cloudfront.Distribution, error) {
|
|
cf, ok := s.RootModule().Resources[cloudFrontResource]
|
|
if !ok {
|
|
return nil, fmt.Errorf("Not found: %s", cloudFrontResource)
|
|
}
|
|
|
|
if cf.Primary.ID == "" {
|
|
return nil, fmt.Errorf("No Id is set")
|
|
}
|
|
|
|
cloudfrontconn := testAccProvider.Meta().(*AWSClient).cloudfrontconn
|
|
|
|
req := &cloudfront.GetDistributionInput{
|
|
Id: aws.String(cf.Primary.ID),
|
|
}
|
|
|
|
res, err := cloudfrontconn.GetDistribution(req)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("Error retrieving CloudFront distribution: %s", err)
|
|
}
|
|
|
|
return res.Distribution, nil
|
|
}
|
|
|
|
func testAccAWSCloudFrontDistributionRetainConfig() string {
|
|
if _, ok := os.LookupEnv("TF_TEST_CLOUDFRONT_RETAIN"); ok {
|
|
return "retain_on_delete = true"
|
|
}
|
|
return ""
|
|
}
|
|
|
|
var testAccAWSCloudFrontDistributionS3Config = fmt.Sprintf(`
|
|
variable rand_id {
|
|
default = %d
|
|
}
|
|
|
|
resource "aws_s3_bucket" "s3_bucket" {
|
|
bucket = "mybucket.${var.rand_id}.s3.amazonaws.com"
|
|
acl = "public-read"
|
|
}
|
|
|
|
resource "aws_cloudfront_distribution" "s3_distribution" {
|
|
origin {
|
|
domain_name = "${aws_s3_bucket.s3_bucket.id}"
|
|
origin_id = "myS3Origin"
|
|
s3_origin_config {}
|
|
}
|
|
enabled = true
|
|
default_root_object = "index.html"
|
|
logging_config {
|
|
include_cookies = false
|
|
bucket = "mylogs.${var.rand_id}.s3.amazonaws.com"
|
|
prefix = "myprefix"
|
|
}
|
|
aliases = [ "mysite.${var.rand_id}.example.com", "yoursite.${var.rand_id}.example.com" ]
|
|
default_cache_behavior {
|
|
allowed_methods = [ "DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT" ]
|
|
cached_methods = [ "GET", "HEAD" ]
|
|
target_origin_id = "myS3Origin"
|
|
forwarded_values {
|
|
query_string = false
|
|
cookies {
|
|
forward = "none"
|
|
}
|
|
}
|
|
viewer_protocol_policy = "allow-all"
|
|
min_ttl = 0
|
|
default_ttl = 3600
|
|
max_ttl = 86400
|
|
}
|
|
price_class = "PriceClass_200"
|
|
restrictions {
|
|
geo_restriction {
|
|
restriction_type = "whitelist"
|
|
locations = [ "US", "CA", "GB", "DE" ]
|
|
}
|
|
}
|
|
viewer_certificate {
|
|
cloudfront_default_certificate = true
|
|
}
|
|
%s
|
|
}
|
|
`, rand.New(rand.NewSource(time.Now().UnixNano())).Int(), testAccAWSCloudFrontDistributionRetainConfig())
|
|
|
|
var testAccAWSCloudFrontDistributionCustomConfig = fmt.Sprintf(`
|
|
variable rand_id {
|
|
default = %d
|
|
}
|
|
|
|
resource "aws_cloudfront_distribution" "custom_distribution" {
|
|
origin {
|
|
domain_name = "www.example.com"
|
|
origin_id = "myCustomOrigin"
|
|
custom_origin_config {
|
|
http_port = 80
|
|
https_port = 443
|
|
origin_protocol_policy = "http-only"
|
|
origin_ssl_protocols = [ "SSLv3", "TLSv1" ]
|
|
}
|
|
}
|
|
enabled = true
|
|
comment = "Some comment"
|
|
default_root_object = "index.html"
|
|
logging_config {
|
|
include_cookies = false
|
|
bucket = "mylogs.${var.rand_id}.s3.amazonaws.com"
|
|
prefix = "myprefix"
|
|
}
|
|
aliases = [ "mysite.${var.rand_id}.example.com", "*.yoursite.${var.rand_id}.example.com" ]
|
|
default_cache_behavior {
|
|
allowed_methods = [ "DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT" ]
|
|
cached_methods = [ "GET", "HEAD" ]
|
|
target_origin_id = "myCustomOrigin"
|
|
smooth_streaming = false
|
|
forwarded_values {
|
|
query_string = false
|
|
cookies {
|
|
forward = "all"
|
|
}
|
|
}
|
|
viewer_protocol_policy = "allow-all"
|
|
min_ttl = 0
|
|
default_ttl = 3600
|
|
max_ttl = 86400
|
|
}
|
|
price_class = "PriceClass_200"
|
|
restrictions {
|
|
geo_restriction {
|
|
restriction_type = "whitelist"
|
|
locations = [ "US", "CA", "GB", "DE" ]
|
|
}
|
|
}
|
|
viewer_certificate {
|
|
cloudfront_default_certificate = true
|
|
}
|
|
%s
|
|
}
|
|
`, rand.New(rand.NewSource(time.Now().UnixNano())).Int(), testAccAWSCloudFrontDistributionRetainConfig())
|
|
|
|
var testAccAWSCloudFrontDistributionMultiOriginConfig = fmt.Sprintf(`
|
|
variable rand_id {
|
|
default = %d
|
|
}
|
|
|
|
resource "aws_s3_bucket" "s3_bucket" {
|
|
bucket = "mybucket.${var.rand_id}.s3.amazonaws.com"
|
|
acl = "public-read"
|
|
}
|
|
|
|
resource "aws_cloudfront_distribution" "multi_origin_distribution" {
|
|
origin {
|
|
domain_name = "${aws_s3_bucket.s3_bucket.id}"
|
|
origin_id = "myS3Origin"
|
|
s3_origin_config {}
|
|
}
|
|
origin {
|
|
domain_name = "www.example.com"
|
|
origin_id = "myCustomOrigin"
|
|
custom_origin_config {
|
|
http_port = 80
|
|
https_port = 443
|
|
origin_protocol_policy = "http-only"
|
|
origin_ssl_protocols = [ "SSLv3", "TLSv1" ]
|
|
}
|
|
}
|
|
enabled = true
|
|
comment = "Some comment"
|
|
default_root_object = "index.html"
|
|
logging_config {
|
|
include_cookies = false
|
|
bucket = "mylogs.${var.rand_id}.s3.amazonaws.com"
|
|
prefix = "myprefix"
|
|
}
|
|
aliases = [ "mysite.${var.rand_id}.example.com", "*.yoursite.${var.rand_id}.example.com" ]
|
|
default_cache_behavior {
|
|
allowed_methods = [ "DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT" ]
|
|
cached_methods = [ "GET", "HEAD" ]
|
|
target_origin_id = "myS3Origin"
|
|
smooth_streaming = true
|
|
forwarded_values {
|
|
query_string = false
|
|
cookies {
|
|
forward = "all"
|
|
}
|
|
}
|
|
min_ttl = 100
|
|
default_ttl = 100
|
|
max_ttl = 100
|
|
viewer_protocol_policy = "allow-all"
|
|
}
|
|
cache_behavior {
|
|
allowed_methods = [ "DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT" ]
|
|
cached_methods = [ "GET", "HEAD" ]
|
|
target_origin_id = "myS3Origin"
|
|
forwarded_values {
|
|
query_string = true
|
|
cookies {
|
|
forward = "none"
|
|
}
|
|
}
|
|
min_ttl = 50
|
|
default_ttl = 50
|
|
max_ttl = 50
|
|
viewer_protocol_policy = "allow-all"
|
|
path_pattern = "images1/*.jpg"
|
|
}
|
|
cache_behavior {
|
|
allowed_methods = [ "DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT" ]
|
|
cached_methods = [ "GET", "HEAD" ]
|
|
target_origin_id = "myCustomOrigin"
|
|
forwarded_values {
|
|
query_string = true
|
|
cookies {
|
|
forward = "none"
|
|
}
|
|
}
|
|
min_ttl = 50
|
|
default_ttl = 50
|
|
max_ttl = 50
|
|
viewer_protocol_policy = "allow-all"
|
|
path_pattern = "images2/*.jpg"
|
|
}
|
|
price_class = "PriceClass_All"
|
|
custom_error_response {
|
|
error_code = 404
|
|
response_page_path = "/error-pages/404.html"
|
|
response_code = 200
|
|
error_caching_min_ttl = 30
|
|
}
|
|
restrictions {
|
|
geo_restriction {
|
|
restriction_type = "none"
|
|
}
|
|
}
|
|
viewer_certificate {
|
|
cloudfront_default_certificate = true
|
|
}
|
|
%s
|
|
}
|
|
`, rand.New(rand.NewSource(time.Now().UnixNano())).Int(), testAccAWSCloudFrontDistributionRetainConfig())
|
|
|
|
var testAccAWSCloudFrontDistributionNoOptionalItemsConfig = fmt.Sprintf(`
|
|
variable rand_id {
|
|
default = %d
|
|
}
|
|
|
|
resource "aws_cloudfront_distribution" "no_optional_items" {
|
|
origin {
|
|
domain_name = "www.example.com"
|
|
origin_id = "myCustomOrigin"
|
|
custom_origin_config {
|
|
http_port = 80
|
|
https_port = 443
|
|
origin_protocol_policy = "http-only"
|
|
origin_ssl_protocols = [ "SSLv3", "TLSv1" ]
|
|
}
|
|
}
|
|
enabled = true
|
|
comment = "Some comment"
|
|
default_cache_behavior {
|
|
allowed_methods = [ "DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT" ]
|
|
cached_methods = [ "GET", "HEAD" ]
|
|
target_origin_id = "myCustomOrigin"
|
|
smooth_streaming = false
|
|
forwarded_values {
|
|
query_string = false
|
|
cookies {
|
|
forward = "all"
|
|
}
|
|
}
|
|
viewer_protocol_policy = "allow-all"
|
|
min_ttl = 0
|
|
default_ttl = 3600
|
|
max_ttl = 86400
|
|
}
|
|
restrictions {
|
|
geo_restriction {
|
|
restriction_type = "whitelist"
|
|
locations = [ "US", "CA", "GB", "DE" ]
|
|
}
|
|
}
|
|
viewer_certificate {
|
|
cloudfront_default_certificate = true
|
|
}
|
|
%s
|
|
}
|
|
`, rand.New(rand.NewSource(time.Now().UnixNano())).Int(), testAccAWSCloudFrontDistributionRetainConfig())
|