mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-26 00:41:27 -06:00
47a16b0937
a large refactor to addrs.AbsProviderConfig, embedding the addrs.Provider instead of a Type string. I've added and updated tests, added some Legacy functions to support older state formats and shims, and added a normalization step when reading v4 (current) state files (not the added tests under states/statefile/roundtrip which work with both current and legacy-style AbsProviderConfig strings). The remaining 'fixme' and 'todo' comments are mostly going to be addressed in a subsequent PR and involve looking up a given local provider config's FQN. This is fine for now as we are only working with default assumption.
373 lines
10 KiB
Go
373 lines
10 KiB
Go
package terraform
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/terraform/addrs"
|
|
"github.com/hashicorp/terraform/configs/configschema"
|
|
"github.com/hashicorp/terraform/providers"
|
|
"github.com/zclconf/go-cty/cty"
|
|
)
|
|
|
|
func TestPlanGraphBuilder_impl(t *testing.T) {
|
|
var _ GraphBuilder = new(PlanGraphBuilder)
|
|
}
|
|
|
|
func TestPlanGraphBuilder(t *testing.T) {
|
|
awsProvider := &MockProvider{
|
|
GetSchemaReturn: &ProviderSchema{
|
|
Provider: simpleTestSchema(),
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
"aws_security_group": simpleTestSchema(),
|
|
"aws_instance": simpleTestSchema(),
|
|
"aws_load_balancer": simpleTestSchema(),
|
|
},
|
|
},
|
|
}
|
|
openstackProvider := &MockProvider{
|
|
GetSchemaReturn: &ProviderSchema{
|
|
Provider: simpleTestSchema(),
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
"openstack_floating_ip": simpleTestSchema(),
|
|
},
|
|
},
|
|
}
|
|
components := &basicComponentFactory{
|
|
providers: map[addrs.Provider]providers.Factory{
|
|
addrs.NewLegacyProvider("aws"): providers.FactoryFixed(awsProvider),
|
|
addrs.NewLegacyProvider("openstack"): providers.FactoryFixed(openstackProvider),
|
|
},
|
|
}
|
|
|
|
b := &PlanGraphBuilder{
|
|
Config: testModule(t, "graph-builder-plan-basic"),
|
|
Components: components,
|
|
Schemas: &Schemas{
|
|
Providers: map[addrs.Provider]*ProviderSchema{
|
|
addrs.NewLegacyProvider("aws"): awsProvider.GetSchemaReturn,
|
|
addrs.NewLegacyProvider("openstack"): openstackProvider.GetSchemaReturn,
|
|
},
|
|
},
|
|
DisableReduce: true,
|
|
}
|
|
|
|
g, err := b.Build(addrs.RootModuleInstance)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
if g.Path.String() != addrs.RootModuleInstance.String() {
|
|
t.Fatalf("wrong module path %q", g.Path)
|
|
}
|
|
|
|
actual := strings.TrimSpace(g.String())
|
|
expected := strings.TrimSpace(testPlanGraphBuilderStr)
|
|
if actual != expected {
|
|
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestPlanGraphBuilder_dynamicBlock(t *testing.T) {
|
|
provider := &MockProvider{
|
|
GetSchemaReturn: &ProviderSchema{
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
"test_thing": {
|
|
Attributes: map[string]*configschema.Attribute{
|
|
"id": {Type: cty.String, Computed: true},
|
|
"list": {Type: cty.List(cty.String), Computed: true},
|
|
},
|
|
BlockTypes: map[string]*configschema.NestedBlock{
|
|
"nested": {
|
|
Nesting: configschema.NestingList,
|
|
Block: configschema.Block{
|
|
Attributes: map[string]*configschema.Attribute{
|
|
"foo": {Type: cty.String, Optional: true},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
components := &basicComponentFactory{
|
|
providers: map[addrs.Provider]providers.Factory{
|
|
addrs.NewLegacyProvider("test"): providers.FactoryFixed(provider),
|
|
},
|
|
}
|
|
|
|
b := &PlanGraphBuilder{
|
|
Config: testModule(t, "graph-builder-plan-dynblock"),
|
|
Components: components,
|
|
Schemas: &Schemas{
|
|
Providers: map[addrs.Provider]*ProviderSchema{
|
|
addrs.NewLegacyProvider("test"): provider.GetSchemaReturn,
|
|
},
|
|
},
|
|
DisableReduce: true,
|
|
}
|
|
|
|
g, err := b.Build(addrs.RootModuleInstance)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
if g.Path.String() != addrs.RootModuleInstance.String() {
|
|
t.Fatalf("wrong module path %q", g.Path)
|
|
}
|
|
|
|
// This test is here to make sure we properly detect references inside
|
|
// the special "dynamic" block construct. The most important thing here
|
|
// is that at the end test_thing.c depends on both test_thing.a and
|
|
// test_thing.b. Other details might shift over time as other logic in
|
|
// the graph builders changes.
|
|
actual := strings.TrimSpace(g.String())
|
|
expected := strings.TrimSpace(`
|
|
meta.count-boundary (EachMode fixup)
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.a
|
|
test_thing.b
|
|
test_thing.c
|
|
provider["registry.terraform.io/-/test"]
|
|
provider["registry.terraform.io/-/test"] (close)
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.a
|
|
test_thing.b
|
|
test_thing.c
|
|
root
|
|
meta.count-boundary (EachMode fixup)
|
|
provider["registry.terraform.io/-/test"] (close)
|
|
test_thing.a
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.b
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.c
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.a
|
|
test_thing.b
|
|
`)
|
|
if actual != expected {
|
|
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestPlanGraphBuilder_attrAsBlocks(t *testing.T) {
|
|
provider := &MockProvider{
|
|
GetSchemaReturn: &ProviderSchema{
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
"test_thing": {
|
|
Attributes: map[string]*configschema.Attribute{
|
|
"id": {Type: cty.String, Computed: true},
|
|
"nested": {
|
|
Type: cty.List(cty.Object(map[string]cty.Type{
|
|
"foo": cty.String,
|
|
})),
|
|
Optional: true,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
components := &basicComponentFactory{
|
|
providers: map[addrs.Provider]providers.Factory{
|
|
addrs.NewLegacyProvider("test"): providers.FactoryFixed(provider),
|
|
},
|
|
}
|
|
|
|
b := &PlanGraphBuilder{
|
|
Config: testModule(t, "graph-builder-plan-attr-as-blocks"),
|
|
Components: components,
|
|
Schemas: &Schemas{
|
|
Providers: map[addrs.Provider]*ProviderSchema{
|
|
addrs.NewLegacyProvider("test"): provider.GetSchemaReturn,
|
|
},
|
|
},
|
|
DisableReduce: true,
|
|
}
|
|
|
|
g, err := b.Build(addrs.RootModuleInstance)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
if g.Path.String() != addrs.RootModuleInstance.String() {
|
|
t.Fatalf("wrong module path %q", g.Path)
|
|
}
|
|
|
|
// This test is here to make sure we properly detect references inside
|
|
// the "nested" block that is actually defined in the schema as a
|
|
// list-of-objects attribute. This requires some special effort
|
|
// inside lang.ReferencesInBlock to make sure it searches blocks of
|
|
// type "nested" along with an attribute named "nested".
|
|
actual := strings.TrimSpace(g.String())
|
|
expected := strings.TrimSpace(`
|
|
meta.count-boundary (EachMode fixup)
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.a
|
|
test_thing.b
|
|
provider["registry.terraform.io/-/test"]
|
|
provider["registry.terraform.io/-/test"] (close)
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.a
|
|
test_thing.b
|
|
root
|
|
meta.count-boundary (EachMode fixup)
|
|
provider["registry.terraform.io/-/test"] (close)
|
|
test_thing.a
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.b
|
|
provider["registry.terraform.io/-/test"]
|
|
test_thing.a
|
|
`)
|
|
if actual != expected {
|
|
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
|
|
}
|
|
}
|
|
|
|
func TestPlanGraphBuilder_targetModule(t *testing.T) {
|
|
b := &PlanGraphBuilder{
|
|
Config: testModule(t, "graph-builder-plan-target-module-provider"),
|
|
Components: simpleMockComponentFactory(),
|
|
Schemas: simpleTestSchemas(),
|
|
Targets: []addrs.Targetable{
|
|
addrs.RootModuleInstance.Child("child2", addrs.NoKey),
|
|
},
|
|
}
|
|
|
|
g, err := b.Build(addrs.RootModuleInstance)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
t.Logf("Graph: %s", g.String())
|
|
|
|
testGraphNotContains(t, g, `module.child1.provider["registry.terraform.io/-/test"]`)
|
|
testGraphNotContains(t, g, "module.child1.test_object.foo")
|
|
}
|
|
|
|
func TestPlanGraphBuilder_forEach(t *testing.T) {
|
|
awsProvider := &MockProvider{
|
|
GetSchemaReturn: &ProviderSchema{
|
|
Provider: simpleTestSchema(),
|
|
ResourceTypes: map[string]*configschema.Block{
|
|
"aws_instance": simpleTestSchema(),
|
|
},
|
|
},
|
|
}
|
|
|
|
components := &basicComponentFactory{
|
|
providers: map[addrs.Provider]providers.Factory{
|
|
addrs.NewLegacyProvider("aws"): providers.FactoryFixed(awsProvider),
|
|
},
|
|
}
|
|
|
|
b := &PlanGraphBuilder{
|
|
Config: testModule(t, "plan-for-each"),
|
|
Components: components,
|
|
Schemas: &Schemas{
|
|
Providers: map[addrs.Provider]*ProviderSchema{
|
|
addrs.NewLegacyProvider("aws"): awsProvider.GetSchemaReturn,
|
|
},
|
|
},
|
|
DisableReduce: true,
|
|
}
|
|
|
|
g, err := b.Build(addrs.RootModuleInstance)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
if g.Path.String() != addrs.RootModuleInstance.String() {
|
|
t.Fatalf("wrong module path %q", g.Path)
|
|
}
|
|
|
|
actual := strings.TrimSpace(g.String())
|
|
// We're especially looking for the edge here, where aws_instance.bat
|
|
// has a dependency on aws_instance.boo
|
|
expected := strings.TrimSpace(testPlanGraphBuilderForEachStr)
|
|
if actual != expected {
|
|
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
|
|
}
|
|
}
|
|
|
|
const testPlanGraphBuilderStr = `
|
|
aws_instance.web
|
|
aws_security_group.firewall
|
|
provider["registry.terraform.io/-/aws"]
|
|
var.foo
|
|
aws_load_balancer.weblb
|
|
aws_instance.web
|
|
provider["registry.terraform.io/-/aws"]
|
|
aws_security_group.firewall
|
|
provider["registry.terraform.io/-/aws"]
|
|
local.instance_id
|
|
aws_instance.web
|
|
meta.count-boundary (EachMode fixup)
|
|
aws_instance.web
|
|
aws_load_balancer.weblb
|
|
aws_security_group.firewall
|
|
local.instance_id
|
|
openstack_floating_ip.random
|
|
output.instance_id
|
|
provider["registry.terraform.io/-/aws"]
|
|
provider["registry.terraform.io/-/openstack"]
|
|
var.foo
|
|
openstack_floating_ip.random
|
|
provider["registry.terraform.io/-/openstack"]
|
|
output.instance_id
|
|
local.instance_id
|
|
provider["registry.terraform.io/-/aws"]
|
|
openstack_floating_ip.random
|
|
provider["registry.terraform.io/-/aws"] (close)
|
|
aws_instance.web
|
|
aws_load_balancer.weblb
|
|
aws_security_group.firewall
|
|
provider["registry.terraform.io/-/aws"]
|
|
provider["registry.terraform.io/-/openstack"]
|
|
provider["registry.terraform.io/-/openstack"] (close)
|
|
openstack_floating_ip.random
|
|
provider["registry.terraform.io/-/openstack"]
|
|
root
|
|
meta.count-boundary (EachMode fixup)
|
|
provider["registry.terraform.io/-/aws"] (close)
|
|
provider["registry.terraform.io/-/openstack"] (close)
|
|
var.foo
|
|
`
|
|
const testPlanGraphBuilderForEachStr = `
|
|
aws_instance.bar
|
|
provider["registry.terraform.io/-/aws"]
|
|
aws_instance.bar2
|
|
provider["registry.terraform.io/-/aws"]
|
|
aws_instance.bat
|
|
aws_instance.boo
|
|
provider["registry.terraform.io/-/aws"]
|
|
aws_instance.baz
|
|
provider["registry.terraform.io/-/aws"]
|
|
aws_instance.boo
|
|
provider["registry.terraform.io/-/aws"]
|
|
aws_instance.foo
|
|
provider["registry.terraform.io/-/aws"]
|
|
meta.count-boundary (EachMode fixup)
|
|
aws_instance.bar
|
|
aws_instance.bar2
|
|
aws_instance.bat
|
|
aws_instance.baz
|
|
aws_instance.boo
|
|
aws_instance.foo
|
|
provider["registry.terraform.io/-/aws"]
|
|
provider["registry.terraform.io/-/aws"]
|
|
provider["registry.terraform.io/-/aws"] (close)
|
|
aws_instance.bar
|
|
aws_instance.bar2
|
|
aws_instance.bat
|
|
aws_instance.baz
|
|
aws_instance.boo
|
|
aws_instance.foo
|
|
provider["registry.terraform.io/-/aws"]
|
|
root
|
|
meta.count-boundary (EachMode fixup)
|
|
provider["registry.terraform.io/-/aws"] (close)
|
|
`
|