mirror of
https://github.com/opentofu/opentofu.git
synced 2025-02-09 23:25:33 -06:00
Currently Terraform is leaking goroutines and with that memory. I know strictly speaking this maybe isn’t a real concern for Terraform as it’s mostly used as a short running command line executable. But there are a few of us out there that are using Terraform in some long running processes and then this starts to become a problem. Next to that it’s of course good programming practise to clean up resources when they're not needed anymore. So even for the standard command line use case, this seems an improvement in resource management. Personally I see no downsides as the primary connection to the plugin is kept alive (the plugin is not killed) and only unused connections that will never be used again are closed to free up any related goroutines and memory.
250 lines
6.8 KiB
Go
250 lines
6.8 KiB
Go
package terraform
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
"github.com/hashicorp/terraform/dag"
|
|
)
|
|
|
|
// GraphNodeProvisioner is an interface that nodes that can be a provisioner
|
|
// must implement. The ProvisionerName returned is the name of the provisioner
|
|
// they satisfy.
|
|
type GraphNodeProvisioner interface {
|
|
ProvisionerName() string
|
|
}
|
|
|
|
// GraphNodeCloseProvisioner is an interface that nodes that can be a close
|
|
// provisioner must implement. The CloseProvisionerName returned is the name
|
|
// of the provisioner they satisfy.
|
|
type GraphNodeCloseProvisioner interface {
|
|
CloseProvisionerName() string
|
|
}
|
|
|
|
// GraphNodeProvisionerConsumer is an interface that nodes that require
|
|
// a provisioner must implement. ProvisionedBy must return the name of the
|
|
// provisioner to use.
|
|
type GraphNodeProvisionerConsumer interface {
|
|
ProvisionedBy() []string
|
|
}
|
|
|
|
// ProvisionerTransformer is a GraphTransformer that maps resources to
|
|
// provisioners within the graph. This will error if there are any resources
|
|
// that don't map to proper resources.
|
|
type ProvisionerTransformer struct{}
|
|
|
|
func (t *ProvisionerTransformer) Transform(g *Graph) error {
|
|
// Go through the other nodes and match them to provisioners they need
|
|
var err error
|
|
m := provisionerVertexMap(g)
|
|
for _, v := range g.Vertices() {
|
|
if pv, ok := v.(GraphNodeProvisionerConsumer); ok {
|
|
for _, provisionerName := range pv.ProvisionedBy() {
|
|
target := m[provisionerName]
|
|
if target == nil {
|
|
err = multierror.Append(err, fmt.Errorf(
|
|
"%s: provisioner %s couldn't be found",
|
|
dag.VertexName(v), provisionerName))
|
|
continue
|
|
}
|
|
|
|
g.Connect(dag.BasicEdge(v, target))
|
|
}
|
|
}
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
// CloseProvisionerTransformer is a GraphTransformer that adds nodes to the
|
|
// graph that will close open provisioner connections that aren't needed
|
|
// anymore. A provisioner connection is not needed anymore once all depended
|
|
// resources in the graph are evaluated.
|
|
type CloseProvisionerTransformer struct{}
|
|
|
|
func (t *CloseProvisionerTransformer) Transform(g *Graph) error {
|
|
m := closeProvisionerVertexMap(g)
|
|
for _, v := range g.Vertices() {
|
|
if pv, ok := v.(GraphNodeProvisionerConsumer); ok {
|
|
for _, p := range pv.ProvisionedBy() {
|
|
source := m[p]
|
|
|
|
if source == nil {
|
|
// Create a new graphNodeCloseProvisioner and add it to the graph
|
|
source = &graphNodeCloseProvisioner{ProvisionerNameValue: p}
|
|
g.Add(source)
|
|
|
|
// Make sure we also add the new graphNodeCloseProvisioner to the map
|
|
// so we don't create and add any duplicate graphNodeCloseProvisioners.
|
|
m[p] = source
|
|
}
|
|
|
|
g.Connect(dag.BasicEdge(source, v))
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// MissingProvisionerTransformer is a GraphTransformer that adds nodes
|
|
// for missing provisioners into the graph. Specifically, it creates provisioner
|
|
// configuration nodes for all the provisioners that we support. These are
|
|
// pruned later during an optimization pass.
|
|
type MissingProvisionerTransformer struct {
|
|
// Provisioners is the list of provisioners we support.
|
|
Provisioners []string
|
|
}
|
|
|
|
func (t *MissingProvisionerTransformer) Transform(g *Graph) error {
|
|
m := provisionerVertexMap(g)
|
|
for _, p := range t.Provisioners {
|
|
if _, ok := m[p]; ok {
|
|
// This provisioner already exists as a configured node
|
|
continue
|
|
}
|
|
|
|
// Add our own missing provisioner node to the graph
|
|
g.Add(&graphNodeMissingProvisioner{ProvisionerNameValue: p})
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// PruneProvisionerTransformer is a GraphTransformer that prunes all the
|
|
// provisioners that aren't needed from the graph. A provisioner is unneeded if
|
|
// no resource or module is using that provisioner.
|
|
type PruneProvisionerTransformer struct{}
|
|
|
|
func (t *PruneProvisionerTransformer) Transform(g *Graph) error {
|
|
for _, v := range g.Vertices() {
|
|
// We only care about the provisioners
|
|
if _, ok := v.(GraphNodeProvisioner); !ok {
|
|
continue
|
|
}
|
|
|
|
// Does anything depend on this? If not, then prune it.
|
|
if s := g.UpEdges(v); s.Len() == 0 {
|
|
g.Remove(v)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func provisionerVertexMap(g *Graph) map[string]dag.Vertex {
|
|
m := make(map[string]dag.Vertex)
|
|
for _, v := range g.Vertices() {
|
|
if pv, ok := v.(GraphNodeProvisioner); ok {
|
|
m[pv.ProvisionerName()] = v
|
|
}
|
|
}
|
|
|
|
return m
|
|
}
|
|
|
|
func closeProvisionerVertexMap(g *Graph) map[string]dag.Vertex {
|
|
m := make(map[string]dag.Vertex)
|
|
for _, v := range g.Vertices() {
|
|
if pv, ok := v.(GraphNodeCloseProvisioner); ok {
|
|
m[pv.CloseProvisionerName()] = v
|
|
}
|
|
}
|
|
|
|
return m
|
|
}
|
|
|
|
type graphNodeCloseProvisioner struct {
|
|
ProvisionerNameValue string
|
|
}
|
|
|
|
func (n *graphNodeCloseProvisioner) Name() string {
|
|
return fmt.Sprintf("provisioner.%s (close)", n.ProvisionerNameValue)
|
|
}
|
|
|
|
// GraphNodeEvalable impl.
|
|
func (n *graphNodeCloseProvisioner) EvalTree() EvalNode {
|
|
return &EvalCloseProvisioner{Name: n.ProvisionerNameValue}
|
|
}
|
|
|
|
func (n *graphNodeCloseProvisioner) CloseProvisionerName() string {
|
|
return n.ProvisionerNameValue
|
|
}
|
|
|
|
// GraphNodeFlattenable impl.
|
|
func (n *graphNodeCloseProvisioner) Flatten(p []string) (dag.Vertex, error) {
|
|
return &graphNodeCloseProvisionerFlat{
|
|
graphNodeCloseProvisioner: n,
|
|
PathValue: p,
|
|
}, nil
|
|
}
|
|
|
|
// Same as graphNodeCloseProvisioner, but for flattening
|
|
type graphNodeCloseProvisionerFlat struct {
|
|
*graphNodeCloseProvisioner
|
|
|
|
PathValue []string
|
|
}
|
|
|
|
func (n *graphNodeCloseProvisionerFlat) Name() string {
|
|
return fmt.Sprintf(
|
|
"%s.%s", modulePrefixStr(n.PathValue), n.graphNodeCloseProvisioner.Name())
|
|
}
|
|
|
|
func (n *graphNodeCloseProvisionerFlat) Path() []string {
|
|
return n.PathValue
|
|
}
|
|
|
|
func (n *graphNodeCloseProvisionerFlat) ProvisionerName() string {
|
|
return fmt.Sprintf(
|
|
"%s.%s", modulePrefixStr(n.PathValue),
|
|
n.graphNodeCloseProvisioner.CloseProvisionerName())
|
|
}
|
|
|
|
type graphNodeMissingProvisioner struct {
|
|
ProvisionerNameValue string
|
|
}
|
|
|
|
func (n *graphNodeMissingProvisioner) Name() string {
|
|
return fmt.Sprintf("provisioner.%s", n.ProvisionerNameValue)
|
|
}
|
|
|
|
// GraphNodeEvalable impl.
|
|
func (n *graphNodeMissingProvisioner) EvalTree() EvalNode {
|
|
return &EvalInitProvisioner{Name: n.ProvisionerNameValue}
|
|
}
|
|
|
|
func (n *graphNodeMissingProvisioner) ProvisionerName() string {
|
|
return n.ProvisionerNameValue
|
|
}
|
|
|
|
// GraphNodeFlattenable impl.
|
|
func (n *graphNodeMissingProvisioner) Flatten(p []string) (dag.Vertex, error) {
|
|
return &graphNodeMissingProvisionerFlat{
|
|
graphNodeMissingProvisioner: n,
|
|
PathValue: p,
|
|
}, nil
|
|
}
|
|
|
|
// Same as graphNodeMissingProvisioner, but for flattening
|
|
type graphNodeMissingProvisionerFlat struct {
|
|
*graphNodeMissingProvisioner
|
|
|
|
PathValue []string
|
|
}
|
|
|
|
func (n *graphNodeMissingProvisionerFlat) Name() string {
|
|
return fmt.Sprintf(
|
|
"%s.%s", modulePrefixStr(n.PathValue), n.graphNodeMissingProvisioner.Name())
|
|
}
|
|
|
|
func (n *graphNodeMissingProvisionerFlat) Path() []string {
|
|
return n.PathValue
|
|
}
|
|
|
|
func (n *graphNodeMissingProvisionerFlat) ProvisionerName() string {
|
|
return fmt.Sprintf(
|
|
"%s.%s", modulePrefixStr(n.PathValue),
|
|
n.graphNodeMissingProvisioner.ProvisionerName())
|
|
}
|