mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-27 09:21:14 -06:00
e7aaf9e39f
* terraforn: refactor EvalRefresh EvalRefresh.Eval(ctx) is now Refresh(evalRefreshReqest, ctx). While none of the inner logic of the function has changed, it now returns a states.ResourceInstanceObject instead of updating a pointer. This is a human-centric change, meant to make the logic flow (in the calling functions) easier to follow. * terraform: refactor EvalReadDataPlan and Apply This is a very minor refactor that removes the (currently) redundant types EvalReadDataPlan and EvalReadDataApply in favor of using EvalReadData with a Plan and Apply functions. This is in effect an aesthetic change; since there is no longer an Eval() abstraction we can rename functions to make their functionality as obvious as possible. * terraform: refactor EvalCheckPlannedChange EvalCheckPlannedChange was only used by NodeApplyableResourceInstance and has been refactored into a method on that type called checkPlannedChange. * terraform: refactor EvalDiff.Eval EvalDiff.Eval is now a method on NodeResourceAbstracted called Plan which takes as a parameter an EvalPlanRequest. Instead of updating pointers it returns a new plan and state. I removed as many redundant fields from the original EvalDiff struct as possible. * terraform: refactor EvalReduceDiff EvalReduceDiff is now reducePlan, a regular function (without a method) that returns a value. * terraform: refactor EvalDiffDestroy EvalDiffDestroy.Eval is now NodeAbstractResourceInstance.PlanDestroy which takes ctx, state and optional DeposedKey and returns a change. I've removed the state return value since it was only ever returning a nil state. * terraform: refactor EvalWriteDiff EvalWriteDiff.Eval is now NodeAbstractResourceInstance.WriteChange. * rename files to something more logical * terrafrom: refresh refactor, continued! I had originally made Refresh a stand-alone function since it was (obnoxiously) called from a graphNodeImportStateSub, but after some (greatly appreciated) prompting in the PR I instead made it a method on the NodeAbstractResourceInstance, in keeping with the other refactored eval nodes, and then built a NodeAbstractResourceInstance inside import. Since I did that I could also remove my duplicated 'writeState' code inside graphNodeImportStateSub and use n.writeResourceInstanceState, so double thanks! * unexport eval methods * re-refactor Plan, it made more sense on NodeAbstractResourceInstance. Sorry * Remove uninformative `Eval`s from EvalReadData, consolidate to a single file, and rename file to match function names. * manual rebase
284 lines
10 KiB
Go
284 lines
10 KiB
Go
package terraform
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
|
|
"github.com/hashicorp/terraform/addrs"
|
|
"github.com/hashicorp/terraform/dag"
|
|
"github.com/hashicorp/terraform/plans"
|
|
"github.com/hashicorp/terraform/states"
|
|
"github.com/hashicorp/terraform/tfdiags"
|
|
)
|
|
|
|
// ConcreteResourceInstanceDeposedNodeFunc is a callback type used to convert
|
|
// an abstract resource instance to a concrete one of some type that has
|
|
// an associated deposed object key.
|
|
type ConcreteResourceInstanceDeposedNodeFunc func(*NodeAbstractResourceInstance, states.DeposedKey) dag.Vertex
|
|
|
|
type GraphNodeDeposedResourceInstanceObject interface {
|
|
DeposedInstanceObjectKey() states.DeposedKey
|
|
}
|
|
|
|
// NodePlanDeposedResourceInstanceObject represents deposed resource
|
|
// instance objects during plan. These are distinct from the primary object
|
|
// for each resource instance since the only valid operation to do with them
|
|
// is to destroy them.
|
|
//
|
|
// This node type is also used during the refresh walk to ensure that the
|
|
// record of a deposed object is up-to-date before we plan to destroy it.
|
|
type NodePlanDeposedResourceInstanceObject struct {
|
|
*NodeAbstractResourceInstance
|
|
DeposedKey states.DeposedKey
|
|
}
|
|
|
|
var (
|
|
_ GraphNodeDeposedResourceInstanceObject = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeConfigResource = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeResourceInstance = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeReferenceable = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeReferencer = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeExecutable = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeProviderConsumer = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeProvisionerConsumer = (*NodePlanDeposedResourceInstanceObject)(nil)
|
|
)
|
|
|
|
func (n *NodePlanDeposedResourceInstanceObject) Name() string {
|
|
return fmt.Sprintf("%s (deposed %s)", n.ResourceInstanceAddr().String(), n.DeposedKey)
|
|
}
|
|
|
|
func (n *NodePlanDeposedResourceInstanceObject) DeposedInstanceObjectKey() states.DeposedKey {
|
|
return n.DeposedKey
|
|
}
|
|
|
|
// GraphNodeReferenceable implementation, overriding the one from NodeAbstractResourceInstance
|
|
func (n *NodePlanDeposedResourceInstanceObject) ReferenceableAddrs() []addrs.Referenceable {
|
|
// Deposed objects don't participate in references.
|
|
return nil
|
|
}
|
|
|
|
// GraphNodeReferencer implementation, overriding the one from NodeAbstractResourceInstance
|
|
func (n *NodePlanDeposedResourceInstanceObject) References() []*addrs.Reference {
|
|
// We don't evaluate configuration for deposed objects, so they effectively
|
|
// make no references.
|
|
return nil
|
|
}
|
|
|
|
// GraphNodeEvalable impl.
|
|
func (n *NodePlanDeposedResourceInstanceObject) Execute(ctx EvalContext, op walkOperation) (diags tfdiags.Diagnostics) {
|
|
// Read the state for the deposed resource instance
|
|
state, err := n.ReadResourceInstanceStateDeposed(ctx, n.Addr, n.DeposedKey)
|
|
diags = diags.Append(err)
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
change, destroyPlanDiags := n.planDestroy(ctx, state, n.DeposedKey)
|
|
diags = diags.Append(destroyPlanDiags)
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
diags = diags.Append(n.writeChange(ctx, change, n.DeposedKey))
|
|
return diags
|
|
}
|
|
|
|
// NodeDestroyDeposedResourceInstanceObject represents deposed resource
|
|
// instance objects during apply. Nodes of this type are inserted by
|
|
// DiffTransformer when the planned changeset contains "delete" changes for
|
|
// deposed instance objects, and its only supported operation is to destroy
|
|
// and then forget the associated object.
|
|
type NodeDestroyDeposedResourceInstanceObject struct {
|
|
*NodeAbstractResourceInstance
|
|
DeposedKey states.DeposedKey
|
|
}
|
|
|
|
var (
|
|
_ GraphNodeDeposedResourceInstanceObject = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeConfigResource = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeResourceInstance = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeDestroyer = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeDestroyerCBD = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeReferenceable = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeReferencer = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeExecutable = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeProviderConsumer = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
_ GraphNodeProvisionerConsumer = (*NodeDestroyDeposedResourceInstanceObject)(nil)
|
|
)
|
|
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) Name() string {
|
|
return fmt.Sprintf("%s (destroy deposed %s)", n.ResourceInstanceAddr(), n.DeposedKey)
|
|
}
|
|
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) DeposedInstanceObjectKey() states.DeposedKey {
|
|
return n.DeposedKey
|
|
}
|
|
|
|
// GraphNodeReferenceable implementation, overriding the one from NodeAbstractResourceInstance
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) ReferenceableAddrs() []addrs.Referenceable {
|
|
// Deposed objects don't participate in references.
|
|
return nil
|
|
}
|
|
|
|
// GraphNodeReferencer implementation, overriding the one from NodeAbstractResourceInstance
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) References() []*addrs.Reference {
|
|
// We don't evaluate configuration for deposed objects, so they effectively
|
|
// make no references.
|
|
return nil
|
|
}
|
|
|
|
// GraphNodeDestroyer
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) DestroyAddr() *addrs.AbsResourceInstance {
|
|
addr := n.ResourceInstanceAddr()
|
|
return &addr
|
|
}
|
|
|
|
// GraphNodeDestroyerCBD
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) CreateBeforeDestroy() bool {
|
|
// A deposed instance is always CreateBeforeDestroy by definition, since
|
|
// we use deposed only to handle create-before-destroy.
|
|
return true
|
|
}
|
|
|
|
// GraphNodeDestroyerCBD
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) ModifyCreateBeforeDestroy(v bool) error {
|
|
if !v {
|
|
// Should never happen: deposed instances are _always_ create_before_destroy.
|
|
return fmt.Errorf("can't deactivate create_before_destroy for a deposed instance")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GraphNodeExecutable impl.
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) Execute(ctx EvalContext, op walkOperation) (diags tfdiags.Diagnostics) {
|
|
addr := n.ResourceInstanceAddr().Resource
|
|
var change *plans.ResourceInstanceChange
|
|
var applyError error
|
|
|
|
provider, providerSchema, err := GetProvider(ctx, n.ResolvedProvider)
|
|
diags = diags.Append(err)
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
// Read the state for the deposed resource instance
|
|
state, err := n.ReadResourceInstanceStateDeposed(ctx, n.Addr, n.DeposedKey)
|
|
diags = diags.Append(err)
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
change, destroyPlanDiags := n.planDestroy(ctx, state, n.DeposedKey)
|
|
diags = diags.Append(destroyPlanDiags)
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
// Call pre-apply hook
|
|
diags = diags.Append(n.PreApplyHook(ctx, change))
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
apply := &EvalApply{
|
|
Addr: addr,
|
|
Config: nil, // No configuration because we are destroying
|
|
State: &state,
|
|
Change: &change,
|
|
Provider: &provider,
|
|
ProviderAddr: n.ResolvedProvider,
|
|
ProviderSchema: &providerSchema,
|
|
Output: &state,
|
|
Error: &applyError,
|
|
}
|
|
diags = diags.Append(apply.Eval(ctx))
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
// Always write the resource back to the state deposed. If it
|
|
// was successfully destroyed it will be pruned. If it was not, it will
|
|
// be caught on the next run.
|
|
diags = diags.Append(n.writeResourceInstanceState(ctx, state))
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
diags = diags.Append(n.postApplyHook(ctx, state, &applyError))
|
|
if diags.HasErrors() {
|
|
return diags
|
|
}
|
|
|
|
if applyError != nil {
|
|
diags = diags.Append(applyError)
|
|
return diags
|
|
}
|
|
diags = diags.Append(UpdateStateHook(ctx))
|
|
return diags
|
|
}
|
|
|
|
// GraphNodeDeposer is an optional interface implemented by graph nodes that
|
|
// might create a single new deposed object for a specific associated resource
|
|
// instance, allowing a caller to optionally pre-allocate a DeposedKey for
|
|
// it.
|
|
type GraphNodeDeposer interface {
|
|
// SetPreallocatedDeposedKey will be called during graph construction
|
|
// if a particular node must use a pre-allocated deposed key if/when it
|
|
// "deposes" the current object of its associated resource instance.
|
|
SetPreallocatedDeposedKey(key states.DeposedKey)
|
|
}
|
|
|
|
// graphNodeDeposer is an embeddable implementation of GraphNodeDeposer.
|
|
// Embed it in a node type to get automatic support for it, and then access
|
|
// the field PreallocatedDeposedKey to access any pre-allocated key.
|
|
type graphNodeDeposer struct {
|
|
PreallocatedDeposedKey states.DeposedKey
|
|
}
|
|
|
|
func (n *graphNodeDeposer) SetPreallocatedDeposedKey(key states.DeposedKey) {
|
|
n.PreallocatedDeposedKey = key
|
|
}
|
|
|
|
func (n *NodeDestroyDeposedResourceInstanceObject) writeResourceInstanceState(ctx EvalContext, obj *states.ResourceInstanceObject) error {
|
|
absAddr := n.Addr
|
|
key := n.DeposedKey
|
|
state := ctx.State()
|
|
|
|
if key == states.NotDeposed {
|
|
// should never happen
|
|
return fmt.Errorf("can't save deposed object for %s without a deposed key; this is a bug in Terraform that should be reported", absAddr)
|
|
}
|
|
|
|
if obj == nil {
|
|
// No need to encode anything: we'll just write it directly.
|
|
state.SetResourceInstanceDeposed(absAddr, key, nil, n.ResolvedProvider)
|
|
log.Printf("[TRACE] writeResourceInstanceStateDeposed: removing state object for %s deposed %s", absAddr, key)
|
|
return nil
|
|
}
|
|
|
|
_, providerSchema, err := GetProvider(ctx, n.ResolvedProvider)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if providerSchema == nil {
|
|
// Should never happen, unless our state object is nil
|
|
panic("writeResourceInstanceStateDeposed used with no ProviderSchema object")
|
|
}
|
|
|
|
schema, currentVersion := providerSchema.SchemaForResourceAddr(absAddr.ContainingResource().Resource)
|
|
if schema == nil {
|
|
// It shouldn't be possible to get this far in any real scenario
|
|
// without a schema, but we might end up here in contrived tests that
|
|
// fail to set up their world properly.
|
|
return fmt.Errorf("failed to encode %s in state: no resource type schema available", absAddr)
|
|
}
|
|
src, err := obj.Encode(schema.ImpliedType(), currentVersion)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to encode %s in state: %s", absAddr, err)
|
|
}
|
|
|
|
log.Printf("[TRACE] writeResourceInstanceStateDeposed: writing state object for %s deposed %s", absAddr, key)
|
|
state.SetResourceInstanceDeposed(absAddr, key, src, n.ResolvedProvider)
|
|
return nil
|
|
}
|