Fixed -Wabi warnings in headers (#18796)

* Fixed a lot of -Wabi warnings

* Added dtors for frontend conversion extensions for RTTI
This commit is contained in:
Ilya Lavrenov 2023-07-26 15:15:45 +04:00 committed by GitHub
parent 05247c9a86
commit 5c2cda40f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 36 additions and 4 deletions

View File

@ -56,6 +56,9 @@ using param_callback_map = std::map<ov::DiscreteTypeInfo, param_callback>;
/// \ingroup ov_pass_cpp_api
class OPENVINO_API PassConfig {
public:
/// \brief Default constructor
PassConfig();
/// \brief Disable transformation by its type_info
/// \param type_info Transformation type_info
void disable(const DiscreteTypeInfo& type_info);
@ -157,9 +160,7 @@ public:
void add_disabled_passes(const PassConfig& rhs);
private:
param_callback m_callback = [](const std::shared_ptr<const ::ov::Node>&) {
return false;
};
param_callback m_callback;
param_callback_map m_callback_map;
std::unordered_set<DiscreteTypeInfo> m_disabled;
std::unordered_set<DiscreteTypeInfo> m_enabled;

View File

@ -4,6 +4,12 @@
#include "openvino/pass/pass_config.hpp"
ov::pass::PassConfig::PassConfig() {
m_callback = [](const std::shared_ptr<const ::ov::Node>&) {
return false;
};
}
ov::pass::param_callback ov::pass::PassConfig::get_callback(const DiscreteTypeInfo& type_info) const {
const auto& it = m_callback_map.find(type_info);
if (it != m_callback_map.end()) {

View File

@ -26,6 +26,8 @@ public:
m_domain{domain},
m_converter(converter) {}
~ConversionExtension() override;
const std::string& get_domain() const {
return m_domain;
}

View File

@ -0,0 +1,7 @@
// Copyright (C) 2018-2023 Intel Corporation
// SPDX-License-Identifier: Apache-2.0
//
#include "openvino/frontend/onnx/extension/conversion.hpp"
ov::frontend::onnx::ConversionExtension::~ConversionExtension() = default;

View File

@ -23,6 +23,8 @@ public:
: ConversionExtensionBase(op_type),
m_converter(converter) {}
~ConversionExtension() override;
const ov::frontend::CreatorFunctionNamed& get_converter() const {
return m_converter;
}

View File

@ -0,0 +1,7 @@
// Copyright (C) 2018-2023 Intel Corporation
// SPDX-License-Identifier: Apache-2.0
//
#include "openvino/frontend/paddle/extension/conversion.hpp"
ov::frontend::paddle::ConversionExtension::~ConversionExtension() = default;

View File

@ -27,7 +27,7 @@ public:
return m_converter;
}
~ConversionExtension() override = default;
~ConversionExtension() override;
private:
ov::frontend::CreatorFunction m_converter;

View File

@ -0,0 +1,7 @@
// Copyright (C) 2018-2023 Intel Corporation
// SPDX-License-Identifier: Apache-2.0
//
#include "openvino/frontend/pytorch/extension/conversion.hpp"
ov::frontend::pytorch::ConversionExtension::~ConversionExtension() = default;