fix not initialized value - reported by klocwork (#4998)

Co-authored-by: Patryk Elszkowski <patryk.elszkowki@intel.com>
This commit is contained in:
Patryk Elszkowski 2021-03-30 16:31:45 +02:00 committed by GitHub
parent 0c38a9e4d3
commit 61f7791b16
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -82,11 +82,13 @@ bool getParameters(const pugi::xml_node& node, const std::string& name, std::vec
} }
template <class T> template <class T>
bool stringToType(const std::string& valStr, T& value) { T stringToType(const std::string& valStr) {
T ret{0};
std::istringstream ss(valStr); std::istringstream ss(valStr);
if (ss.eof()) return false; if (!ss.eof()) {
ss >> value; ss >> ret;
return !ss.fail(); }
return ret;
} }
class XmlDeserializer : public ngraph::AttributeVisitor { class XmlDeserializer : public ngraph::AttributeVisitor {
@ -124,16 +126,12 @@ public:
void on_adapter(const std::string& name, ngraph::ValueAccessor<double>& adapter) override { void on_adapter(const std::string& name, ngraph::ValueAccessor<double>& adapter) override {
std::string val; std::string val;
if (!getStrAttribute(node.child("data"), name, val)) return; if (!getStrAttribute(node.child("data"), name, val)) return;
double value; adapter.set(stringToType<double>(val));
stringToType<double>(val, value);
adapter.set(value);
} }
void on_adapter(const std::string& name, ngraph::ValueAccessor<int64_t>& adapter) override { void on_adapter(const std::string& name, ngraph::ValueAccessor<int64_t>& adapter) override {
std::string val; std::string val;
if (!getStrAttribute(node.child("data"), name, val)) return; if (!getStrAttribute(node.child("data"), name, val)) return;
int64_t value; adapter.set(stringToType<int64_t>(val));
stringToType<int64_t>(val, value);
adapter.set(value);
} }
void on_adapter( void on_adapter(