IntenseWebs/openvino
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Slice shape infer with dynamic dimension, zero start and negative stop (#13157)

Browse Source
This commit is contained in:
Mateusz Tabaka 2022-09-28 12:44:56 +02:00 committed by GitHub
parent f76ab476ff
commit 6717a0c112
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/src/op/slice.cpp
View File

@ -305,7 +305,7 @@ PartialShape op::v8::Slice::calculate_output_shape(const std::vector<int64_t>& s
if (is_max_int(get_input_element_type(2), stop) || is_max_int(get_input_element_type(1), start)) {
output_shape[norm_axis] = Dimension(-1);
continue;
} else if ((step < 0 && start < 0 && stop > 0) || (step > 0 && stop < 0 && start > 0)) {
} else if ((step < 0 && start < 0 && stop > 0) || (step > 0 && stop < 0 && start >= 0)) {
output_shape[norm_axis] = Dimension(-1);
continue;
} else if (step < 0 && start > 0 && stop < 0) {

18
src/core/tests/type_prop/slice.cpp
View File

@ -762,6 +762,24 @@ TEST(type_prop, slice_v8_basic_const_inputs_MAX_MIN_32_no_upper_bounds_neg_step)
EXPECT_EQ(op->get_output_partial_shape(0), expected_out_shape);
}
TEST(type_prop, slice_v8_dynamic_dim_zero_start_negative_stop) {
PartialShape data_shape{Dimension(-1)};
PartialShape expected_out_shape{Dimension(-1)};
std::vector<int32_t> start_val{0};
std::vector<int32_t> stop_val{-2};
std::vector<int32_t> step_val{1};
std::vector<int32_t> axes_val{0};
element::Type_t et = element::i32;
std::vector<std::vector<int32_t>> input_vals{start_val, stop_val, step_val, axes_val};
const auto op = make_slice_op_const_inputs(input_vals, data_shape, et);
EXPECT_EQ(op->get_element_type(), et);
EXPECT_EQ(op->get_output_partial_shape(0), expected_out_shape);
}
TEST(type_prop, slice_v8_duplicated_axes) {
PartialShape data_shape{100, 100, 100, 100};
PartialShape expected_out_shape{100, 100, 100, 100};