From 6b57360c55bd1fad0b6072d85bfc21b644f47b81 Mon Sep 17 00:00:00 2001 From: Bo Liu Date: Wed, 30 Aug 2023 16:08:08 +0800 Subject: [PATCH] Fix warnings for Paddle Frontend (#19476) * Fixed warnings for Paddle Frontend * fix CI linux-gnu-9 build fail issue --- .../paddle/include/openvino/frontend/paddle/decoder.hpp | 3 +++ src/frontends/paddle/src/CMakeLists.txt | 6 ------ src/frontends/paddle/src/decoder.cpp | 9 +++++++++ src/frontends/paddle/src/op/generate_proposals_v2.cpp | 6 +++--- src/frontends/paddle/src/op/group_norm.cpp | 2 +- 5 files changed, 16 insertions(+), 10 deletions(-) create mode 100644 src/frontends/paddle/src/decoder.cpp diff --git a/src/frontends/paddle/include/openvino/frontend/paddle/decoder.hpp b/src/frontends/paddle/include/openvino/frontend/paddle/decoder.hpp index fdba0207499..1934352e3c0 100644 --- a/src/frontends/paddle/include/openvino/frontend/paddle/decoder.hpp +++ b/src/frontends/paddle/include/openvino/frontend/paddle/decoder.hpp @@ -55,6 +55,9 @@ public: /// \brief Get the type of the operation virtual std::string get_op_type() const = 0; + + /// \brief Destructor + virtual ~DecoderBase(); }; } // namespace paddle } // namespace frontend diff --git a/src/frontends/paddle/src/CMakeLists.txt b/src/frontends/paddle/src/CMakeLists.txt index ec03bc7b4c7..ade95082b73 100644 --- a/src/frontends/paddle/src/CMakeLists.txt +++ b/src/frontends/paddle/src/CMakeLists.txt @@ -2,12 +2,6 @@ # SPDX-License-Identifier: Apache-2.0 # -if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") - ie_add_compiler_flags(/wd4305) -elseif(OV_COMPILER_IS_CLANG) - ie_add_compiler_flags(-Wno-delete-non-abstract-non-virtual-dtor) -endif() - ov_add_frontend(NAME paddle LINKABLE_FRONTEND PROTOBUF_LITE diff --git a/src/frontends/paddle/src/decoder.cpp b/src/frontends/paddle/src/decoder.cpp new file mode 100644 index 00000000000..78e5c7cb56c --- /dev/null +++ b/src/frontends/paddle/src/decoder.cpp @@ -0,0 +1,9 @@ +// Copyright (C) 2018-2023 Intel Corporation +// SPDX-License-Identifier: Apache-2.0 +// + +#include "openvino/frontend/paddle/decoder.hpp" + +using namespace ov::frontend::paddle; + +DecoderBase::~DecoderBase() = default; diff --git a/src/frontends/paddle/src/op/generate_proposals_v2.cpp b/src/frontends/paddle/src/op/generate_proposals_v2.cpp index 551b04222d4..2df436357bb 100644 --- a/src/frontends/paddle/src/op/generate_proposals_v2.cpp +++ b/src/frontends/paddle/src/op/generate_proposals_v2.cpp @@ -23,12 +23,12 @@ NamedOutputs generate_proposals_v2(const NodeContext& node) { // attribute ov::op::v9::GenerateProposals::Attributes attrs; - float min_size = node.get_attribute("min_size", 0.1); + float min_size = node.get_attribute("min_size", 0.1f); attrs.min_size = min_size < 1.0f ? 1.0f : min_size; - attrs.nms_threshold = node.get_attribute("nms_thresh", 0.5); + attrs.nms_threshold = node.get_attribute("nms_thresh", 0.5f); attrs.pre_nms_count = node.get_attribute("pre_nms_topN", 6000); attrs.post_nms_count = node.get_attribute("post_nms_topN", 1000); - attrs.nms_eta = node.get_attribute("eta", 1.0); + attrs.nms_eta = node.get_attribute("eta", 1.0f); PADDLE_OP_CHECK(node, (attrs.nms_eta == 1.0), "Only support case of eta == 1.0 currently"); attrs.normalized = !node.get_attribute("pixel_offset", true); diff --git a/src/frontends/paddle/src/op/group_norm.cpp b/src/frontends/paddle/src/op/group_norm.cpp index 891b6c79f0f..60b8b99ffe9 100644 --- a/src/frontends/paddle/src/op/group_norm.cpp +++ b/src/frontends/paddle/src/op/group_norm.cpp @@ -25,7 +25,7 @@ Output reshape_channel_shaped_node_to_nchw(const Output& nod NamedOutputs group_norm(const NodeContext& node) { auto data = node.get_input("X"); size_t num_groups = static_cast(node.get_attribute("groups")); - auto epsilon = node.get_attribute("epsilon", 1e-5); + auto epsilon = node.get_attribute("epsilon", 1e-5f); auto data_layout = node.get_attribute("data_layout", "NCHW"); const auto& pshape = data.get_partial_shape();