IntenseWebs/openvino
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ncc build fixes (#10367)

Browse Source 
* fix .ncc_style target names

it was breaking configure on system with libclang-12-dev, clang-12,
ninja and cmake 3.17+(ninja complains about duplicate
target). with lower cmake version configure succeeds, but build exits
immediately with error. by replacing ninja with make error becomes
warning(it's still significant, make just skips duplicate rules, i.e.
doesn't check style of some source files, rule duplication is genuine
bug). without libclang-12-dev and clang-12 ENABLE_NCC_STYLE is OFF and
bug is not triggered

* silence uninitialized warning in core_integration

probably it was always initialized before use, but compiler wasn't made
aware of it

* fix function spelling to unbreak code style checks in benchmark_app

* include <thread> for std::this_thread

existing code was relying on namespace pollution by old libstdc++

* replace is_pod with is_standard_layout && is_trivial

is_pod is deprecated, it breaks build on current gcc

Co-authored-by: Serhii Pavlovskyi <spavlovskyi@lohika.com>
Co-authored-by: Ilya Churaev <ilya.churaev@intel.com>
This commit is contained in:
Serhii Pavlovskyi
2022-03-09 12:42:06 +02:00
committed by GitHub
parent d9976332b0
commit 948347f3dd
5 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
samples/cpp/benchmark_app/main.cpp
View File

@@ -32,7 +32,7 @@
static const size_t progressBarDefaultTotalCount = 1000;
bool ParseAndCheckCommandLine(int argc, char* argv[]) {
bool parse_and_check_command_line(int argc, char* argv[]) {
// ---------------------------Parsing and validating input
// arguments--------------------------------------
slog::info << "Parsing input parameters" << slog::endl;
@@ -151,7 +151,7 @@ int main(int argc, char* argv[]) {
// -------------------------------------------------
next_step();
if (!ParseAndCheckCommandLine(argc, argv)) {
if (!parse_and_check_command_line(argc, argv)) {
return 0;
}