Change visit_attributes default behavior, operation by default supports visit attributes (#14470)

This commit is contained in:
Ilya Churaev 2022-12-08 03:35:44 +04:00 committed by GitHub
parent 5651488e06
commit f91d3d1d04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 5 additions and 24 deletions

View File

@ -194,9 +194,7 @@ public:
virtual ~Node();
virtual bool visit_attributes(AttributeVisitor&) {
return false;
}
virtual bool visit_attributes(AttributeVisitor&);
/// \returns the autobroadcasr spec
virtual const ov::op::AutoBroadcastSpec& get_autob() const;

View File

@ -19,9 +19,6 @@ public:
OPENVINO_OP("Abs", "opset1", util::UnaryElementwiseArithmetic);
/// \brief Constructs an absolute value operation.
Abs() = default;
bool visit_attributes(AttributeVisitor&) override {
return true;
}
/// \brief Constructs an absolute value operation.
///
/// \param arg Output that produces the input tensor.<br>

View File

@ -27,9 +27,6 @@ public:
/// Output `[d1, ...]`
///
Acos(const Output<Node>& arg);
bool visit_attributes(AttributeVisitor&) override {
return true;
}
std::shared_ptr<Node> clone_with_new_inputs(const OutputVector& new_args) const override;
OPENVINO_SUPPRESS_DEPRECATED_START
bool evaluate(const HostTensorVector& outputs, const HostTensorVector& inputs) const override;

View File

@ -30,9 +30,6 @@ public:
Acosh(const Output<Node>& arg);
std::shared_ptr<Node> clone_with_new_inputs(const OutputVector& new_args) const override;
bool visit_attributes(AttributeVisitor&) override {
return true;
}
OPENVINO_SUPPRESS_DEPRECATED_START
bool evaluate(const HostTensorVector& outputs, const HostTensorVector& inputs) const override;
OPENVINO_SUPPRESS_DEPRECATED_END

View File

@ -30,7 +30,6 @@ public:
AdaptiveAvgPool(const Output<Node>& data, const Output<Node>& output_shape);
void validate_and_infer_types() override;
bool visit_attributes(AttributeVisitor& visitor) override;
std::shared_ptr<Node> clone_with_new_inputs(const OutputVector& new_args) const override;
};

View File

@ -21,7 +21,6 @@ public:
/// \param arg Node that produces the input tensor.
LogicalNot(const Output<Node>& arg);
bool visit_attributes(AttributeVisitor& visitor) override;
void validate_and_infer_types() override;
std::shared_ptr<Node> clone_with_new_inputs(const OutputVector& new_args) const override;

View File

@ -844,6 +844,10 @@ bool ov::Node::is_const_fold_disabled() const {
return ov::pass::constant_folding_is_disabled(this);
}
bool ov::Node::visit_attributes(AttributeVisitor&) {
return true;
}
namespace ov {
AttributeAdapter<std::shared_ptr<Node>>::AttributeAdapter(std::shared_ptr<Node>& value) : m_ref(value) {}

View File

@ -17,11 +17,6 @@ op::v8::AdaptiveAvgPool::AdaptiveAvgPool(const Output<Node>& data, const Output<
constructor_validate_and_infer_types();
}
bool op::v8::AdaptiveAvgPool::visit_attributes(AttributeVisitor& visitor) {
OV_OP_SCOPE(v8_AdaptiveAvgPool_visit_attributes);
return true;
}
void op::v8::AdaptiveAvgPool::validate_and_infer_types() {
OV_OP_SCOPE(v8_AdaptiveAvgPool_validate_and_infer_types);

View File

@ -17,11 +17,6 @@ op::v1::LogicalNot::LogicalNot(const Output<Node>& arg) : Op({arg}) {
constructor_validate_and_infer_types();
}
bool ngraph::op::v1::LogicalNot::visit_attributes(AttributeVisitor& visitor) {
OV_OP_SCOPE(v1_LogicalNot_visit_attributes);
return true;
}
void op::v1::LogicalNot::validate_and_infer_types() {
OV_OP_SCOPE(v1_LogicalNot_validate_and_infer_types);
const auto& element_type = get_input_element_type(0);