IntenseWebs/openvino
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the potential unlimited mem allocation problem (#3347)

Browse Source
This commit is contained in:
Tomasz Dołbniak
2020-11-25 15:41:25 +01:00
committed by GitHub
parent 1d68caf96f
commit fd532c2611
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
inference-engine/src/readers/onnx_reader/onnx_model_validator.cpp
View File

@@ -89,13 +89,16 @@ namespace onnx {
uint32_t decode_varint(std::istream& model) { uint32_t decode_varint(std::istream& model) {
std::vector<char> bytes; std::vector<char> bytes;
bytes.reserve(4); // max 4 bytes for a single value because this function returns a 32-bit long decoded varint
const size_t MAX_VARINT_BYTES = 4u;
// optimization to avoid allocations during push_back calls
bytes.reserve(MAX_VARINT_BYTES);
char key_component = 0; char key_component = 0;
model.get(key_component); model.get(key_component);
// keep reading all bytes from the stream which have the MSB on // keep reading all bytes from the stream which have the MSB on
while (key_component & 0x80) { while (key_component & 0x80 && bytes.size() < MAX_VARINT_BYTES) {
// drop the most significant bit // drop the most significant bit
const char component = key_component & ~0x80; const char component = key_component & ~0x80;
bytes.push_back(component); bytes.push_back(component);