2018-03-19 05:58:12 -05:00
|
|
|
##########################################################################
|
|
|
|
#
|
|
|
|
# pgAdmin 4 - PostgreSQL Tools
|
|
|
|
#
|
2019-01-02 04:24:12 -06:00
|
|
|
# Copyright (C) 2013 - 2019, The pgAdmin Development Team
|
2018-03-19 05:58:12 -05:00
|
|
|
# This software is released under the PostgreSQL Licence
|
|
|
|
#
|
|
|
|
##########################################################################
|
|
|
|
|
2018-06-25 08:41:07 -05:00
|
|
|
from __future__ import print_function
|
2018-03-19 05:58:12 -05:00
|
|
|
import os
|
2018-05-15 09:10:11 -05:00
|
|
|
import time
|
2018-06-25 08:41:07 -05:00
|
|
|
import sys
|
2018-08-21 07:09:36 -05:00
|
|
|
|
2018-03-19 05:58:12 -05:00
|
|
|
from selenium.webdriver.common.keys import Keys
|
|
|
|
from selenium.webdriver.support.ui import WebDriverWait
|
|
|
|
from selenium.webdriver.common.by import By
|
|
|
|
from selenium.webdriver.support import expected_conditions as EC
|
|
|
|
from regression.feature_utils.base_feature_test import BaseFeatureTest
|
2019-03-21 07:04:37 -05:00
|
|
|
from .locators import QueryToolLocatorsCss
|
2018-03-19 05:58:12 -05:00
|
|
|
|
|
|
|
|
|
|
|
class CheckFileManagerFeatureTest(BaseFeatureTest):
|
|
|
|
"""Tests to check file manager for XSS."""
|
|
|
|
|
|
|
|
scenarios = [
|
2018-06-25 08:41:07 -05:00
|
|
|
("File manager feature test",
|
2018-03-19 05:58:12 -05:00
|
|
|
dict())
|
|
|
|
]
|
|
|
|
|
|
|
|
def before(self):
|
2018-08-21 07:09:36 -05:00
|
|
|
if os.name == 'nt':
|
|
|
|
self.skipTest("This test is skipped for Windows. As Windows "
|
|
|
|
"does not allow the '<' and '>' character while "
|
|
|
|
"specifying the file name.")
|
|
|
|
|
2018-03-19 05:58:12 -05:00
|
|
|
self.page.add_server(self.server)
|
|
|
|
self.wait = WebDriverWait(self.page.driver, 10)
|
|
|
|
self.XSS_FILE = '/tmp/<img src=x onmouseover=alert("1")>.sql'
|
|
|
|
# Remove any previous file
|
|
|
|
if os.path.isfile(self.XSS_FILE):
|
|
|
|
os.remove(self.XSS_FILE)
|
|
|
|
|
|
|
|
def after(self):
|
2019-03-21 07:04:37 -05:00
|
|
|
self.page.close_query_tool(False)
|
2018-03-19 05:58:12 -05:00
|
|
|
self.page.remove_server(self.server)
|
|
|
|
|
|
|
|
def runTest(self):
|
2018-06-25 08:41:07 -05:00
|
|
|
print("Tests to check if File manager is vulnerable to XSS... ",
|
|
|
|
file=sys.stderr, end="")
|
2018-03-19 05:58:12 -05:00
|
|
|
self._navigate_to_query_tool()
|
|
|
|
self.page.fill_codemirror_area_with("SELECT 1;")
|
|
|
|
self._create_new_file()
|
|
|
|
self._open_file_manager_and_check_xss_file()
|
2018-06-25 08:41:07 -05:00
|
|
|
print("OK.", file=sys.stderr)
|
|
|
|
|
|
|
|
print("File manager sorting of data", file=sys.stderr)
|
|
|
|
self._check_file_sorting()
|
|
|
|
print("OK.", file=sys.stderr)
|
2018-03-19 05:58:12 -05:00
|
|
|
|
|
|
|
def _navigate_to_query_tool(self):
|
|
|
|
self.page.toggle_open_tree_item(self.server['name'])
|
|
|
|
self.page.toggle_open_tree_item('Databases')
|
2018-08-21 07:09:36 -05:00
|
|
|
self.page.toggle_open_tree_item(self.test_db)
|
2018-03-19 05:58:12 -05:00
|
|
|
self.page.open_query_tool()
|
|
|
|
|
|
|
|
def _create_new_file(self):
|
2019-03-21 07:04:37 -05:00
|
|
|
self.page.find_by_css_selector(QueryToolLocatorsCss.btn_save).click()
|
2018-03-19 05:58:12 -05:00
|
|
|
# Set the XSS value in input
|
2019-03-21 07:04:37 -05:00
|
|
|
self.page.find_by_css_selector('.change_file_types')
|
2019-05-23 03:31:52 -05:00
|
|
|
self.page.fill_input_by_css_selector("input#file-input-path",
|
|
|
|
self.XSS_FILE)
|
2018-03-19 05:58:12 -05:00
|
|
|
# Save the file
|
Improvement in the look and feel of the whole application
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 05:44:55 -06:00
|
|
|
self.page.click_modal('Create')
|
2018-03-19 05:58:12 -05:00
|
|
|
self.page.wait_for_query_tool_loading_indicator_to_disappear()
|
|
|
|
|
|
|
|
def _open_file_manager_and_check_xss_file(self):
|
|
|
|
self.page.find_by_id("btn-load-file").click()
|
Improvement in the look and feel of the whole application
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 05:44:55 -06:00
|
|
|
self.page.find_by_css_selector('.change_file_types')
|
2019-03-21 07:04:37 -05:00
|
|
|
self.page.fill_input_by_css_selector("#file-input-path", "/tmp/",
|
|
|
|
key_after_input=Keys.RETURN)
|
2018-05-15 09:10:11 -05:00
|
|
|
|
|
|
|
if self.page.driver.capabilities['browserName'] == 'firefox':
|
|
|
|
table = self.page.wait_for_element_to_reload(
|
|
|
|
lambda driver:
|
|
|
|
driver.find_element_by_css_selector("table#contents")
|
|
|
|
)
|
|
|
|
else:
|
|
|
|
table = self.page.driver \
|
|
|
|
.find_element_by_css_selector("table#contents")
|
|
|
|
|
|
|
|
contents = table.get_attribute('innerHTML')
|
|
|
|
|
2018-03-19 05:58:12 -05:00
|
|
|
self.page.click_modal('Cancel')
|
|
|
|
self.page.wait_for_query_tool_loading_indicator_to_disappear()
|
|
|
|
self._check_escaped_characters(
|
|
|
|
contents,
|
|
|
|
'<img src=x onmouseover=alert("1")>.sql',
|
|
|
|
'File manager'
|
|
|
|
)
|
|
|
|
|
|
|
|
def _check_escaped_characters(self, source_code, string_to_find, source):
|
|
|
|
# For XSS we need to search against element's html code
|
|
|
|
assert source_code.find(
|
|
|
|
string_to_find
|
|
|
|
) != -1, "{0} might be vulnerable to XSS ".format(source)
|
2018-06-25 08:41:07 -05:00
|
|
|
|
|
|
|
def _check_file_sorting(self):
|
|
|
|
self.page.find_by_id("btn-load-file").click()
|
Improvement in the look and feel of the whole application
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 05:44:55 -06:00
|
|
|
self.page.find_by_css_selector("#contents th[data-column='0']")
|
2018-06-25 08:41:07 -05:00
|
|
|
|
|
|
|
# Added time.sleep so that the element to be clicked.
|
|
|
|
time.sleep(0.05)
|
2018-08-21 07:09:36 -05:00
|
|
|
|
|
|
|
# Intermittently facing issue on first click it is not successful
|
|
|
|
# so tried couple of times.
|
|
|
|
iteration = 0
|
|
|
|
success = False
|
|
|
|
while not success and iteration < 4:
|
|
|
|
# Check for sort Ascending
|
|
|
|
try:
|
2019-06-03 10:33:32 -05:00
|
|
|
self.page.find_by_xpath("//th[@data-column='0']"
|
|
|
|
"/div/span[text()='Name']").click()
|
2018-08-21 07:09:36 -05:00
|
|
|
self.wait.until(
|
|
|
|
EC.presence_of_element_located((
|
|
|
|
By.CSS_SELECTOR,
|
|
|
|
"#contents th[data-column='0'].tablesorter-headerAsc")
|
|
|
|
))
|
|
|
|
success = True
|
|
|
|
except Exception as e:
|
|
|
|
iteration += 1
|
|
|
|
|
|
|
|
if not success:
|
|
|
|
raise Exception("Unable to sort in ascending order while clicked "
|
|
|
|
"on 'Name' column")
|
|
|
|
|
|
|
|
time.sleep(0.05)
|
2018-06-25 08:41:07 -05:00
|
|
|
|
|
|
|
# Click and Check for sort Descending
|
2018-08-21 07:09:36 -05:00
|
|
|
# Intermittently facing issue on first click it is not successful
|
|
|
|
# so tried couple of times.
|
|
|
|
iteration = 0
|
|
|
|
success = False
|
|
|
|
while not success and iteration < 4:
|
|
|
|
self.page.find_by_xpath("//th[@data-column='0']"
|
|
|
|
"/div/span[text()='Name']").click()
|
|
|
|
try:
|
|
|
|
self.wait.until(
|
|
|
|
EC.presence_of_element_located((
|
|
|
|
By.CSS_SELECTOR,
|
|
|
|
"#contents th[data-column='0'].tablesorter-headerDesc")
|
|
|
|
))
|
|
|
|
success = True
|
|
|
|
except Exception as e:
|
|
|
|
iteration += 1
|
|
|
|
|
|
|
|
if not success:
|
|
|
|
raise Exception("Unable to sort in descending order while clicked "
|
|
|
|
"on 'Name' column")
|
2018-10-17 05:50:22 -05:00
|
|
|
|
|
|
|
self.page.click_modal('Cancel')
|