IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added informative message when there is no difference found for schema diff. Fixes #6122

Browse Source
This commit is contained in:
Nikhil Mohite
2021-01-15 14:03:22 +05:30
committed by Akshay Joshi
parent a2edf317a9
commit 065bda37b4
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_4_30.rst
View File

@@ -39,5 +39,6 @@ Bug fixes
| `Issue #6096 <https://redmine.postgresql.org/issues/6096>`_ - Updated deployment documentation, refer correctly to uWSGI where Gunicorn had been referenced. | `Issue #6096 <https://redmine.postgresql.org/issues/6096>`_ - Updated deployment documentation, refer correctly to uWSGI where Gunicorn had been referenced.
| `Issue #6120 <https://redmine.postgresql.org/issues/6120>`_ - Ensure that the user should be able to specify an older date for the account expiration of the role/user. | `Issue #6120 <https://redmine.postgresql.org/issues/6120>`_ - Ensure that the user should be able to specify an older date for the account expiration of the role/user.
| `Issue #6121 <https://redmine.postgresql.org/issues/6121>`_ - Fixed an issue where the database list in the new connection window is not visible. | `Issue #6121 <https://redmine.postgresql.org/issues/6121>`_ - Fixed an issue where the database list in the new connection window is not visible.
| `Issue #6122 <https://redmine.postgresql.org/issues/6122>`_ - Added informative message when there is no difference found for schema diff.
| `Issue #6128 <https://redmine.postgresql.org/issues/6128>`_ - Fixed an issue where sequences are not created. | `Issue #6128 <https://redmine.postgresql.org/issues/6128>`_ - Fixed an issue where sequences are not created.
| `Issue #6140 <https://redmine.postgresql.org/issues/6140>`_ - Ensure that verbose logs should be visible for Utility(Backup, Maintenance) jobs. | `Issue #6140 <https://redmine.postgresql.org/issues/6140>`_ - Ensure that verbose logs should be visible for Utility(Backup, Maintenance) jobs.

14
web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
View File

@@ -307,6 +307,18 @@ export default class SchemaDiffUI {
return false; return false;
} }
check_empty_diff() {
var self = this;
this.panel_obj.$container.find('#schema-diff-grid .slick-viewport .pg-panel-message').remove();
if (self.dataView.getFilteredItems().length == 0) {
let msg = gettext('No difference found');
// Make the height to 0px to avoid extra scroll bar, height will be calculated automatically.
this.panel_obj.$container.find('#schema-diff-grid .slick-viewport .grid-canvas')[0].style.height = '0px';
this.panel_obj.$container.find('#schema-diff-grid .slick-viewport'
).prepend('<div class="pg-panel-message">'+ msg +'</div>');
}
}
render_grid(data) { render_grid(data) {
var self = this; var self = this;
@@ -315,6 +327,7 @@ export default class SchemaDiffUI {
if (self.grid) { if (self.grid) {
// Only render the data // Only render the data
self.render_grid_data(data); self.render_grid_data(data);
self.check_empty_diff();
return; return;
} }
// Checkbox Column // Checkbox Column
@@ -854,6 +867,7 @@ export default class SchemaDiffUI {
if(!_.isUndefined(self.dataView) && !_.isNull(self.dataView)) { if(!_.isUndefined(self.dataView) && !_.isNull(self.dataView)) {
// Refresh the grid // Refresh the grid
self.dataView.refresh(); self.dataView.refresh();
self.check_empty_diff();
} }
} }