IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube.

Browse Source
This commit is contained in:
Akshay Joshi
2022-01-25 20:10:31 +05:30
parent 094129e2be
commit 0ce3434631
33 changed files with 603 additions and 1055 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
View File

@@ -632,6 +632,16 @@ export default class SchemaDiffUI {
}
}
transformFunc(data) {
let group_template_options = [];
for (let key in data) {
if (data.hasOwnProperty(key)) {
group_template_options.push({'group': key, 'optval': data[key]});
}
}
return group_template_options;
}
render() {
let self = this;
let panel = self.docker.findPanels('schema_diff_header_panel')[0];
@@ -645,13 +655,7 @@ export default class SchemaDiffUI {
name: 'source_sid', label: false,
control: SchemaDiffSelect2Control,
transform: function(data) {
let group_template_options = [];
for (let key in data) {
if (data.hasOwnProperty(key)) {
group_template_options.push({'group': key, 'optval': data[key]});
}
}
return group_template_options;
return self.transformFunc(data);
},
url: url_for('schema_diff.servers'),
select2: {
@@ -729,13 +733,7 @@ export default class SchemaDiffUI {
name: 'target_sid', label: false,
control: SchemaDiffSelect2Control,
transform: function(data) {
let group_template_options = [];
for (let key in data) {
if (data.hasOwnProperty(key)) {
group_template_options.push({'group': key, 'optval': data[key]});
}
}
return group_template_options;
return self.transformFunc(data);
},
group: 'target',
url: url_for('schema_diff.servers'),