IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2024-11-26 02:30:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix an issue where clicking on an empty textbox like fill factor or comments, considers it as change and enabled the save button. Fixes #4506.

Browse Source
This commit is contained in:
Aditya Toshniwal 2019-12-11 14:35:14 +05:30 committed by Akshay Joshi
parent 43d37e3b4c
commit 11bf5fc679
6 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_4_17.rst
View File

@ -17,4 +17,5 @@ Housekeeping
Bug fixes Bug fixes
********* *********
| `Issue #4506 <https://redmine.postgresql.org/issues/4506>`_ - Fix an issue where clicking on an empty textbox like fill factor or comments, considers it as change and enabled the save button.
| `Issue #5004 <https://redmine.postgresql.org/issues/5004>`_ - Fix vulnerability issues reported by 'yarn audit'. Replace the deprecated uglifyjs-webpack-plugin with a terser-webpack-plugin. | `Issue #5004 <https://redmine.postgresql.org/issues/5004>`_ - Fix vulnerability issues reported by 'yarn audit'. Replace the deprecated uglifyjs-webpack-plugin with a terser-webpack-plugin.

3
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/tables/sql/12_plus/update.sql
View File

@ -56,6 +56,9 @@ ALTER TABLE {{conn|qtIdent(data.schema, data.name)}}
{% if data.fillfactor and data.fillfactor != o_data.fillfactor %} {% if data.fillfactor and data.fillfactor != o_data.fillfactor %}
ALTER TABLE {{conn|qtIdent(data.schema, data.name)}} ALTER TABLE {{conn|qtIdent(data.schema, data.name)}}
SET (FILLFACTOR={{data.fillfactor}}); SET (FILLFACTOR={{data.fillfactor}});
{% elif data.fillfactor == '' and data.fillfactor != o_data.fillfactor %}
ALTER TABLE {{conn|qtIdent(data.schema, data.name)}}
RESET (FILLFACTOR);
{% endif %} {% endif %}
{###############################} {###############################}

3
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/tables/sql/default/update.sql
View File

@ -64,6 +64,9 @@ ALTER TABLE {{conn|qtIdent(data.schema, data.name)}}
{% if data.fillfactor and data.fillfactor != o_data.fillfactor %} {% if data.fillfactor and data.fillfactor != o_data.fillfactor %}
ALTER TABLE {{conn|qtIdent(data.schema, data.name)}} ALTER TABLE {{conn|qtIdent(data.schema, data.name)}}
SET (FILLFACTOR={{data.fillfactor}}); SET (FILLFACTOR={{data.fillfactor}});
{% elif data.fillfactor == '' and data.fillfactor != o_data.fillfactor %}
ALTER TABLE {{conn|qtIdent(data.schema, data.name)}}
RESET (FILLFACTOR);
{% endif %} {% endif %}
{###############################} {###############################}

2
web/pgadmin/browser/server_groups/servers/databases/schemas/views/static/js/mview.js
View File

@ -203,7 +203,7 @@ define('pgadmin.node.mview', [
},{ },{
id: 'fillfactor', label: gettext('Fill factor'), id: 'fillfactor', label: gettext('Fill factor'),
group: gettext('Storage'), mode: ['edit', 'create'], group: gettext('Storage'), mode: ['edit', 'create'],
type: 'int', type: 'int', min: 10, max: 100,
},{ },{
type: 'nested', control: 'tab', id: 'materialization', type: 'nested', control: 'tab', id: 'materialization',
label: gettext('Parameter'), mode: ['edit', 'create'], label: gettext('Parameter'), mode: ['edit', 'create'],

7
web/pgadmin/browser/static/js/datamodel.js
View File

@ -367,7 +367,8 @@ define([
return; return;
} }
attrs[k] = v; attrs[k] = v;
if (_.isEqual(self.origSessAttrs[k], v)) { /* If the orig value was null and new one is empty string, then its a "no change" */
if (_.isEqual(self.origSessAttrs[k], v) || (self.origSessAttrs[k] === null && v === '')) {
delete self.sessAttrs[k]; delete self.sessAttrs[k];
} else { } else {
self.sessAttrs[k] = v; self.sessAttrs[k] = v;
@ -738,9 +739,7 @@ define([
field = this.fieldData[keys[i]]; field = this.fieldData[keys[i]];
msg = null; msg = null;
if (!(_.isUndefined(value) || _.isNull(value) || if (!(_.isUndefined(value) || _.isNull(value) || String(value) === '')) {
String(value).replace(/^\s+|\s+$/g, '') == '')) {
if (!field) { if (!field) {
continue; continue;
} }

4
web/pgadmin/browser/templates/browser/js/messages.js
View File

@ -26,8 +26,8 @@ define(
'SQL_NO_CHANGE': gettext('Nothing changed'), 'SQL_NO_CHANGE': gettext('Nothing changed'),
'MUST_BE_INT' : gettext("'%s' must be an integer."), 'MUST_BE_INT' : gettext("'%s' must be an integer."),
'MUST_BE_NUM' : gettext("'%s' must be a numeric."), 'MUST_BE_NUM' : gettext("'%s' must be a numeric."),
'MUST_GR_EQ' : gettext("%s' must be greater than or equal to %d."), 'MUST_GR_EQ' : gettext("'%s' must be greater than or equal to %s."),
'MUST_LESS_EQ' : gettext("'%s' must be less than or equal to %d."), 'MUST_LESS_EQ' : gettext("'%s' must be less than or equal to %s."),
'STATISTICS_LABEL': gettext("Statistics"), 'STATISTICS_LABEL': gettext("Statistics"),
'STATISTICS_VALUE_LABEL': gettext("Value"), 'STATISTICS_VALUE_LABEL': gettext("Value"),
'NODE_HAS_NO_SQL': gettext("No SQL could be generated for the selected object."), 'NODE_HAS_NO_SQL': gettext("No SQL could be generated for the selected object."),