From 155f82676d114203e31d22da9b2d1a27bae44d60 Mon Sep 17 00:00:00 2001 From: Joao Pedro De Almeida Pereira Date: Tue, 19 Jun 2018 20:01:45 -0400 Subject: [PATCH] Fix the RE-SQL generation for GreenPlum external tables. Fixes #3431 --- docs/en_US/release_notes_3_1.rst | 3 ++- .../external_tables/templates/sql/gpdb_5.0_plus/create.sql | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/en_US/release_notes_3_1.rst b/docs/en_US/release_notes_3_1.rst index ccd383e00..f6779bb42 100644 --- a/docs/en_US/release_notes_3_1.rst +++ b/docs/en_US/release_notes_3_1.rst @@ -40,4 +40,5 @@ Bug fixes | `Bug #3356 `_ - Include the schema name on RE-SQL for packages | `Bug #3374 `_ - Fix autocomplete | `Bug #3392 `_ - Fix IPv6 support in the container build -| `Bug #3409 `_ - Avoid an exception on GreenPlum when retrieving RE-SQL on a table \ No newline at end of file +| `Bug #3409 `_ - Avoid an exception on GreenPlum when retrieving RE-SQL on a table +| `Bug #3431 `_ - Fix the RE-SQL generation for GreenPlum external tables \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql b/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql index a7f64a5fc..25ebf96c0 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql @@ -48,7 +48,7 @@ OPTIONS ( ) {% endif %} ENCODING '{{ table.pgEncodingToChar }}' -{% if table.rejectLimit and table.rejectLimit|length > 0 %} +{% if table.rejectLimit and table.rejectLimit > 0 %} {% if table.errorTableName and table.errorTableName|length > 0 %} LOG ERRORS {% endif %}SEGMENT REJECT LIMIT {{ table.rejectLimit }} {{ rejectionLimit }} {% endif %}