IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed XSS vulnerability issues. #5277

Browse Source
This commit is contained in:
Nikhil Mohite 2022-10-13 10:59:05 +05:30 committed by GitHub
parent 8a76122949
commit 1904a64e42
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/pgadmin/browser/static/js/browser.js
View File

@ -1114,8 +1114,6 @@ define('pgadmin.browser', [
if (!ctx.t.wasInit() || !_data) { if (!ctx.t.wasInit() || !_data) {
return; return;
} }
_data._label = _data.label;
_data.label = _.escape(_data.label);
traversePath(); traversePath();
}, },

2
web/pgadmin/tools/psql/static/js/psql_module.js
View File

@ -145,7 +145,7 @@ export function initialize(gettext, url_for, $, _, pgAdmin, csrfToken, Browser)
// Set psql tab title as per prefrences setting. // Set psql tab title as per prefrences setting.
let title_data = { let title_data = {
'database': parentData.database ? parentData.database.label : 'postgres' , 'database': parentData.database ? parentData.database.label : 'postgres' ,
'username': parentData.server.user_name, 'username': parentData.server.user.name,
'server': parentData.server.label, 'server': parentData.server.label,
'type': 'psql_tool', 'type': 'psql_tool',
}; };

2
web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx
View File

@ -548,7 +548,7 @@ export default function QueryToolComponent({params, pgWindow, pgAdmin, selectedN
}); });
setPanelTitle(panel, connectionData.title, qtState, isDirtyRef.current); setPanelTitle(panel, connectionData.title, qtState, isDirtyRef.current);
let msg = `${connectionData['server_name']}/${connectionData['database_name']} - Database connected`; let msg = `${connectionData['server_name']}/${connectionData['database_name']} - Database connected`;
Notifier.success(msg); Notifier.success(_.escape(msg));
resolve(); resolve();
}) })
.catch((error)=>{ .catch((error)=>{

20
web/pgadmin/tools/sqleditor/static/js/sqleditor_title.js
View File

@ -15,7 +15,7 @@ import Notify from '../../../../static/js/helpers/Notifier';
const pgAdmin = pgWindow.pgAdmin; const pgAdmin = pgWindow.pgAdmin;
export function getDatabaseLabel(parentData) { export function getDatabaseLabel(parentData) {
return parentData.database ? parentData.database._label return parentData.database ? parentData.database.label
: parentData.server?.db; : parentData.server?.db;
} }
@ -74,7 +74,7 @@ export function getPanelTitle(pgBrowser, selected_item=null, custom_title=null,
let title_data = { let title_data = {
'database': db_label, 'database': db_label,
'username': parentData.server.user.name, 'username': parentData.server.user.name,
'server': parentData.server._label, 'server': parentData.server.label,
'type': 'query_tool', 'type': 'query_tool',
}; };
@ -116,15 +116,15 @@ export function set_renamable_option(panel, is_file) {
export function generateTitle(title_placeholder, title_data) { export function generateTitle(title_placeholder, title_data) {
if(title_data.type == 'query_tool' || title_data.type == 'psql_tool') { if(title_data.type == 'query_tool' || title_data.type == 'psql_tool') {
title_placeholder = title_placeholder.replace('%DATABASE%', _.unescape(title_data.database)); title_placeholder = title_placeholder.replace('%DATABASE%', title_data.database);
title_placeholder = title_placeholder.replace('%USERNAME%', _.unescape(title_data.username)); title_placeholder = title_placeholder.replace('%USERNAME%', title_data.username);
title_placeholder = title_placeholder.replace('%SERVER%', _.unescape(title_data.server)); title_placeholder = title_placeholder.replace('%SERVER%', title_data.server);
} else if(title_data.type == 'view_data') { } else if(title_data.type == 'view_data') {
title_placeholder = title_placeholder.replace('%DATABASE%', _.unescape(title_data.database)); title_placeholder = title_placeholder.replace('%DATABASE%', title_data.database);
title_placeholder = title_placeholder.replace('%USERNAME%', _.unescape(title_data.username)); title_placeholder = title_placeholder.replace('%USERNAME%', title_data.username);
title_placeholder = title_placeholder.replace('%SERVER%', _.unescape(title_data.server)); title_placeholder = title_placeholder.replace('%SERVER%', title_data.server);
title_placeholder = title_placeholder.replace('%SCHEMA%', _.unescape(title_data.schema)); title_placeholder = title_placeholder.replace('%SCHEMA%', title_data.schema);
title_placeholder = title_placeholder.replace('%TABLE%', _.unescape(title_data.table)); title_placeholder = title_placeholder.replace('%TABLE%', title_data.table);
} else if(title_data.type == 'debugger') { } else if(title_data.type == 'debugger') {
title_placeholder = title_placeholder.replace('%FUNCTION%', _.unescape(title_data.function_name)); title_placeholder = title_placeholder.replace('%FUNCTION%', _.unescape(title_data.function_name));
title_placeholder = title_placeholder.replace('%ARGS%', _.unescape(title_data.args)); title_placeholder = title_placeholder.replace('%ARGS%', _.unescape(title_data.args));