IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube.

Browse Source
This commit is contained in:
Akshay Joshi
2022-01-28 17:20:34 +05:30
parent 37d82d457c
commit 1a89c1f85f
72 changed files with 579 additions and 4126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
web/pgadmin/misc/file_manager/static/js/utility.js
View File

@@ -467,6 +467,16 @@ define([
return `<div class="no_folder_found">${lg.could_not_retrieve_folder}</div>`;
};
var getCapClasses = function(item_data, capabilities) {
let capClasses = '';
capClasses = Object.keys(capabilities).map(function(cap) {
if (has_capability(item_data, capabilities[cap])) {
return 'cap_' + capabilities[cap];
}
}).join(' ');
return capClasses;
};
var getGridView = function(data, capabilities) {
let ret_ele = '<ul id="contents" class="grid">',
no_data = _.isEmpty(data);
@@ -481,11 +491,7 @@ define([
icon_type = '',
cap_classes = '';
cap_classes = Object.keys(capabilities).map(function(cap) {
if (has_capability(item_data, capabilities[cap])) {
return 'cap_' + capabilities[cap];
}
}).join(' ');
cap_classes = getCapClasses(item_data, capabilities);
item_data.Capabilities = capabilities;
bindToolbar(item_data);
@@ -581,11 +587,7 @@ define([
class_type = '',
cap_classes = '';
cap_classes = Object.keys(capabilities).map(function(cap) {
if (has_capability(item_data, capabilities[cap])) {
return 'cap_' + capabilities[cap];
}
}).join(' ');
cap_classes = getCapClasses(item_data, capabilities);
item_data.Capabilities = capabilities;
bindToolbar(item_data);

22
web/pgadmin/tools/debugger/static/js/debugger_ui.js
View File

@@ -167,6 +167,13 @@ define([
}
};
var raiseError = function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Unable to set the arguments on the server')
);
};
return function(debugInfo, restartDebug, isEdbProc, transId) {
if (!Alertify.debuggerInputArgsDialog) {
Alertify.dialog('debuggerInputArgsDialog', function factory() {
@@ -857,12 +864,7 @@ define([
},
})
.done(function() {/*This is intentional (SonarQube)*/})
.fail(function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Unable to set the arguments on the server')
);
});
.fail(raiseError);
})
.fail(function(er) {
Notify.alert(
@@ -907,13 +909,7 @@ define([
},
})
.done(function() {/*This is intentional (SonarQube)*/})
.fail(function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Unable to set the arguments on the server')
);
});
.fail(raiseError);
}
return true;

70
web/pgadmin/tools/debugger/static/js/direct.js
View File

@@ -306,6 +306,13 @@ define([
});
},
raisePollingError: function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while polling result.')
);
},
// Get the stack information of the functions and update the grid
GetStackInformation: function(trans_id) {
var self = this;
@@ -442,12 +449,7 @@ define([
);
}
})
.fail(function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while polling result.')
);
});
.fail(self.raisePollingError());
}, poll_timeout);
},
@@ -621,12 +623,7 @@ define([
pgTools.DirectDebug.is_polling_required = false;
}
})
.fail(function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while polling result.')
);
});
.fail(self.raisePollingError());
}, poll_end_timeout);
},
@@ -685,12 +682,7 @@ define([
self.poll_end_execution_result(trans_id);
}
})
.fail(function() {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while polling result.')
);
});
.fail(self.raisePollingError());
}
})
.fail(function(xhr) {
@@ -1479,6 +1471,20 @@ define([
*/
var DirectDebug = function() {/*This is intentional (SonarQube)*/};
var raiseJSONError = function(xhr) {
try {
var err = JSON.parse(xhr.responseText);
if (err.success == 0) {
Notify.alert(gettext('Debugger Error'), err.errormsg);
}
} catch (e) {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while starting debugging listener.')
);
}
};
_.extend(DirectDebug.prototype, {
/* We should get the transaction id from the server during initialization here */
load: function(trans_id, debug_type, function_name_with_arguments, layout) {
@@ -1537,19 +1543,7 @@ define([
controller.poll_result(trans_id);
}
})
.fail(function(xhr) {
try {
var err = JSON.parse(xhr.responseText);
if (err.success == 0) {
Notify.alert(gettext('Debugger Error'), err.errormsg);
}
} catch (e) {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while starting debugging listener.')
);
}
});
.fail(raiseJSONError);
} else if (trans_id != undefined) {
// Make ajax call to execute the and start the target for execution
baseUrl = url_for('debugger.start_listener', {
@@ -1565,19 +1559,7 @@ define([
self.messages(trans_id);
}
})
.fail(function(xhr) {
try {
var err = JSON.parse(xhr.responseText);
if (err.success == 0) {
Notify.alert(gettext('Debugger Error'), err.errormsg);
}
} catch (e) {
Notify.alert(
gettext('Debugger Error'),
gettext('Error while starting debugging listener.')
);
}
});
.fail(raiseJSONError);
} else {
this.intializePanels();
}

18
web/pgadmin/tools/user_management/static/js/user_management.js
View File

@@ -543,6 +543,12 @@ define([
deleteUserCell = Backgrid.Extension.DeleteCell.extend({
raiseError: function() {
Notify.error(
gettext('Error during deleting user.')
);
},
changeOwnership: function(res, uid) {
let self = this;
@@ -695,11 +701,7 @@ define([
alertify.changeOwnershipDialog().destroy();
alertify.UserManagement().destroy();
},
error: function() {
Notify.error(
gettext('Error during deleting user.')
);
},
error: self.raiseError,
});
alertify.changeOwnershipDialog().destroy();
},
@@ -745,11 +747,7 @@ define([
success: function() {
Notify.success(gettext('User deleted.'));
},
error: function() {
Notify.error(
gettext('Error during deleting user.')
);
},
error: self.raiseError,
});
},
function() {