IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Resolved an issue - rendering the SQL control refering to the undefined

Browse Source 
variable.

It was regression of the commit-id:
085ce50545.
This commit is contained in:
Ashesh Vashi 2016-04-22 22:55:50 +05:30
parent 244f5d59d2
commit 1b44aed456
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/pgadmin/static/js/backform.pgadmin.js
View File

@ -1975,9 +1975,10 @@
// Evaluate the disabled, visible option // Evaluate the disabled, visible option
var isDisabled = evalF(data.disabled, data, this.model), var isDisabled = evalF(data.disabled, data, this.model),
isVisible = evalF(data.visible, data, this.model); isVisible = evalF(data.visible, data, this.model),
self = this;
this.sqlCtrl = CodeMirror.fromTextArea( self.sqlCtrl = CodeMirror.fromTextArea(
(self.$el.find("textarea")[0]), { (self.$el.find("textarea")[0]), {
lineNumbers: true, lineNumbers: true,
mode: "text/x-sql", mode: "text/x-sql",
@ -1985,7 +1986,7 @@
}); });
if (!isVisible) if (!isVisible)
this.$el.addClass(Backform.hiddenClassname); self.$el.addClass(Backform.hiddenClassname);
var self = this; var self = this;
// Refresh SQL Field to refresh the control lazily after it renders // Refresh SQL Field to refresh the control lazily after it renders
@ -2005,7 +2006,7 @@
if (this.sqlCtrl) { if (this.sqlCtrl) {
delete this.sqlCtrl; delete this.sqlCtrl;
this.sqlCtrl = null; this.sqlCtrl = null;
this.$el.remove(); this.$el.empty();
} }
this.stopListening(this.model, "pg-property-tab-changed", this.refreshTextArea); this.stopListening(this.model, "pg-property-tab-changed", this.refreshTextArea);