IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube.

Browse Source
This commit is contained in:
Akshay Joshi
2020-09-29 15:08:14 +05:30
parent c7c199210d
commit 1c70a43b91
22 changed files with 167 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/pgadmin/browser/server_groups/servers/pgagent/steps/__init__.py
View File

@@ -146,6 +146,7 @@ class JobStepView(PGChildNodeView):
"""
node_type = blueprint.node_type
STEP_NOT_FOUND = "Could not find the specified job step."
parent_ids = [
{'type': 'int', 'id': 'gid'},
@@ -266,7 +267,7 @@ SELECT EXISTS(
if jstid is not None:
if len(result['rows']) == 0:
return gone(errormsg="Could not find the specified job step.")
return gone(errormsg=self.STEP_NOT_FOUND)
row = result['rows'][0]
return make_json_response(
@@ -322,7 +323,7 @@ SELECT EXISTS(
return internal_server_error(errormsg=res)
if len(res['rows']) == 0:
return gone(errormsg="Could not find the specified job step.")
return gone(errormsg=self.STEP_NOT_FOUND)
return ajax_response(
response=res['rows'][0],
@@ -423,9 +424,7 @@ SELECT EXISTS(
if len(res['rows']) == 0:
return gone(
errormsg=gettext(
"Could not find the specified job step."
)
errormsg=gettext(self.STEP_NOT_FOUND)
)
row = res['rows'][0]
data['jstconntype'] = row['jstconntype']
@@ -549,9 +548,7 @@ SELECT EXISTS(
if len(res['rows']) == 0:
return gone(
errormsg=gettext(
"Could not find the specified job step."
)
errormsg=gettext(self.STEP_NOT_FOUND)
)
row = res['rows'][0]
data['jstconntype'] = row['jstconntype']