IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

2 fixes for the backup dialogue when using directory format:

Browse Source 
Ensure compression level is passed to pg_dump when backing up in directory format. Fixes #4482
Ensure the number of jobs can be specified when backing up in directory format. Fixes #4483
This commit is contained in:
Aditya Toshniwal 2019-10-25 13:21:53 +01:00 committed by Dave Page
parent 1f6a0a87f6
commit 2182dc3cc5
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/en_US/release_notes_4_15.rst
View File

@ -21,6 +21,8 @@ Bug fixes
| `Issue #3789 <https://redmine.postgresql.org/issues/3789>`_ - Ensure context menus never get hidden below the menu bar. | `Issue #3789 <https://redmine.postgresql.org/issues/3789>`_ - Ensure context menus never get hidden below the menu bar.
| `Issue #3913 <https://redmine.postgresql.org/issues/3913>`_ - Ensure the correct "running at" agent is shown when a pgAgent job is executing. | `Issue #3913 <https://redmine.postgresql.org/issues/3913>`_ - Ensure the correct "running at" agent is shown when a pgAgent job is executing.
| `Issue #4459 <https://redmine.postgresql.org/issues/4459>`_ - Don't quote bigints when copying them from the Query Tool results grid. | `Issue #4459 <https://redmine.postgresql.org/issues/4459>`_ - Don't quote bigints when copying them from the Query Tool results grid.
| `Issue #4482 <https://redmine.postgresql.org/issues/4482>`_ - Ensure compression level is passed to pg_dump when backing up in directory format.
| `Issue #4483 <https://redmine.postgresql.org/issues/4483>`_ - Ensure the number of jobs can be specified when backing up in directory format.
| `Issue #4730 <https://redmine.postgresql.org/issues/4730>`_ - Ensure all messages are retained in the Query Tool from long running queries. | `Issue #4730 <https://redmine.postgresql.org/issues/4730>`_ - Ensure all messages are retained in the Query Tool from long running queries.
| `Issue #4845 <https://redmine.postgresql.org/issues/4845>`_ - Fixed potential error in the properties dialog for the Code tab. | `Issue #4845 <https://redmine.postgresql.org/issues/4845>`_ - Fixed potential error in the properties dialog for the Code tab.
| `Issue #4850 <https://redmine.postgresql.org/issues/4850>`_ - Fixed an issue where Datetimepicker control opens when clicking on the label. | `Issue #4850 <https://redmine.postgresql.org/issues/4850>`_ - Fixed an issue where Datetimepicker control opens when clicking on the label.

2
web/pgadmin/tools/backup/__init__.py
View File

@ -386,8 +386,10 @@ def create_backup_objects_job(sid):
set_param('blobs', '--blobs') set_param('blobs', '--blobs')
elif data['format'] == 'plain': elif data['format'] == 'plain':
args.extend(['--format=p']) args.extend(['--format=p'])
set_value('ratio', '--compress')
elif data['format'] == 'directory': elif data['format'] == 'directory':
args.extend(['--format=d']) args.extend(['--format=d'])
set_value('ratio', '--compress')
if 'only_data' in data and data['only_data']: if 'only_data' in data and data['only_data']:
set_param('only_data', '--data-only') set_param('only_data', '--data-only')

7
web/pgadmin/tools/backup/static/js/backup.js
View File

@ -178,7 +178,10 @@ define([
type: 'int', type: 'int',
min: 0, min: 0,
max: 9, max: 9,
disabled: false, deps: ['format'],
disabled: function(m) {
return (m.get('format') === 'tar');
},
visible: function(m) { visible: function(m) {
if (!_.isUndefined(m.get('type')) && m.get('type') === 'server') if (!_.isUndefined(m.get('type')) && m.get('type') === 'server')
return false; return false;
@ -207,7 +210,7 @@ define([
type: 'int', type: 'int',
deps: ['format'], deps: ['format'],
disabled: function(m) { disabled: function(m) {
return !(m.get('format') === 'Directory'); return !(m.get('format') === 'directory');
}, },
visible: function(m) { visible: function(m) {
if (!_.isUndefined(m.get('type')) && m.get('type') === 'server') if (!_.isUndefined(m.get('type')) && m.get('type') === 'server')