diff --git a/docs/en_US/release_notes_4_24.rst b/docs/en_US/release_notes_4_24.rst index c93c21bfb..a09fbbc46 100644 --- a/docs/en_US/release_notes_4_24.rst +++ b/docs/en_US/release_notes_4_24.rst @@ -49,4 +49,5 @@ Bug fixes | `Issue #5666 `_ - Added missing dependencies/dependent and corrected some wrongly identified. | `Issue #5673 `_ - Fixed an issue where fetching the schema throws an error if the database is not connected in Schema Diff. | `Issue #5675 `_ - Fixed CSRF errors when pgAdmin opened in an iframe on safari browser. -| `Issue #5677 `_ - Fixed text color issue in explain analyze for the Dark theme. \ No newline at end of file +| `Issue #5677 `_ - Fixed text color issue in explain analyze for the Dark theme. +| `Issue #5686 `_ - Fixed issue where the user was not able to update policy if the policy is created with space. \ No newline at end of file diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/9.5_plus/update.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/9.5_plus/update.sql index 619f0038d..7fa1e3f40 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/9.5_plus/update.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/9.5_plus/update.sql @@ -2,7 +2,7 @@ {## Change policy owner ##} {#####################################################} {% if data.policyowner and o_data.policyowner != data.policyowner %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} TO {{ conn|qtTypeIdent(data.policyowner) }}; {% endif %} @@ -10,7 +10,7 @@ ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} {## Change policy using condition ##} {#####################################################} {% if data.using and o_data.using != data.using %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} USING ({{ data.using }}); {% endif %} @@ -18,7 +18,7 @@ ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} {## Change policy with check condition ##} {#####################################################} {% if data.withcheck and o_data.withcheck != data.withcheck %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} WITH CHECK ({{ data.withcheck }}); {% endif %} @@ -26,7 +26,7 @@ ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} {## Change policy name ##} {#####################################################} {% if data.name and o_data.name != data.name %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} RENAME TO {{ conn|qtIdent(data.name) }}; {% endif %} diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/default/update.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/default/update.sql index 619f0038d..7fa1e3f40 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/default/update.sql +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/row_security_policies/sql/default/update.sql @@ -2,7 +2,7 @@ {## Change policy owner ##} {#####################################################} {% if data.policyowner and o_data.policyowner != data.policyowner %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} TO {{ conn|qtTypeIdent(data.policyowner) }}; {% endif %} @@ -10,7 +10,7 @@ ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} {## Change policy using condition ##} {#####################################################} {% if data.using and o_data.using != data.using %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} USING ({{ data.using }}); {% endif %} @@ -18,7 +18,7 @@ ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} {## Change policy with check condition ##} {#####################################################} {% if data.withcheck and o_data.withcheck != data.withcheck %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} WITH CHECK ({{ data.withcheck }}); {% endif %} @@ -26,7 +26,7 @@ ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} {## Change policy name ##} {#####################################################} {% if data.name and o_data.name != data.name %} -ALTER POLICY {{ o_data.name }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} +ALTER POLICY {{ conn|qtIdent(o_data.name) }} ON {{conn|qtIdent(o_data.schema, o_data.table)}} RENAME TO {{ conn|qtIdent(data.name) }}; {% endif %}