Fixed incorrect handling of the code smell for the reject API call

This commit is contained in:
Akshay Joshi
2024-06-17 18:22:38 +05:30
parent 3706c3126a
commit 2b04f3ca1d
26 changed files with 44 additions and 42 deletions
+1 -1
View File
@@ -265,7 +265,7 @@ define([
}).then((response)=> {
resolve(response.data.data);
}).catch((err)=>{
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
});
});
}}
@@ -429,7 +429,7 @@ export default function DebuggerArgumentComponent({ debuggerInfo, restartDebug,
try {
resolve(debuggerArgsData.current);
} catch (error) {
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
}
});
@@ -486,7 +486,7 @@ export default class ERDTool extends React.Component {
})
.catch((err)=>{
console.error(err);
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
});
});
const {x, y} = this.diagram.getEngine().getRelativeMousePoint(e);
@@ -388,11 +388,11 @@ export default function SearchObjects({nodeData}) {
})
.catch((err)=>{
pgAdmin.Browser.notifier.error(parseApiError(err));
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
});
} catch (error) {
pgAdmin.Browser.notifier.error(parseApiError(error));
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
}
});
};
@@ -721,7 +721,7 @@ export default function QueryToolComponent({params, pgWindow, pgAdmin, selectedN
});
} else {
selectConn(currSelectedConn, currConnected, false);
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
}
});
});
@@ -763,7 +763,7 @@ export default function QueryToolComponent({params, pgWindow, pgAdmin, selectedN
}
updateQueryToolConnection(connectionData, true)
.catch((err)=>{
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
}).then(()=>{
resolve();
onClose();
@@ -88,7 +88,7 @@ export default function FilterDialog({onClose, onSave}) {
filterSchemaObj.setColumnOptions((columns||[]).map((c)=>({label: c, value: c})));
resolve(filterData);
} catch (error) {
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
}
};
getFilterData();
@@ -109,7 +109,7 @@ export default function FilterDialog({onClose, onSave}) {
reject(new Error(respData.data.result));
}
} catch (error) {
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
}
};
setFilterData();
@@ -169,7 +169,7 @@ export default function MacrosDialog({onClose, onSave}) {
onSave(respData.filter((m) => Boolean(m.name)));
onClose();
} catch (error) {
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
}
};
setMacros();
@@ -75,7 +75,7 @@ class NewConnectionSchema extends BaseUISchema {
resolve(groupedOptions);
})
.catch((error)=>{
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
});
});
}
@@ -97,7 +97,7 @@ class NewConnectionSchema extends BaseUISchema {
resolve(respData.data.result.data);
})
.catch((error)=>{
reject(new Error(error));
reject(error instanceof Error ? error : Error(gettext('Something went wrong')));
});
});
}
@@ -50,7 +50,7 @@ async function registerAutocomplete(editor, api, transId) {
})
.catch((err) => {
onAvailable();
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
});
});
});
@@ -364,7 +364,7 @@ function UserManagementDialog({onClose}) {
onClose();
})
.catch((err)=>{
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
});
} catch (error) {
reject(parseApiError(error));
@@ -402,7 +402,7 @@ function UserManagementDialog({onClose}) {
resolve({userManagement:res.data});
})
.catch((err)=>{
reject(new Error(err));
reject(err instanceof Error ? err : Error(gettext('Something went wrong')));
});
}); }}
schema={new UserManagementSchema(authSourcesOptions, roleOptions)}