Fixed the following code smells:

1) useState call is not destructured into value + setter pair.
2) A fragment with only one child is redundant.
3) Unnecessary '.apply()' and '.call()'.
4) Expected the Promise rejection reason to be an Error.

web/pgadmin/misc/bgprocess/static/js/Processes.jsx

@@ -275,49 +275,47 @@ export default function Processes() {
   }, []);
 
   return (
-    <>
-      <PgTable
-        data-test="processes"
-        className={classes.autoResizer}
-        columns={columns}
-        data={tableData}
-        sortOptions={[{id: 'stime', desc: true}]}
-        getSelectedRows={(rows)=>{setSelectedRows(rows);}}
-        isSelectRow={true}
-        tableProps={{
-          autoResetSelectedRows: false,
-          getRowId: (row)=>{
-            return row.id;
-          }
-        }}
-        CustomHeader={()=>{
-          return (
-            <Box>
-              <PgButtonGroup>
-                <PgIconButton
-                  icon={<DeleteIcon style={{height: '1.4rem'}}/>}
-                  aria-label="Acknowledge and Remove"
-                  title={gettext('Acknowledge and Remove')}
-                  onClick={() => {
-                    pgAdmin.Browser.notifier.confirm(gettext('Remove Processes'), gettext('Are you sure you want to remove the selected processes?'), ()=>{
-                      pgAdmin.Browser.BgProcessManager.acknowledge(selectedRows.map((p)=>p.original.id));
-                    });
-                  }}
-                  disabled={selectedRows.length <= 0}
-                ></PgIconButton>
-                <PgIconButton
-                  icon={<HelpIcon style={{height: '1.4rem'}}/>}
-                  aria-label="Help"
-                  title={gettext('Help')}
-                  onClick={() => {
-                    window.open(url_for('help.static', {'filename': 'processes.html'}));
-                  }}
-                ></PgIconButton>
-              </PgButtonGroup>
-            </Box>
-          );
-        }}
-      ></PgTable>
-    </>
+    <PgTable
+      data-test="processes"
+      className={classes.autoResizer}
+      columns={columns}
+      data={tableData}
+      sortOptions={[{id: 'stime', desc: true}]}
+      getSelectedRows={(rows)=>{setSelectedRows(rows);}}
+      isSelectRow={true}
+      tableProps={{
+        autoResetSelectedRows: false,
+        getRowId: (row)=>{
+          return row.id;
+        }
+      }}
+      CustomHeader={()=>{
+        return (
+          <Box>
+            <PgButtonGroup>
+              <PgIconButton
+                icon={<DeleteIcon style={{height: '1.4rem'}}/>}
+                aria-label="Acknowledge and Remove"
+                title={gettext('Acknowledge and Remove')}
+                onClick={() => {
+                  pgAdmin.Browser.notifier.confirm(gettext('Remove Processes'), gettext('Are you sure you want to remove the selected processes?'), ()=>{
+                    pgAdmin.Browser.BgProcessManager.acknowledge(selectedRows.map((p)=>p.original.id));
+                  });
+                }}
+                disabled={selectedRows.length <= 0}
+              ></PgIconButton>
+              <PgIconButton
+                icon={<HelpIcon style={{height: '1.4rem'}}/>}
+                aria-label="Help"
+                title={gettext('Help')}
+                onClick={() => {
+                  window.open(url_for('help.static', {'filename': 'processes.html'}));
+                }}
+              ></PgIconButton>
+            </PgButtonGroup>
+          </Box>
+        );
+      }}
+    ></PgTable>
   );
 }

web/pgadmin/misc/cloud/static/js/CloudWizard.jsx

@@ -71,7 +71,7 @@ export default function CloudWizard({ nodeInfo, nodeData, onClose, cloudPanelId}
   let steps = [gettext('Cloud Provider'), gettext('Credentials'), gettext('Cluster Type'),
     gettext('Instance Specification'), gettext('Database Details'), gettext('Review')];
   const [currentStep, setCurrentStep] = React.useState('');
-  const [selectionVal, setCloudSelection] = React.useState('');
+  const [cloudSelection, setCloudSelection] = React.useState('');
   const [errMsg, setErrMsg] = React.useState('');
   const [cloudInstanceDetails, setCloudInstanceDetails] = React.useState({});
   const [cloudDBCred, setCloudDBCred] = React.useState({});
@@ -295,14 +295,14 @@ export default function CloudWizard({ nodeInfo, nodeData, onClose, cloudPanelId}
         setErrMsg([MESSAGE_TYPE.INFO, gettext('Validating credentials...')]);
         let _url = url_for('rds.verify_credentials');
         const post_data = {
-          cloud: selectionVal,
+          cloud: cloudSelection,
           secret: cloudDBCred,
         };
         axiosApi.post(_url, post_data)
           .then((res) => {
             if(!res.data.success) {
               setErrMsg([MESSAGE_TYPE.ERROR, res.data.info]);
-              reject();
+              reject(new Error(res.data.info));
             } else {
               setErrMsg(['', '']);
               if (activeStep == 1) {
@@ -314,7 +314,7 @@ export default function CloudWizard({ nodeInfo, nodeData, onClose, cloudPanelId}
           })
           .catch(() => {
             setErrMsg([MESSAGE_TYPE.ERROR, gettext('Error while checking cloud credentials')]);
-            reject();
+            reject(new Error(gettext('Error while checking cloud credentials')));
           });
       } else if(activeStep == 0 && cloudProvider == CLOUD_PROVIDERS.BIGANIMAL) {
         if (!isEmptyString(verificationURI)) { resolve(); return; }
@@ -328,7 +328,7 @@ export default function CloudWizard({ nodeInfo, nodeData, onClose, cloudPanelId}
           })
           .catch((error) => {
             setErrMsg([MESSAGE_TYPE.ERROR, gettext(error)]);
-            reject();
+            reject(new Error(gettext(error)));
           });
       } else if (cloudProvider == CLOUD_PROVIDERS.AZURE) {
         if (activeStep == 1) {
@@ -347,7 +347,7 @@ export default function CloudWizard({ nodeInfo, nodeData, onClose, cloudPanelId}
               resolve();
             }).catch((error)=>{
               setErrMsg([MESSAGE_TYPE.ERROR, gettext(error)]);
-              reject();
+              reject(new Error(gettext(error)));
             });
         } else {
           resolve();
@@ -423,157 +423,155 @@ export default function CloudWizard({ nodeInfo, nodeData, onClose, cloudPanelId}
 
   return (
     <CloudWizardEventsContext.Provider value={eventBus.current}>
-      <>
-        <Wizard
-          title={gettext('Deploy Cloud Instance')}
-          stepList={steps}
-          disableNextStep={disableNextCheck}
-          onStepChange={wizardStepChange}
-          onSave={onSave}
-          onHelp={onDialogHelp}
-          beforeNext={onBeforeNext}
-          beforeBack={onBeforeBack}>
-          <WizardStep stepId={0}>
-            <Box className={classes.messageBox}>
-              <Box className={classes.messagePadding}>{gettext('Select a cloud provider for PostgreSQL database.')}</Box>
-            </Box>
-            <Box className={classes.messageBox}>
-              <ToggleButtons cloudProvider={cloudProvider} setCloudProvider={setCloudProvider}
-                options={cloud_providers}
-              ></ToggleButtons>
-            </Box>
-            <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
-          </WizardStep>
-          <WizardStep stepId={1} >
-            <Box className={classes.buttonMarginEDB}>
-              {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && <Box className={classes.messageBox}>
-                <Box>{gettext('The verification code to authenticate the pgAdmin to EDB BigAnimal is: ')} <strong>{verificationCode}</strong>
-                  <br/>{gettext('By clicking the below button, you will be redirected to the EDB BigAnimal authentication page in a new tab.')}
-                </Box>
-              </Box>}
-              {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && <PrimaryButton onClick={authenticateBigAnimal} disabled={verificationIntiated}>
-                {gettext('Click here to authenticate yourself to EDB BigAnimal')}
-              </PrimaryButton>}
-              {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && <Box className={classes.messageBox}>
-                <Box ></Box>
-              </Box>}
-            </Box>
-            {cloudProvider == CLOUD_PROVIDERS.AWS && <AwsCredentials cloudProvider={cloudProvider} nodeInfo={nodeInfo} nodeData={nodeData} setCloudDBCred={setCloudDBCred}/>}
-            { cloudProvider == CLOUD_PROVIDERS.AZURE &&
+      <Wizard
+        title={gettext('Deploy Cloud Instance')}
+        stepList={steps}
+        disableNextStep={disableNextCheck}
+        onStepChange={wizardStepChange}
+        onSave={onSave}
+        onHelp={onDialogHelp}
+        beforeNext={onBeforeNext}
+        beforeBack={onBeforeBack}>
+        <WizardStep stepId={0}>
+          <Box className={classes.messageBox}>
+            <Box className={classes.messagePadding}>{gettext('Select a cloud provider for PostgreSQL database.')}</Box>
+          </Box>
+          <Box className={classes.messageBox}>
+            <ToggleButtons cloudProvider={cloudProvider} setCloudProvider={setCloudProvider}
+              options={cloud_providers}
+            ></ToggleButtons>
+          </Box>
+          <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
+        </WizardStep>
+        <WizardStep stepId={1} >
+          <Box className={classes.buttonMarginEDB}>
+            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && <Box className={classes.messageBox}>
+              <Box>{gettext('The verification code to authenticate the pgAdmin to EDB BigAnimal is: ')} <strong>{verificationCode}</strong>
+                <br/>{gettext('By clicking the below button, you will be redirected to the EDB BigAnimal authentication page in a new tab.')}
+              </Box>
+            </Box>}
+            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && <PrimaryButton onClick={authenticateBigAnimal} disabled={verificationIntiated}>
+              {gettext('Click here to authenticate yourself to EDB BigAnimal')}
+            </PrimaryButton>}
+            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && <Box className={classes.messageBox}>
+              <Box ></Box>
+            </Box>}
+          </Box>
+          {cloudProvider == CLOUD_PROVIDERS.AWS && <AwsCredentials cloudProvider={cloudProvider} nodeInfo={nodeInfo} nodeData={nodeData} setCloudDBCred={setCloudDBCred}/>}
+          { cloudProvider == CLOUD_PROVIDERS.AZURE &&
             <Box flexGrow={1}>
               <AzureCredentials cloudProvider={cloudProvider} setAzureCredData={setAzureCredData}/>
             </Box>}
-            <Box flexGrow={1}>
-              {cloudProvider == CLOUD_PROVIDERS.GOOGLE && <GoogleCredentials cloudProvider={cloudProvider} setGoogleCredData={setGoogleCredData}/>}
-            </Box>
-            <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
-          </WizardStep>
-          <WizardStep stepId={2} >
-            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 2 && <BigAnimalClusterType
+          <Box flexGrow={1}>
+            {cloudProvider == CLOUD_PROVIDERS.GOOGLE && <GoogleCredentials cloudProvider={cloudProvider} setGoogleCredData={setGoogleCredData}/>}
+          </Box>
+          <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
+        </WizardStep>
+        <WizardStep stepId={2} >
+          {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 2 && <BigAnimalClusterType
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setBigAnimalClusterTypeData={setBigAnimalClusterTypeData}
+            hostIP={hostIP}
+          /> }
+          <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
+        </WizardStep>
+        <WizardStep stepId={3} >
+          {cloudProvider == CLOUD_PROVIDERS.AWS && callRDSAPI == 3 && <AwsInstanceDetails
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setCloudInstanceDetails={setCloudInstanceDetails}
+            hostIP={hostIP} /> }
+          {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 3 && <BigAnimalInstance
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setBigAnimalInstanceData={setBigAnimalInstanceData}
+            hostIP={hostIP}
+            bigAnimalClusterTypeData={bigAnimalClusterTypeData}
+          /> }
+          {cloudProvider == CLOUD_PROVIDERS.AZURE && callRDSAPI == 3 && <AzureInstanceDetails
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setAzureInstanceData={setAzureInstanceData}
+            hostIP={hostIP}
+            azureInstanceData = {azureInstanceData}
+          /> }
+          {cloudProvider == CLOUD_PROVIDERS.GOOGLE && callRDSAPI == 3 && <GoogleInstanceDetails
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setGoogleInstanceData={setGoogleInstanceData}
+            hostIP={hostIP}
+            googleInstanceData = {googleInstanceData}
+          /> }
+          <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
+        </WizardStep>
+        <WizardStep stepId={4} >
+          {cloudProvider == CLOUD_PROVIDERS.AWS && <AwsDatabaseDetails
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setCloudDBDetails={setCloudDBDetails}
+          />
+          }
+          {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 4 && <BigAnimalDatabase
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setBigAnimalDatabaseData={setBigAnimalDatabaseData}
+            bigAnimalClusterTypeData={bigAnimalClusterTypeData}
+          />
+          }
+          {cloudProvider == CLOUD_PROVIDERS.AZURE && <AzureDatabaseDetails
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setAzureDatabaseData={setAzureDatabaseData}
+          />
+          }
+          {cloudProvider == CLOUD_PROVIDERS.GOOGLE && <GoogleDatabaseDetails
+            cloudProvider={cloudProvider}
+            nodeInfo={nodeInfo}
+            nodeData={nodeData}
+            setGoogleDatabaseData={setGoogleDatabaseData}
+          />
+          }
+        </WizardStep>
+        <WizardStep stepId={5} >
+          <Box className={classes.boxText}>{gettext('Please review the details before creating the cloud instance.')}</Box>
+          <Paper variant="outlined" elevation={0} className={classes.summaryContainer}>
+            {cloudProvider == CLOUD_PROVIDERS.AWS && callRDSAPI == 5 && <FinalSummary
               cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setBigAnimalClusterTypeData={setBigAnimalClusterTypeData}
-              hostIP={hostIP}
-            /> }
-            <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
-          </WizardStep>
-          <WizardStep stepId={3} >
-            {cloudProvider == CLOUD_PROVIDERS.AWS && callRDSAPI == 3 && <AwsInstanceDetails
-              cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setCloudInstanceDetails={setCloudInstanceDetails}
-              hostIP={hostIP} /> }
-            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 3 && <BigAnimalInstance
-              cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setBigAnimalInstanceData={setBigAnimalInstanceData}
-              hostIP={hostIP}
-              bigAnimalClusterTypeData={bigAnimalClusterTypeData}
-            /> }
-            {cloudProvider == CLOUD_PROVIDERS.AZURE && callRDSAPI == 3 && <AzureInstanceDetails
-              cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setAzureInstanceData={setAzureInstanceData}
-              hostIP={hostIP}
-              azureInstanceData = {azureInstanceData}
-            /> }
-            {cloudProvider == CLOUD_PROVIDERS.GOOGLE && callRDSAPI == 3 && <GoogleInstanceDetails
-              cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setGoogleInstanceData={setGoogleInstanceData}
-              hostIP={hostIP}
-              googleInstanceData = {googleInstanceData}
-            /> }
-            <FormFooterMessage type={errMsg[0]} message={errMsg[1]} onClose={onErrClose} />
-          </WizardStep>
-          <WizardStep stepId={4} >
-            {cloudProvider == CLOUD_PROVIDERS.AWS && <AwsDatabaseDetails
-              cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setCloudDBDetails={setCloudDBDetails}
+              instanceData={cloudInstanceDetails}
+              databaseData={cloudDBDetails}
             />
             }
-            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 4 && <BigAnimalDatabase
+            {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 5 && <FinalSummary
               cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setBigAnimalDatabaseData={setBigAnimalDatabaseData}
-              bigAnimalClusterTypeData={bigAnimalClusterTypeData}
+              instanceData={bigAnimalInstanceData}
+              databaseData={bigAnimalDatabaseData}
+              clusterTypeData={bigAnimalClusterTypeData}
             />
             }
-            {cloudProvider == CLOUD_PROVIDERS.AZURE && <AzureDatabaseDetails
+            {cloudProvider == CLOUD_PROVIDERS.AZURE && callRDSAPI == 5 && <FinalSummary
               cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setAzureDatabaseData={setAzureDatabaseData}
+              instanceData={azureInstanceData}
+              databaseData={azureDatabaseData}
             />
             }
-            {cloudProvider == CLOUD_PROVIDERS.GOOGLE && <GoogleDatabaseDetails
+            {cloudProvider == CLOUD_PROVIDERS.GOOGLE && callRDSAPI == 5 && <FinalSummary
               cloudProvider={cloudProvider}
-              nodeInfo={nodeInfo}
-              nodeData={nodeData}
-              setGoogleDatabaseData={setGoogleDatabaseData}
+              instanceData={googleInstanceData}
+              databaseData={googleDatabaseData}
             />
             }
-          </WizardStep>
-          <WizardStep stepId={5} >
-            <Box className={classes.boxText}>{gettext('Please review the details before creating the cloud instance.')}</Box>
-            <Paper variant="outlined" elevation={0} className={classes.summaryContainer}>
-              {cloudProvider == CLOUD_PROVIDERS.AWS && callRDSAPI == 5 && <FinalSummary
-                cloudProvider={cloudProvider}
-                instanceData={cloudInstanceDetails}
-                databaseData={cloudDBDetails}
-              />
-              }
-              {cloudProvider == CLOUD_PROVIDERS.BIGANIMAL && callRDSAPI == 5 && <FinalSummary
-                cloudProvider={cloudProvider}
-                instanceData={bigAnimalInstanceData}
-                databaseData={bigAnimalDatabaseData}
-                clusterTypeData={bigAnimalClusterTypeData}
-              />
-              }
-              {cloudProvider == CLOUD_PROVIDERS.AZURE && callRDSAPI == 5 && <FinalSummary
-                cloudProvider={cloudProvider}
-                instanceData={azureInstanceData}
-                databaseData={azureDatabaseData}
-              />
-              }
-              {cloudProvider == CLOUD_PROVIDERS.GOOGLE && callRDSAPI == 5 && <FinalSummary
-                cloudProvider={cloudProvider}
-                instanceData={googleInstanceData}
-                databaseData={googleDatabaseData}
-              />
-              }
-            </Paper>
-          </WizardStep>
-        </Wizard>
-      </>
+          </Paper>
+        </WizardStep>
+      </Wizard>
     </CloudWizardEventsContext.Provider>
   );
 }

web/pgadmin/misc/cloud/static/js/azure.js

@@ -61,7 +61,7 @@ export function AzureCredentials(props) {
           })
           .catch((error) => {
             _eventBus.fireEvent('SET_ERROR_MESSAGE_FOR_CLOUD_WIZARD',[MESSAGE_TYPE.ERROR, gettext(`Error while verifying Microsoft Azure: ${error}`)]);
-            reject(false);
+            reject(new Error(gettext(error)));
           });
         });
       },

web/pgadmin/misc/cloud/static/js/biganimal.js

@@ -205,7 +205,7 @@ export function validateBigAnimal() {
         }
       })
       .catch((error) => {
-        reject(`Error while fetching EDB BigAnimal verification URI: ${error.response.data.errormsg}`);
+        reject(new Error(`Error while fetching EDB BigAnimal verification URI: ${error.response.data.errormsg}`));
       });
   });
 }

web/pgadmin/misc/cloud/static/js/google.js

@@ -62,7 +62,7 @@ export function GoogleCredentials(props) {
           })
           .catch((error) => {
             _eventBus.fireEvent('SET_ERROR_MESSAGE_FOR_CLOUD_WIZARD',[MESSAGE_TYPE.ERROR, gettext(`Error while authentication: ${error}`)]);
-            reject(false);
+            reject(new Error(gettext(`Error while authentication: ${error}`)));
           });
         });
       },
@@ -201,7 +201,7 @@ GoogleInstanceDetails.propTypes = {
 
 // Google Database Details
 export function GoogleDatabaseDetails(props) {
-  const [gooeleDBInstance, setGoogleDBInstance] = React.useState();
+  const [googleDBInstance, setGoogleDBInstance] = React.useState();
   const classes = useStyles();
 
   React.useMemo(() => {
@@ -220,7 +220,7 @@ export function GoogleDatabaseDetails(props) {
     formType={'dialog'}
     getInitData={() => { /*This is intentional (SonarQube)*/ }}
     viewHelperProps={{ mode: 'create' }}
-    schema={gooeleDBInstance}
+    schema={googleDBInstance}
     showFooter={false}
     isTabView={false}
     onDataChange={(isChanged, changedData) => {

web/pgadmin/misc/dependencies/static/js/Dependencies.jsx

@@ -59,7 +59,7 @@ function parseData(data, node) {
     if (element.icon == null || element.icon == '') {
       if (node) {
         element.icon = _.isFunction(node['node_image'])
-          ? node['node_image'].apply(node, [null, null])
+          ? node['node_image'](null, null)
           : node['node_image'] || 'icon-' + element.type;
       } else {
         element.icon = 'icon-' + element.type;

web/pgadmin/misc/dependents/static/js/Dependents.jsx

@@ -59,7 +59,7 @@ function parseData(data, node) {
     if (element.icon == null || element.icon == '') {
       if (node) {
         element.icon = _.isFunction(node['node_image'])
-          ? node['node_image'].apply(node, [null, null])
+          ? node['node_image'](null, null)
           : node['node_image'] || 'icon-' + element.type;
       } else {
         element.icon = 'icon-' + element.type;

web/pgadmin/misc/properties/CollectionNodeProperties.jsx

@@ -112,9 +112,7 @@ export default function CollectionNodeProperties({
       selItem = pgAdmin.Browser.tree.selected(),
       selectedItemData = selItem ? pgAdmin.Browser.tree.itemData(selItem) : null,
       selNode = selectedItemData && pgAdmin.Browser.Nodes[selectedItemData._type],
-      url = undefined,
-      msg = undefined,
-      title = undefined;
+      url, msg, title;
 
     if (selNode?.type == 'coll-constraints') {
       // In order to identify the constraint type, the type should be passed to the server
@@ -206,7 +204,7 @@ export default function CollectionNodeProperties({
       setLoaderText(gettext('Loading...'));
 
       if (!_.isUndefined(nodeObj.getSchema)) {
-        schemaRef.current = nodeObj.getSchema?.call(nodeObj, treeNodeInfo, nodeData);
+        schemaRef.current = nodeObj.getSchema?.(treeNodeInfo, nodeData);
         schemaRef.current?.fields.forEach((field) => {
           if (node.columns.indexOf(field.id) > -1) {
             if (field.label.indexOf('?') > -1) {

web/pgadmin/misc/properties/ObjectNodeProperties.jsx

@@ -42,7 +42,7 @@ export default function ObjectNodeProperties({panelId, node, treeNodeInfo, nodeD
   let warnOnCloseFlag = true;
   const confirmOnCloseReset = usePreferences().getPreferencesForModule('browser').confirm_on_properties_close;
   let updatedData =  ['table', 'partition'].includes(nodeType) && !_.isEmpty(nodeData.rows_cnt) ? {rows_cnt: nodeData.rows_cnt} : undefined;
-  let schema = node.getSchema.call(node, treeNodeInfo, nodeData);
+  let schema = node.getSchema(treeNodeInfo, nodeData);
 
   // We only have two actionTypes, 'create' and 'edit' to initiate the dialog,
   // so if isActionTypeCopy is true, we should revert back to "create" since