mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2025-02-25 18:55:31 -06:00
Fixed following code smells reported by SonarQube:
1) Remove this redundant jump. 2) Remove this commented out code. 3) Variables should not be shadowed.
This commit is contained in:
@@ -373,8 +373,6 @@ define('misc.bgprocess', [
|
||||
ev = ev || window.event;
|
||||
ev.cancelBubble = true;
|
||||
ev.stopPropagation();
|
||||
|
||||
return;
|
||||
});
|
||||
|
||||
// On Click event to stop the process.
|
||||
|
||||
@@ -142,9 +142,7 @@ module.exports = Alertify.dialog('fileSelectionDlg', function() {
|
||||
Alertify.pgDialogBuild.apply(this);
|
||||
},
|
||||
hooks: {
|
||||
onshow: function() {
|
||||
// $(this.elements.body).addClass('pgadmin-storage-body');
|
||||
},
|
||||
onshow: function() {/* This is intentional (SonarQube) */},
|
||||
},
|
||||
};
|
||||
});
|
||||
|
||||
@@ -1205,7 +1205,6 @@ define([
|
||||
});
|
||||
|
||||
}
|
||||
//input_object.set_cap(data_cap);
|
||||
})
|
||||
.fail(function() {
|
||||
$('.storage_dialog #uploader .input-path').prop('disabled', false);
|
||||
@@ -1448,7 +1447,6 @@ define([
|
||||
}
|
||||
// Save it in preference
|
||||
save_show_hidden_file_option(tmp_data['is_checked'], pgAdmin.FileUtils.transId);
|
||||
return;
|
||||
};
|
||||
}
|
||||
|
||||
@@ -1635,14 +1633,12 @@ define([
|
||||
if (config.options.dialog_type == 'create_file') {
|
||||
var status = checkPermission(path);
|
||||
if (status) {
|
||||
//$('.file_manager').trigger('enter-key');
|
||||
$('.file_manager_ok').trigger('click');
|
||||
}
|
||||
} else if (config.options.dialog_type == 'select_file') {
|
||||
var file_status = getFileInfo(path);
|
||||
if (file_status) {
|
||||
$('.file_manager_ok').trigger('click');
|
||||
//$('.file_manager').trigger('enter-key');
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user