IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed following code smells reported by SonarQube:

Browse Source 
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
This commit is contained in:
Akshay Joshi
2022-01-21 18:53:48 +05:30
parent 12d6271b13
commit 343c3ee49c
50 changed files with 130 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
web/pgadmin/static/js/SchemaView/MappedControl.jsx
View File

@@ -23,15 +23,15 @@ import { SelectRefresh} from '../components/SelectRefresh';
function MappedFormControlBase({type, value, id, onChange, className, visible, inputRef, noLabel, ...props}) {
const name = id;
const onTextChange = useCallback((e) => {
let value = e;
let val = e;
if(e && e.target) {
value = e.target.value;
val = e.target.value;
}
onChange && onChange(value);
onChange && onChange(val);
}, []);
const onSqlChange = useCallback((value) => {
onChange && onChange(value);
const onSqlChange = useCallback((changedValue) => {
onChange && onChange(changedValue);
}, []);
if(!visible) {
@@ -103,12 +103,12 @@ MappedFormControlBase.propTypes = {
function MappedCellControlBase({cell, value, id, optionsLoaded, onCellChange, visible, reRenderRow,...props}) {
const name = id;
const onTextChange = useCallback((e) => {
let value = e;
let val = e;
if(e && e.target) {
value = e.target.value;
val = e.target.value;
}
onCellChange && onCellChange(value);
onCellChange && onCellChange(val);
}, []);
/* Some grid cells are based on options selected in other cells.