IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-01-10 08:04:36 -06:00
Code Issues Packages Projects Releases Wiki Activity

Changes in accesskey display code to reflect all supported browser+OS combinations. #5022

Browse Source
This commit is contained in:
Aditya Toshniwal 2023-03-29 13:49:11 +05:30 committed by GitHub
parent a607ab2d94
commit 36d18ba5cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
web/pgadmin/static/js/components/ShortcutTitle.jsx
View File

@ -25,35 +25,22 @@ const useStyles = makeStyles((theme)=>({
}));
export function getBrowserAccesskey() {
/* Ref: https://github.com/tillsanders/access-key-label-polyfill/ */
/* Ref: https://www.w3schools.com/tags/att_accesskey.asp */
let ua = window.navigator.userAgent;
// macOS
if (ua.match(/macintosh/i)) {
// Firefox
if (ua.match(/firefox/i)) {
const firefoxVersion = ua.match(/firefox[\s/](\d+)/i);
// Firefox < v14
if (firefoxVersion[1] && parseInt(firefoxVersion[1], 10) < 14) {
return ['Ctrl'];
}
}
return ['Option', 'Ctrl'];
return ['Ctrl', 'Option'];
}
// Internet Explorer / Edge
if (ua.match(/msie|trident/i) || ua.match(/\sedg/i)) {
// Windows / Linux
if (ua.match(/windows/i) || ua.match(/linux/i)) {
if(ua.match(/firefox/i)) {
return ['Alt', 'Shift'];
}
return ['Alt'];
}
// iOS / iPadOS
if (ua.match(/(ipod|iphone|ipad)/i)) {
// accesskeyLabel is supported > v14, but we're not checking for versions here, since we use
// feature support detection
return ['Option', 'Ctrl'];
}
// Fallback
// Note: Apparently, Chrome for Android is not even supporting accesskey, so be prepared.
return [gettext('Accesskey')];
}