IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed feature test failures occurring due to tree changes.

Browse Source
This commit is contained in:
Yogesh Mahajan 2023-01-04 10:44:22 +05:30 committed by GitHub
parent e987b3074d
commit 3841bc5253
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/regression/feature_tests/xss_checks_panels_and_query_tool_test.py
View File

@ -75,6 +75,7 @@ class CheckForXssFeatureTest(BaseFeatureTest):
while retry > 0: while retry > 0:
try: try:
self.page.refresh_page() self.page.refresh_page()
self.page.wait_for_spinner_to_disappear()
self._tables_node_expandable() self._tables_node_expandable()
self._check_xss_in_dependents_tab() self._check_xss_in_dependents_tab()
retry = 0 retry = 0
@ -112,6 +113,10 @@ class CheckForXssFeatureTest(BaseFeatureTest):
table_node = self.page.check_if_element_exists_with_scroll( table_node = self.page.check_if_element_exists_with_scroll(
TreeAreaLocators.table_node(self.test_table_name)) TreeAreaLocators.table_node(self.test_table_name))
self.assertTrue(bool(table_node),
self.test_table_name + ' table node not found.')
table_node.click() table_node.click()
def _check_xss_in_browser_tree(self): def _check_xss_in_browser_tree(self):

4
web/regression/feature_tests/xss_checks_pgadmin_debugger_test.py
View File

@ -65,6 +65,10 @@ class CheckDebuggerForXssFeatureTest(BaseFeatureTest):
self.test_db, 'public', "Functions") self.test_db, 'public', "Functions")
function_node = self.page.check_if_element_exists_with_scroll( function_node = self.page.check_if_element_exists_with_scroll(
TreeAreaLocators.function_node(self.function_name + "()")) TreeAreaLocators.function_node(self.function_name + "()"))
self.assertTrue(bool(function_node),
self.function_name + ' function node not found.')
function_node.click() function_node.click()
def _debug_function(self): def _debug_function(self):

2
web/regression/feature_tests/xss_checks_roles_control_test.py
View File

@ -65,6 +65,8 @@ class CheckRoleMembershipControlFeatureTest(BaseFeatureTest):
"Server", self.server['name'], self.server['db_password'], "Server", self.server['name'], self.server['db_password'],
'Login/Group Roles'): 'Login/Group Roles'):
retry = 0 retry = 0
else:
retry -= 1
role_node = self.page.check_if_element_exists_with_scroll( role_node = self.page.check_if_element_exists_with_scroll(
TreeAreaLocators.role_node(role)) TreeAreaLocators.role_node(role))

6
web/regression/feature_utils/pgadmin_page.py
View File

@ -337,7 +337,7 @@ class PgadminPage:
self.click_modal('Yes') self.click_modal('Yes')
time.sleep(1) time.sleep(1)
else: else:
print("%s Server is not removed", server_config['name'], print(server_config['name'] + " server is not removed",
file=sys.stderr) file=sys.stderr)
def click_to_expand_tree_node(self, tree_node_web_element, def click_to_expand_tree_node(self, tree_node_web_element,
@ -580,7 +580,7 @@ class PgadminPage:
server_child_expanded = self.click_to_expand_tree_node( server_child_expanded = self.click_to_expand_tree_node(
child_node_ele, server_child_node_exp_status_xpath) child_node_ele, server_child_node_exp_status_xpath)
if not server_child_expanded: if not server_child_expanded:
print("Child not is not expanded after clicking ", print("Child is not expanded after clicking ",
file=sys.stderr) file=sys.stderr)
else: else:
print("The server/previous nodes not expanded", file=sys.stderr) print("The server/previous nodes not expanded", file=sys.stderr)
@ -1154,7 +1154,7 @@ class PgadminPage:
else: else:
break break
else: else:
print("check_if_element_exists_with_scroll > Element NOT found", print("check_if_element_exists_with_scroll > Element NOT found" +
xpath, file=sys.stderr) xpath, file=sys.stderr)
return False return False