IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2024-11-26 02:30:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed an issue where AutoComplete was not working correctly due to incorrect regex. #5473

Browse Source
This commit is contained in:
Akshay Joshi 2022-11-07 13:59:18 +05:30
parent 6bc5808c53
commit 398675597a
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/en_US/release_notes_6_16.rst
View File

@ -25,6 +25,7 @@ Housekeeping
Bug fixes Bug fixes
********* *********
| `Issue #2174 <https://github.com/pgadmin-org/pgadmin4/issues/2174>`_ - Ensure that the browser tree should auto scroll to the selected node when expanding the server node.
| `Issue #4841 <https://github.com/pgadmin-org/pgadmin4/issues/4841>`_ - Use SocketIO instead of REST for schema diff compare. | `Issue #4841 <https://github.com/pgadmin-org/pgadmin4/issues/4841>`_ - Use SocketIO instead of REST for schema diff compare.
| `Issue #5066 <https://github.com/pgadmin-org/pgadmin4/issues/5066>`_ - Ensure that users can use custom characters as CSV field separators/CSV quotes when downloading query results. | `Issue #5066 <https://github.com/pgadmin-org/pgadmin4/issues/5066>`_ - Ensure that users can use custom characters as CSV field separators/CSV quotes when downloading query results.
| `Issue #5058 <https://github.com/pgadmin-org/pgadmin4/issues/5058>`_ - Ensure that the save button should be disabled by default on the Sort/Filter dialog in the query tool. | `Issue #5058 <https://github.com/pgadmin-org/pgadmin4/issues/5058>`_ - Ensure that the save button should be disabled by default on the Sort/Filter dialog in the query tool.
@ -37,4 +38,5 @@ Bug fixes
| `Issue #5429 <https://github.com/pgadmin-org/pgadmin4/issues/5429>`_ - Fixed an issue where parameters for roles were not visible. | `Issue #5429 <https://github.com/pgadmin-org/pgadmin4/issues/5429>`_ - Fixed an issue where parameters for roles were not visible.
| `Issue #5455 <https://github.com/pgadmin-org/pgadmin4/issues/5455>`_ - Fixed an issue where the dependents tab wasn't working for PG 15. | `Issue #5455 <https://github.com/pgadmin-org/pgadmin4/issues/5455>`_ - Fixed an issue where the dependents tab wasn't working for PG 15.
| `Issue #5458 <https://github.com/pgadmin-org/pgadmin4/issues/5458>`_ - Ensure that the browser path column in the search object shows the complete path. | `Issue #5458 <https://github.com/pgadmin-org/pgadmin4/issues/5458>`_ - Ensure that the browser path column in the search object shows the complete path.
| `Issue #5473 <https://github.com/pgadmin-org/pgadmin4/issues/5473>`_ - Fixed an issue where AutoComplete was not working correctly due to incorrect regex.
| `Issue #5475 <https://github.com/pgadmin-org/pgadmin4/issues/5475>`_ - Fixed an issue where the 'Confirm on close or refresh' setting was ignored when closing the query/ERD tool opened in the new tab. | `Issue #5475 <https://github.com/pgadmin-org/pgadmin4/issues/5475>`_ - Fixed an issue where the 'Confirm on close or refresh' setting was ignored when closing the query/ERD tool opened in the new tab.

2
web/pgadmin/static/js/components/CodeMirror.jsx
View File

@ -468,7 +468,7 @@ export default function CodeMirror({currEditor, name, value, options, events, re
let pref = pgWindow?.pgAdmin?.Browser?.get_preferences_for_module('sqleditor') || {}; let pref = pgWindow?.pgAdmin?.Browser?.get_preferences_for_module('sqleditor') || {};
if (autocomplete && pref.autocomplete_on_key_press) { if (autocomplete && pref.autocomplete_on_key_press) {
editor.current.on('keyup', (cm, event)=>{ editor.current.on('keyup', (cm, event)=>{
if (!cm.state.completionActive && (event.key == 'Backspace' || /^[ -~]{1}$'/.test(event.key))) { if (!cm.state.completionActive && (event.key == 'Backspace' || /^[ -~]{1}$/.test(event.key))) {
OrigCodeMirror.commands.autocomplete(cm, null, {completeSingle: false}); OrigCodeMirror.commands.autocomplete(cm, null, {completeSingle: false});
} }
}); });