From 42a3b784ba20cc41a8a620d445ee254634000f52 Mon Sep 17 00:00:00 2001 From: Murtuza Zabuawala Date: Tue, 24 May 2016 23:55:43 +0530 Subject: [PATCH] Fixes #1135 - resolved an issue dropping a role with special characters. --- web/pgadmin/browser/server_groups/servers/roles/__init__.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/web/pgadmin/browser/server_groups/servers/roles/__init__.py b/web/pgadmin/browser/server_groups/servers/roles/__init__.py index a0c8097df..126def1af 100644 --- a/web/pgadmin/browser/server_groups/servers/roles/__init__.py +++ b/web/pgadmin/browser/server_groups/servers/roles/__init__.py @@ -429,6 +429,9 @@ rolmembership:{ ) self.conn = self.manager.connection() + driver = get_driver(PG_DEFAULT_DRIVER) + self.qtIdent = driver.qtIdent + if not self.conn.connected(): return precondition_required( _("Connection to the server has been lost!") @@ -660,7 +663,7 @@ rolmembership:{ def drop(self, gid, sid, rid): status, res = self.conn.execute_2darray( - "DROP ROLE {0};".format(self.role) + "DROP ROLE {0};".format(self.qtIdent(self.conn, self.role)) ) if not status: return internal_server_error(