IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix an issue in graphical explain plan where query tool crashes when the plan has parallel workers details and sort node is clicked for details. #6858

Browse Source
This commit is contained in:
Aditya Toshniwal 2023-10-16 11:40:43 +05:30
parent ce372a73bf
commit 47e734dbf2
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/en_US/release_notes_7_8.rst
View File

@ -45,4 +45,5 @@ Bug fixes
| `Issue #6790 <https://github.com/pgadmin-org/pgadmin4/issues/6790>`_ - Ensure that the backup works properly for PG 16 on the latest docker image. | `Issue #6790 <https://github.com/pgadmin-org/pgadmin4/issues/6790>`_ - Ensure that the backup works properly for PG 16 on the latest docker image.
| `Issue #6799 <https://github.com/pgadmin-org/pgadmin4/issues/6799>`_ - Fixed an issue where the user is unable to select objects on the backup dialog due to tree flickering. | `Issue #6799 <https://github.com/pgadmin-org/pgadmin4/issues/6799>`_ - Fixed an issue where the user is unable to select objects on the backup dialog due to tree flickering.
| `Issue #6836 <https://github.com/pgadmin-org/pgadmin4/issues/6836>`_ - Fixed an issue where non-super PostgreSQL users are not able to terminate their own connections from dashboard. | `Issue #6836 <https://github.com/pgadmin-org/pgadmin4/issues/6836>`_ - Fixed an issue where non-super PostgreSQL users are not able to terminate their own connections from dashboard.
| `Issue #6851 <https://github.com/pgadmin-org/pgadmin4/issues/6851>`_ - Fix an issue where scale in columns is not allowed to have value as 0 or below. | `Issue #6851 <https://github.com/pgadmin-org/pgadmin4/issues/6851>`_ - Fix an issue where scale in columns is not allowed to have value as 0 or below.
| `Issue #6858 <https://github.com/pgadmin-org/pgadmin4/issues/6858>`_ - Fix an issue in graphical explain plan where query tool crashes when the plan has parallel workers details and sort node is clicked for details.

15
web/pgadmin/static/js/Explain/Graphical.jsx
View File

@ -190,14 +190,23 @@ function NodeDetails({plan, download=false}) {
return <> return <>
{Object.keys(plan).map((key)=>{ {Object.keys(plan).map((key)=>{
if(AUXILIARY_KEYS.indexOf(key) != -1) { if(AUXILIARY_KEYS.indexOf(key) != -1) {
return <></>; return null;
}
let value = plan[key];
if(_.isArray(value)) {
value = value.map((v)=>{
if(typeof(v) == 'object') {
return JSON.stringify(v, null, 2);
}
return v;
});
} }
if(download) { if(download) {
return `${key}: ${plan[key]}\n`; return `${key}: ${value}\n`;
} else { } else {
return (<tr key={key}> return (<tr key={key}>
<td>{key}</td> <td>{key}</td>
<td>{plan[key]}</td> <td>{value}</td>
</tr>); </tr>);
} }
})} })}