IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed following SonarQube issues:

Browse Source 
- Remove this assignment to the local variable, the value is never used.
  - Rename local variables to match the regular expression
  - Add logic to this except clause or eliminate it and rethrow the exception automatically.
  - Rename fields to match the regular expression
  - Extract this nested conditional expression into an independent statement.
  - Change this default value to "None" and initialize this parameter inside the function/method.
  - Update this function so that its implementation is not identical to __repr__
  - Refactor this method to not always return the same value
  - Reraise this exception to stop the application as the user expects
  - Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
  - Remove this redundant continue.
  - Remove this unused function declaration
  - Remove this identity check; it will always be False.
This commit is contained in:
Aditya Toshniwal
2020-08-03 12:59:51 +05:30
committed by Akshay Joshi
parent eb2c554601
commit 536593bf8a
19 changed files with 74 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/pgadmin/utils/session.py
View File

@@ -103,11 +103,11 @@ class SessionManager(object):
class CachingSessionManager(SessionManager):
def __init__(self, parent, num_to_store, skip_paths=[]):
def __init__(self, parent, num_to_store, skip_paths=None):
self.parent = parent
self.num_to_store = num_to_store
self._cache = OrderedDict()
self.skip_paths = skip_paths
self.skip_paths = [] if skip_paths is None else skip_paths
def _normalize(self):
if len(self._cache) > self.num_to_store:
@@ -187,13 +187,13 @@ class CachingSessionManager(SessionManager):
class FileBackedSessionManager(SessionManager):
def __init__(self, path, secret, disk_write_delay, skip_paths=[]):
def __init__(self, path, secret, disk_write_delay, skip_paths=None):
self.path = path
self.secret = secret
self.disk_write_delay = disk_write_delay
if not os.path.exists(self.path):
os.makedirs(self.path)
self.skip_paths = skip_paths
self.skip_paths = [] if skip_paths is None else skip_paths
def exists(self, sid):
fname = os.path.join(self.path, sid)