mirror of
https://github.com/pgadmin-org/pgadmin4.git
synced 2025-02-25 18:55:31 -06:00
Fixed following SonarQube issues:
- Remove this assignment to the local variable, the value is never used. - Rename local variables to match the regular expression - Add logic to this except clause or eliminate it and rethrow the exception automatically. - Rename fields to match the regular expression - Extract this nested conditional expression into an independent statement. - Change this default value to "None" and initialize this parameter inside the function/method. - Update this function so that its implementation is not identical to __repr__ - Refactor this method to not always return the same value - Reraise this exception to stop the application as the user expects - Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode. - Remove this redundant continue. - Remove this unused function declaration - Remove this identity check; it will always be False.
This commit is contained in:
committed by
Akshay Joshi
parent
eb2c554601
commit
536593bf8a
@@ -1129,9 +1129,9 @@ def check_binary_path_or_skip_test(cls, utility_name):
|
||||
cls.server['default_binary_paths'][cls.server['type']],
|
||||
utility_name
|
||||
)
|
||||
ret_val = does_utility_exist(binary_path)
|
||||
if ret_val is not None:
|
||||
cls.skipTest(ret_val)
|
||||
retVal = does_utility_exist(binary_path)
|
||||
if retVal is not None:
|
||||
cls.skipTest(retVal)
|
||||
|
||||
|
||||
def get_watcher_dialogue_status(self):
|
||||
|
||||
@@ -819,6 +819,7 @@ if __name__ == '__main__':
|
||||
app_starter_local.stop_app()
|
||||
if handle_cleanup:
|
||||
handle_cleanup()
|
||||
raise
|
||||
else:
|
||||
print(
|
||||
"\n============= Either Selenium Grid is NOT up OR"
|
||||
@@ -840,6 +841,7 @@ if __name__ == '__main__':
|
||||
except SystemExit:
|
||||
if handle_cleanup:
|
||||
handle_cleanup()
|
||||
raise
|
||||
print_test_results()
|
||||
|
||||
# Stop code coverage
|
||||
|
||||
Reference in New Issue
Block a user