IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2024-12-25 08:21:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed sizing issue of help dialog for Query Tool and ERD Tool when open in the new browser tab. Fixes #6333

Browse Source
This commit is contained in:
Rahul Shirsat 2021-04-06 15:26:25 +05:30 committed by Akshay Joshi
parent c1ba645dce
commit 585ba81492
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_5_2.rst
View File

@ -22,6 +22,7 @@ Bug fixes
| `Issue #6076 <https://redmine.postgresql.org/issues/6076>`_ - Fixed an issue where correct error not thrown while importing servers and JSON file has incorrect/insufficient keys.
| `Issue #6293 <https://redmine.postgresql.org/issues/6293>`_ - Fixed an issue where the procedure creation is failed when providing the Volatility option.
| `Issue #6327 <https://redmine.postgresql.org/issues/6327>`_ - Ensure that while comparing domains check function dependencies should be considered in schema diff.
| `Issue #6333 <https://redmine.postgresql.org/issues/6333>`_ - Fixed sizing issue of help dialog for Query Tool and ERD Tool when open in the new browser tab.
| `Issue #6338 <https://redmine.postgresql.org/issues/6338>`_ - Added missing dependency 'xdg-utils' for the desktop packages in RPM and Debian.
| `Issue #6344 <https://redmine.postgresql.org/issues/6344>`_ - Fixed cannot unpack non-iterable response object error when selecting any partition.
| `Issue #6356 <https://redmine.postgresql.org/issues/6356>`_ - Mark the Apache HTTPD config file as such in the web DEB and RPM packages.

7
web/pgadmin/browser/static/js/browser.js
View File

@ -907,7 +907,12 @@ define('pgadmin.browser', [
window.open(fullUrl, 'postgres_help');
} else if(type == 'dialog_help') {
window.open(url, 'pgadmin_help');
if (pgWindow && pgWindow.default) {
pgWindow.default.open(url, 'pgadmin_help');
}
else {
window.open(url, 'pgadmin_help');
}
}
$('#live-search-field').focus();
},

7
web/pgadmin/tools/erd/static/js/erd_tool/ui_components/BodyWidget.jsx
View File

@ -412,7 +412,12 @@ export default class BodyWidget extends React.Component {
onHelpClick() {
let url = url_for('help.static', {'filename': 'erd_tool.html'});
window.open(url, 'pgadmin_help');
if (this.props.pgWindow) {
this.props.pgWindow.open(url, 'pgadmin_help');
}
else {
window.open(url, 'pgadmin_help');
}
}
onLoadDiagram() {