IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed an issue where the Save button is enabled for functions/procedures by default when open the properties dialog. Fixes #5073

Browse Source
This commit is contained in:
Rahul Shirsat 2021-02-26 13:15:29 +05:30 committed by Akshay Joshi
parent 4fc36a9053
commit 5a5a9314f3
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_5_1.rst
View File

@ -18,4 +18,5 @@ Bug fixes
********* *********
| `Issue #4959 <https://redmine.postgresql.org/issues/4959>`_ - Fixed an issue where the properties tab for collection nodes is unresponsive after switching the tabs. | `Issue #4959 <https://redmine.postgresql.org/issues/4959>`_ - Fixed an issue where the properties tab for collection nodes is unresponsive after switching the tabs.
| `Issue #5073 <https://redmine.postgresql.org/issues/5073>`_ - Fixed an issue where the Save button is enabled for functions/procedures by default when open the properties dialog.
| `Issue #6159 <https://redmine.postgresql.org/issues/6159>`_ - Ensure that the user should be able to kill the session from Dashboard if the user has a 'pg_signal_backend' role. | `Issue #6159 <https://redmine.postgresql.org/issues/6159>`_ - Ensure that the user should be able to kill the session from Dashboard if the user has a 'pg_signal_backend' role.

7
web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js
View File

@ -179,7 +179,7 @@ define('pgadmin.node.function', [
proiswindow: undefined, /* Window Function ? */ proiswindow: undefined, /* Window Function ? */
proparallel: undefined, /* Parallel mode */ proparallel: undefined, /* Parallel mode */
procost: undefined, /* Estimated execution Cost */ procost: undefined, /* Estimated execution Cost */
prorows: undefined, /* Estimated number of rows */ prorows: 0, /* Estimated number of rows */
proleakproof: undefined, proleakproof: undefined,
prosupportfunc: undefined, /* Support function */ prosupportfunc: undefined, /* Support function */
arguments: [], arguments: [],
@ -306,7 +306,7 @@ define('pgadmin.node.function', [
select2: {allowClear: false}, select2: {allowClear: false},
},{ },{
id: 'procost', label: gettext('Estimated cost'), group: gettext('Options'), id: 'procost', label: gettext('Estimated cost'), group: gettext('Options'),
cell:'string', type: 'text', readonly: 'isReadonly', deps: ['lanname'], cell:'string', type: 'text', readonly: 'isReadonly', deps: ['lanname'], disabled: 'isDisabled',
},{ },{
id: 'prorows', label: gettext('Estimated rows'), type: 'text', id: 'prorows', label: gettext('Estimated rows'), type: 'text',
deps: ['proretset'], visible: 'isVisible', readonly: 'isReadonly', deps: ['proretset'], visible: 'isVisible', readonly: 'isReadonly',
@ -462,9 +462,6 @@ define('pgadmin.node.function', [
if(m.get('proretset') == true) { if(m.get('proretset') == true) {
return false; return false;
} }
setTimeout(function() {
m.set('prorows', 0);
}, 10);
return true; return true;
default: default:
return false; return false;