IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix some code inspection complaints

Browse Source
This commit is contained in:
Dave Page
2017-03-25 18:49:25 -04:00
parent a6fa35789c
commit 6152d73f13
10 changed files with 42 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
View File

@@ -529,7 +529,7 @@ class FunctionView(PGChildNodeView, DataTypeReader):
dif = len(proargmodes_fltrd) - len(proargdefaultvals)
while (dif > 0):
proargdefaultvals.insert(0, '')
dif = dif - 1
dif -= 1
# Prepare list of Argument list dict to be displayed in the Data Grid.
params = {"arguments": [

2
web/pgadmin/browser/server_groups/servers/databases/schemas/packages/edbfuncs/__init__.py
View File

@@ -431,7 +431,7 @@ It may have been removed by another user or moved to another schema.
dif = len(proargmodes_fltrd) - len(proargdefaultvals)
while (dif > 0):
proargdefaultvals.insert(0, '')
dif = dif - 1
dif -= 1
# Prepare list of Argument list dict to be displayed in the Data Grid.
params = {"arguments": [

26
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
View File

@@ -2544,25 +2544,25 @@ class TableView(PGChildNodeView, DataTypeReader, VacuumSettings):
# 'options' we need true/false to render switch ASC(false)/DESC(true)
columns = []
cols = []
for row in rset['rows']:
for col_row in rset['rows']:
# We need all data as collection for ColumnsModel
cols_data = {
'colname': row['attdef'].strip('"'),
'collspcname': row['collnspname'],
'op_class': row['opcname'],
'colname': col_row['attdef'].strip('"'),
'collspcname': col_row['collnspname'],
'op_class': col_row['opcname'],
}
if row['options'][0] == 'DESC':
if col_row['options'][0] == 'DESC':
cols_data['sort_order'] = True
columns.append(cols_data)
# We need same data as string to display in properties window
# If multiple column then separate it by colon
cols_str = row['attdef']
if row['collnspname']:
cols_str += ' COLLATE ' + row['collnspname']
if row['opcname']:
cols_str += ' ' + row['opcname']
if row['options'][0] == 'DESC':
cols_str = col_row['attdef']
if col_row['collnspname']:
cols_str += ' COLLATE ' + col_row['collnspname']
if col_row['opcname']:
cols_str += ' ' + col_row['opcname']
if col_row['options'][0] == 'DESC':
cols_str += ' DESC'
cols.append(cols_str)
@@ -2634,8 +2634,8 @@ class TableView(PGChildNodeView, DataTypeReader, VacuumSettings):
# 'tgattr' contains list of columns from table used in trigger
columns = []
for row in rset['rows']:
columns.append({'column': row['name']})
for col_row in rset['rows']:
columns.append({'column': col_row['name']})
data['columns'] = columns