IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed handling of default parameters ordering in functions. Fixes #2350

Browse Source
This commit is contained in:
Murtuza Zabuawala
2017-04-25 18:40:44 +05:30
committed by Akshay Joshi
parent 1ce1f216ca
commit 6790bfd0c0
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
View File

@@ -479,6 +479,22 @@ class FunctionView(PGChildNodeView, DataTypeReader):
'i': 'IN', 'o': 'OUT', 'b': 'INOUT', 'v': 'VARIADIC', 't': 'TABLE'
}
# We need to put default parameter at proper location in list
# Total number of default parameters
total_default_parameters = len(proargdefaultvals)
# Total number of parameters
total_parameters = len(proargtypes)
# Parameters which do not have default parameters
non_default_parameters = total_parameters - total_default_parameters
# only if we have at least one parameter with default value
if total_default_parameters > 0 and non_default_parameters > 0:
for idx in range(non_default_parameters):
# Set null value for parameter non-default parameter
proargdefaultvals.insert(idx, '')
# The proargtypes doesn't give OUT params, so we need to fetch
# those from database explicitly, below code is written for this
# purpose.