From 695c008245a5e749d7fb22131f0e52f821a78d43 Mon Sep 17 00:00:00 2001 From: Anil Sahoo Date: Mon, 6 Nov 2023 11:55:29 +0530 Subject: [PATCH] Remove the max length of 255 from password exec command in server configuration dialog. #6877 --- web/migrations/versions/44926ac97232_.py | 39 +++++++++++++++++++ .../servers/static/js/server.ui.js | 2 +- web/pgadmin/model/__init__.py | 2 +- 3 files changed, 41 insertions(+), 2 deletions(-) create mode 100644 web/migrations/versions/44926ac97232_.py diff --git a/web/migrations/versions/44926ac97232_.py b/web/migrations/versions/44926ac97232_.py new file mode 100644 index 000000000..9d763792a --- /dev/null +++ b/web/migrations/versions/44926ac97232_.py @@ -0,0 +1,39 @@ +########################################################################## +# +# pgAdmin 4 - PostgreSQL Tools +# +# Copyright (C) 2013 - 2023, The pgAdmin Development Team +# This software is released under the PostgreSQL Licence +# +########################################################################## + +"""Update DB to version 38 + +Removed max length from passexec_cmd column of server configuration. + +Revision ID: 44926ac97232 +Revises: 44b9ce549393 +Create Date: 2023-11-03 19:56:51.277160 + +""" +import sqlalchemy as sa +from alembic import op + +# revision identifiers, used by Alembic. +revision = '44926ac97232' +down_revision = '44b9ce549393' +branch_labels = None +depends_on = None + + +def upgrade(): + with op.batch_alter_table("server") as batch_op: + batch_op.alter_column('passexec_cmd', + existing_type=sa.String(length=256), + type_=sa.String()) + # ### end Alembic commands ### + + +def downgrade(): + # pgAdmin only upgrades, downgrade not implemented. + pass diff --git a/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js b/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js index 4c9a6be7b..87eca135f 100644 --- a/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js +++ b/web/pgadmin/browser/server_groups/servers/static/js/server.ui.js @@ -335,7 +335,7 @@ export default class ServerSchema extends BaseUISchema { }, { id: 'passexec_cmd', label: gettext('Password exec command'), type: 'text', - group: gettext('Advanced'), + group: gettext('Advanced'), controlProps: {maxLength: null}, mode: ['properties', 'edit', 'create'], disabled: pgAdmin.server_mode == 'True', }, diff --git a/web/pgadmin/model/__init__.py b/web/pgadmin/model/__init__.py index d76f94ad7..a44b56bfa 100644 --- a/web/pgadmin/model/__init__.py +++ b/web/pgadmin/model/__init__.py @@ -33,7 +33,7 @@ import config # ########################################################################## -SCHEMA_VERSION = 37 +SCHEMA_VERSION = 38 ########################################################################## #