From 6988ce96d7a32eaa64c05e1bb2424426f68b9b2e Mon Sep 17 00:00:00 2001 From: Aditya Toshniwal Date: Mon, 23 Mar 2020 18:15:39 +0530 Subject: [PATCH] Change some colors and opacity to comply with WCAG color contrast standards. Fixes #5128 --- docs/en_US/release_notes_4_20.rst | 1 + web/pgadmin/static/scss/resources/_default.variables.scss | 8 ++++---- .../static/scss/resources/dark/_theme.variables.scss | 6 +++--- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/docs/en_US/release_notes_4_20.rst b/docs/en_US/release_notes_4_20.rst index 2f1706f78..e5a224fe8 100644 --- a/docs/en_US/release_notes_4_20.rst +++ b/docs/en_US/release_notes_4_20.rst @@ -22,6 +22,7 @@ Bug fixes | `Issue #4237 `_ - Fix an issue where the user can not change the value of DateTime picker control using keyboard. | `Issue #4608 `_ - Fixed some accessibility issues in the dialogs. | `Issue #4942 `_ - Fixed chrome driver download utility issue for Ubuntu. +| `Issue #5128 `_ - Change some colors and opacity to comply with WCAG color contrast standards. | `Issue #5143 `_ - Fix an accessibility issue to maximize the panel for all alertify dialog. | `Issue #5221 `_ - Improve logic to get the DDL statements as a part of the comparison. | `Issue #5279 `_ - Fixed Unicode character issue causing error on Python2 environment. \ No newline at end of file diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss index 9fe30cb9e..3cbac83db 100644 --- a/web/pgadmin/static/scss/resources/_default.variables.scss +++ b/web/pgadmin/static/scss/resources/_default.variables.scss @@ -23,7 +23,7 @@ $color-danger-fg: $white !default; $color-danger-light: #F39999 !default; $color-danger-lighter: #FAECEC !default; -$color-success: #43a047 !default; +$color-success: #26852B !default; $color-success-fg: $black !default; $color-success-light: #D9ECDA !default; @@ -60,7 +60,7 @@ $text-height-calc: $line-height-base*$font-size-base/1rem; $grid-gutter-width: 15px; $border-radius: 0.25rem; -$text-muted: $color-gray-dark !default; +$text-muted: #667185 !default; $header-bg: $color-bg !default; $tree-font-size: 0.815rem; @@ -101,7 +101,7 @@ $popover-border-color: $dropdown-border-color; $popover-box-shadow: $dropdown-box-shadow; $input-btn-focus-width: 0.1rem; -$btn-disabled-opacity: 0.5; +$btn-disabled-opacity: 0.65; $btn-transition: color .05s ease-in-out, background-color .05s ease-in-out, border-color .05s ease-in-out, box-shadow .05s ease-in-out; $card-spacer-y: 0rem; @@ -218,7 +218,7 @@ $sql-title-bg: $color-ternary; $sql-title-fg: $color-ternary-fg; // Toolbar + editor title heights + title bottom border $sql-editor-panel-top: $title-height + $text-height-calc*16px + $sql-title-padding*2 + $panel-border-width - 0.5px; -$sql-gutters-bg: $negative-bg; +$sql-gutters-bg: $datagrid-bg; $sql-history-detail-bg: $color-gray-lighter; $sql-history-success-bg: $color-primary-light; $sql-history-success-fg: $active-color; diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss index 872fe6f62..21d5b4a14 100644 --- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss +++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss @@ -6,7 +6,7 @@ $color-fg: #d4d4d4; $color-primary: #234d6e; $color-primary-fg: $color-fg; -$color-primary-light: #536270; +$color-primary-light: #323E43; $color-primary-light-fg: $color-primary-fg; $color-primary-dark: #15354f; @@ -17,7 +17,7 @@ $color-danger-fg: $white; $color-danger-light: #914649; $color-danger-lighter: #212121; -$color-success: #43a047; +$color-success: #26852B; $color-success-fg: $black; $color-success-light: #2B472C; @@ -35,7 +35,7 @@ $color-brand: #1b71b5; $border-color: #4a4a4a; $shadow-base-color: #111111; -$text-muted: #6b6b6b; +$text-muted: #8A8A8A; $input-bg: $color-bg; $input-color: $color-fg; $input-border-color: #6b6b6b;