IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2026-08-09 04:28:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed following SoanrQube issues

Browse Source 
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
  2) Define a constant instead of duplicating this literal.

Solution:
  1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
  2) Declare the constant in PGChildNodeView for SQL files.
This commit is contained in:
Akshay Joshi
2020-07-16 19:39:55 +05:30
parent 5d8c79da38
commit 703faf3b15
55 changed files with 816 additions and 751 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/pgadmin/tools/schema_diff/compare.py
+1 -1
View File
@@ -92,7 +92,7 @@ class SchemaDiffObjectCompare:
source_dict=source,
target_dict=target,
node=self.node_type,
node_label=self.blueprint.COLLECTION_LABEL,
node_label=self.blueprint.collection_label,
ignore_whitespaces=ignore_whitespaces,
ignore_keys=self.keys_to_ignore)